diff options
Diffstat (limited to 'lib/gitlab/experimentation')
| -rw-r--r-- | lib/gitlab/experimentation/controller_concern.rb | 14 | ||||
| -rw-r--r-- | lib/gitlab/experimentation/experiment.rb | 3 |
2 files changed, 3 insertions, 14 deletions
diff --git a/lib/gitlab/experimentation/controller_concern.rb b/lib/gitlab/experimentation/controller_concern.rb index 2a43f0d5ca9..7cc29cde45c 100644 --- a/lib/gitlab/experimentation/controller_concern.rb +++ b/lib/gitlab/experimentation/controller_concern.rb @@ -48,7 +48,7 @@ module Gitlab Experimentation.log_invalid_rollout(experiment_key, subject) - subject ||= fallback_experimentation_subject_index(experiment_key) + subject ||= experimentation_subject_id Experimentation.in_experiment_group?(experiment_key, subject: subject) end @@ -106,16 +106,6 @@ module Gitlab cookies.signed[:experimentation_subject_id] end - def fallback_experimentation_subject_index(experiment_key) - return if experimentation_subject_id.blank? - - if Experimentation.get_experiment(experiment_key).use_backwards_compatible_subject_index - experimentation_subject_id.delete('-') - else - experimentation_subject_id - end - end - def track_experiment_event_for(experiment_key, action, value, subject: nil) return unless Experimentation.active?(experiment_key) @@ -139,7 +129,7 @@ module Gitlab def tracking_group(experiment_key, suffix = nil, subject: nil) return unless Experimentation.active?(experiment_key) - subject ||= fallback_experimentation_subject_index(experiment_key) + subject ||= experimentation_subject_id group = experiment_enabled?(experiment_key, subject: subject) ? GROUP_EXPERIMENTAL : GROUP_CONTROL suffix ? "#{group}#{suffix}" : group diff --git a/lib/gitlab/experimentation/experiment.rb b/lib/gitlab/experimentation/experiment.rb index 17dda45f5b7..8ba95520638 100644 --- a/lib/gitlab/experimentation/experiment.rb +++ b/lib/gitlab/experimentation/experiment.rb @@ -5,12 +5,11 @@ module Gitlab class Experiment FEATURE_FLAG_SUFFIX = "_experiment_percentage" - attr_reader :key, :tracking_category, :use_backwards_compatible_subject_index, :rollout_strategy + attr_reader :key, :tracking_category, :rollout_strategy def initialize(key, **params) @key = key @tracking_category = params[:tracking_category] - @use_backwards_compatible_subject_index = params[:use_backwards_compatible_subject_index] @rollout_strategy = params[:rollout_strategy] || :cookie end |