diff options
Diffstat (limited to 'spec/features/file_uploads/maven_package_spec.rb')
-rw-r--r-- | spec/features/file_uploads/maven_package_spec.rb | 21 |
1 files changed, 14 insertions, 7 deletions
diff --git a/spec/features/file_uploads/maven_package_spec.rb b/spec/features/file_uploads/maven_package_spec.rb index e87eec58618..ab9f023bd8f 100644 --- a/spec/features/file_uploads/maven_package_spec.rb +++ b/spec/features/file_uploads/maven_package_spec.rb @@ -6,16 +6,17 @@ RSpec.describe 'Upload a maven package', :api, :js do include_context 'file upload requests helpers' let_it_be(:project) { create(:project) } - let_it_be(:user) { create(:user, :admin) } + let_it_be(:user) { project.owner } let_it_be(:personal_access_token) { create(:personal_access_token, user: user) } - let(:api_path) { "/projects/#{project.id}/packages/maven/com/example/my-app/1.0/my-app-1.0-20180724.124855-1.jar" } + let(:project_id) { project.id } + let(:api_path) { "/projects/#{project_id}/packages/maven/com/example/my-app/1.0/my-app-1.0-20180724.124855-1.jar" } let(:url) { capybara_url(api(api_path, personal_access_token: personal_access_token)) } let(:file) { fixture_file_upload('spec/fixtures/dk.png') } subject { HTTParty.put(url, body: file.read) } - RSpec.shared_examples 'for a maven package' do + shared_examples 'for a maven package' do it 'creates package files' do expect { subject } .to change { Packages::Package.maven.count }.by(1) @@ -25,9 +26,9 @@ RSpec.describe 'Upload a maven package', :api, :js do it { expect(subject.code).to eq(200) } end - RSpec.shared_examples 'for a maven sha1' do + shared_examples 'for a maven sha1' do let(:dummy_package) { double(Packages::Package) } - let(:api_path) { "/projects/#{project.id}/packages/maven/com/example/my-app/1.0/my-app-1.0-20180724.124855-1.jar.sha1" } + let(:api_path) { "/projects/#{project_id}/packages/maven/com/example/my-app/1.0/my-app-1.0-20180724.124855-1.jar.sha1" } before do # The sha verification done by the maven api is between: @@ -42,8 +43,8 @@ RSpec.describe 'Upload a maven package', :api, :js do it { expect(subject.code).to eq(204) } end - RSpec.shared_examples 'for a maven md5' do - let(:api_path) { "/projects/#{project.id}/packages/maven/com/example/my-app/1.0/my-app-1.0-20180724.124855-1.jar.md5" } + shared_examples 'for a maven md5' do + let(:api_path) { "/projects/#{project_id}/packages/maven/com/example/my-app/1.0/my-app-1.0-20180724.124855-1.jar.md5" } let(:file) { StringIO.new('dummy_package') } it { expect(subject.code).to eq(200) } @@ -52,4 +53,10 @@ RSpec.describe 'Upload a maven package', :api, :js do it_behaves_like 'handling file uploads', 'for a maven package' it_behaves_like 'handling file uploads', 'for a maven sha1' it_behaves_like 'handling file uploads', 'for a maven md5' + + context 'with an encoded project ID' do + let(:project_id) { "#{project.namespace.path}%2F#{project.path}" } + + it_behaves_like 'handling file uploads', 'for a maven package' + end end |