1 files changed, 58 insertions, 80 deletions
diff --git a/spec/features/projects/wiki/user_views_wiki_empty_spec.rb b/spec/features/projects/wiki/user_views_wiki_empty_spec.rb
index 0af40a2d760..1f460f39267 100644
--- a/spec/features/projects/wiki/user_views_wiki_empty_spec.rb
+++ b/spec/features/projects/wiki/user_views_wiki_empty_spec.rb
@@ -2,108 +2,86 @@
 
 require 'spec_helper'
 
-RSpec.describe 'User views empty wiki' do
-  let(:user) { create(:user) }
-  let(:confluence_link) { 'Enable the Confluence Wiki integration' }
-  let(:element) { page.find('.row.empty-state') }
-
-  shared_examples 'empty wiki and accessible issues' do
-    it 'show "issue tracker" message' do
-      visit(project_wikis_path(project))
-
-      expect(element).to have_content('This project has no wiki pages')
-      expect(element).to have_content('You must be a project member')
-      expect(element).to have_content('improve the wiki for this project')
-      expect(element).to have_link("issue tracker", href: project_issues_path(project))
-      expect(element).to have_link("Suggest wiki improvement", href: new_project_issue_path(project))
-      expect(element).to have_no_link(confluence_link)
-    end
-  end
-
-  shared_examples 'empty wiki and non-accessible issues' do
-    it 'does not show "issue tracker" message' do
-      visit(project_wikis_path(project))
+RSpec.describe 'Project > User views empty wiki' do
+  let_it_be(:user) { create(:user) }
 
-      expect(element).to have_content('This project has no wiki pages')
-      expect(element).to have_content('You must be a project member')
-      expect(element).to have_no_link('Suggest wiki improvement')
-      expect(element).to have_no_link(confluence_link)
-    end
-  end
+  let(:wiki) { create(:project_wiki, project: project) }
 
-  context 'when user is logged out and issue tracker is public' do
-    let(:project) { create(:project, :public, :wiki_repo) }
+  it_behaves_like 'User views empty wiki' do
+    context 'when project is public' do
+      let(:project) { create(:project, :public) }
 
-    it_behaves_like 'empty wiki and accessible issues'
-  end
+      it_behaves_like 'empty wiki message', issuable: true
 
-  context 'when user is logged in and not a member' do
-    let(:project) { create(:project, :public, :wiki_repo) }
+      context 'when issue tracker is private' do
+        let(:project) { create(:project, :public, :issues_private) }
 
-    before do
-      sign_in(user)
-    end
+        it_behaves_like 'empty wiki message', issuable: false
+      end
 
-    it_behaves_like 'empty wiki and accessible issues'
-  end
+      context 'when issue tracker is disabled' do
+        let(:project) { create(:project, :public, :issues_disabled) }
 
-  context 'when issue tracker is private' do
-    let(:project) { create(:project, :public, :wiki_repo, :issues_private) }
+        it_behaves_like 'empty wiki message', issuable: false
+      end
 
-    it_behaves_like 'empty wiki and non-accessible issues'
-  end
+      context 'and user is logged in' do
+        before do
+          sign_in(user)
+        end
 
-  context 'when issue tracker is disabled' do
-    let(:project) { create(:project, :public, :wiki_repo, :issues_disabled) }
+        context 'and user is not a member' do
+          it_behaves_like 'empty wiki message', issuable: true
+        end
 
-    it_behaves_like 'empty wiki and non-accessible issues'
-  end
+        context 'and user is a member' do
+          before do
+            project.add_developer(user)
+          end
 
-  context 'when user is logged in and a member' do
-    let(:project) { create(:project, :public) }
-
-    before do
-      sign_in(user)
-      project.add_developer(user)
+          it_behaves_like 'empty wiki message', writable: true, issuable: true
+        end
+      end
     end
 
-    it 'shows "create first page" message' do
-      visit(project_wikis_path(project))
-
-      expect(element).to have_content('your project', count: 2)
+    context 'when project is private' do
+      let(:project) { create(:project, :private) }
 
-      element.click_link 'Create your first page'
+      it_behaves_like 'wiki is not found'
 
-      expect(page).to have_button('Create page')
-    end
+      context 'and user is logged in' do
+        before do
+          sign_in(user)
+        end
 
-    it 'does not show the "enable confluence" button' do
-      visit(project_wikis_path(project))
+        context 'and user is not a member' do
+          it_behaves_like 'wiki is not found'
+        end
 
-      expect(element).to have_no_link(confluence_link)
-    end
-  end
+        context 'and user is a member' do
+          before do
+            project.add_developer(user)
+          end
 
-  context 'when user is logged in and an admin' do
-    let(:project) { create(:project, :public, :wiki_repo) }
+          it_behaves_like 'empty wiki message', writable: true, issuable: true
+        end
 
-    before do
-      sign_in(user)
-      project.add_maintainer(user)
-    end
-
-    it 'shows the "enable confluence" button' do
-      visit(project_wikis_path(project))
-
-      expect(element).to have_link(confluence_link)
-    end
+        context 'and user is a maintainer' do
+          before do
+            project.add_maintainer(user)
+          end
 
-    it 'does not show "enable confluence" button if confluence is already enabled' do
-      create(:confluence_service, project: project)
+          it_behaves_like 'empty wiki message', writable: true, issuable: true, confluence: true
 
-      visit(project_wikis_path(project))
+          context 'and Confluence is already enabled' do
+            before do
+              create(:confluence_service, project: project)
+            end
 
-      expect(element).to have_no_link(confluence_link)
+            it_behaves_like 'empty wiki message', writable: true, issuable: true, confluence: false
+          end
+        end
+      end
     end
   end
 end