diff options
Diffstat (limited to 'spec/frontend/issues/new/components/title_suggestions_spec.js')
-rw-r--r-- | spec/frontend/issues/new/components/title_suggestions_spec.js | 57 |
1 files changed, 25 insertions, 32 deletions
diff --git a/spec/frontend/issues/new/components/title_suggestions_spec.js b/spec/frontend/issues/new/components/title_suggestions_spec.js index f6b93cc5a62..0a64890e4ca 100644 --- a/spec/frontend/issues/new/components/title_suggestions_spec.js +++ b/spec/frontend/issues/new/components/title_suggestions_spec.js @@ -1,4 +1,5 @@ import { shallowMount } from '@vue/test-utils'; +import { nextTick } from 'vue'; import TitleSuggestions from '~/issues/new/components/title_suggestions.vue'; import TitleSuggestionsItem from '~/issues/new/components/title_suggestions_item.vue'; @@ -22,12 +23,11 @@ describe('Issue title suggestions component', () => { wrapper.destroy(); }); - it('does not render with empty search', () => { + it('does not render with empty search', async () => { wrapper.setProps({ search: '' }); - return wrapper.vm.$nextTick().then(() => { - expect(wrapper.isVisible()).toBe(false); - }); + await nextTick(); + expect(wrapper.isVisible()).toBe(false); }); describe('with data', () => { @@ -37,28 +37,26 @@ describe('Issue title suggestions component', () => { data = { issues: [{ id: 1 }, { id: 2 }] }; }); - it('renders component', () => { + it('renders component', async () => { // setData usage is discouraged. See https://gitlab.com/groups/gitlab-org/-/epics/7330 for details // eslint-disable-next-line no-restricted-syntax wrapper.setData(data); - return wrapper.vm.$nextTick(() => { - expect(wrapper.findAll('li').length).toBe(data.issues.length); - }); + await nextTick(); + expect(wrapper.findAll('li').length).toBe(data.issues.length); }); - it('does not render with empty search', () => { + it('does not render with empty search', async () => { wrapper.setProps({ search: '' }); // setData usage is discouraged. See https://gitlab.com/groups/gitlab-org/-/epics/7330 for details // eslint-disable-next-line no-restricted-syntax wrapper.setData(data); - return wrapper.vm.$nextTick(() => { - expect(wrapper.isVisible()).toBe(false); - }); + await nextTick(); + expect(wrapper.isVisible()).toBe(false); }); - it('does not render when loading', () => { + it('does not render when loading', async () => { // setData usage is discouraged. See https://gitlab.com/groups/gitlab-org/-/epics/7330 for details // eslint-disable-next-line no-restricted-syntax wrapper.setData({ @@ -66,49 +64,44 @@ describe('Issue title suggestions component', () => { loading: 1, }); - return wrapper.vm.$nextTick(() => { - expect(wrapper.isVisible()).toBe(false); - }); + await nextTick(); + expect(wrapper.isVisible()).toBe(false); }); - it('does not render with empty issues data', () => { + it('does not render with empty issues data', async () => { // setData usage is discouraged. See https://gitlab.com/groups/gitlab-org/-/epics/7330 for details // eslint-disable-next-line no-restricted-syntax wrapper.setData({ issues: [] }); - return wrapper.vm.$nextTick(() => { - expect(wrapper.isVisible()).toBe(false); - }); + await nextTick(); + expect(wrapper.isVisible()).toBe(false); }); - it('renders list of issues', () => { + it('renders list of issues', async () => { // setData usage is discouraged. See https://gitlab.com/groups/gitlab-org/-/epics/7330 for details // eslint-disable-next-line no-restricted-syntax wrapper.setData(data); - return wrapper.vm.$nextTick(() => { - expect(wrapper.findAll(TitleSuggestionsItem).length).toBe(2); - }); + await nextTick(); + expect(wrapper.findAll(TitleSuggestionsItem).length).toBe(2); }); - it('adds margin class to first item', () => { + it('adds margin class to first item', async () => { // setData usage is discouraged. See https://gitlab.com/groups/gitlab-org/-/epics/7330 for details // eslint-disable-next-line no-restricted-syntax wrapper.setData(data); - return wrapper.vm.$nextTick(() => { - expect(wrapper.findAll('li').at(0).classes()).toContain('gl-mb-3'); - }); + await nextTick(); + expect(wrapper.findAll('li').at(0).classes()).toContain('gl-mb-3'); }); - it('does not add margin class to last item', () => { + it('does not add margin class to last item', async () => { // setData usage is discouraged. See https://gitlab.com/groups/gitlab-org/-/epics/7330 for details // eslint-disable-next-line no-restricted-syntax wrapper.setData(data); - return wrapper.vm.$nextTick(() => { - expect(wrapper.findAll('li').at(1).classes()).not.toContain('gl-mb-3'); - }); + await nextTick(); + expect(wrapper.findAll('li').at(1).classes()).not.toContain('gl-mb-3'); }); }); }); |