diff options
Diffstat (limited to 'spec/frontend/vue_merge_request_widget/extentions/code_quality/index_spec.js')
-rw-r--r-- | spec/frontend/vue_merge_request_widget/extentions/code_quality/index_spec.js | 55 |
1 files changed, 37 insertions, 18 deletions
diff --git a/spec/frontend/vue_merge_request_widget/extentions/code_quality/index_spec.js b/spec/frontend/vue_merge_request_widget/extentions/code_quality/index_spec.js index 9a72e4a086b..f0ebbb1a82e 100644 --- a/spec/frontend/vue_merge_request_widget/extentions/code_quality/index_spec.js +++ b/spec/frontend/vue_merge_request_widget/extentions/code_quality/index_spec.js @@ -1,4 +1,5 @@ import MockAdapter from 'axios-mock-adapter'; +import { GlBadge } from '@gitlab/ui'; import { mountExtended } from 'helpers/vue_test_utils_helper'; import { trimText } from 'helpers/text_helper'; import waitForPromises from 'helpers/wait_for_promises'; @@ -6,10 +7,10 @@ import axios from '~/lib/utils/axios_utils'; import extensionsContainer from '~/vue_merge_request_widget/components/extensions/container'; import { registerExtension } from '~/vue_merge_request_widget/components/extensions'; import codeQualityExtension from '~/vue_merge_request_widget/extensions/code_quality'; -import httpStatusCodes from '~/lib/utils/http_status'; +import httpStatusCodes, { HTTP_STATUS_NO_CONTENT } from '~/lib/utils/http_status'; +import { i18n } from '~/vue_merge_request_widget/extensions/code_quality/constants'; import { codeQualityResponseNewErrors, - codeQualityResponseResolvedErrors, codeQualityResponseResolvedAndNewErrors, codeQualityResponseNoErrors, } from './mock_data'; @@ -58,46 +59,55 @@ describe('Code Quality extension', () => { createComponent(); - expect(wrapper.text()).toBe('Code Quality test metrics results are being parsed'); + expect(wrapper.text()).toBe(i18n.loading); }); - it('displays failed loading text', async () => { - mockApi(httpStatusCodes.INTERNAL_SERVER_ERROR); - + it('with a 204 response, continues to display loading state', async () => { + mockApi(HTTP_STATUS_NO_CONTENT, ''); createComponent(); await waitForPromises(); - expect(wrapper.text()).toBe('Code Quality failed loading results'); + + expect(wrapper.text()).toBe(i18n.loading); }); - it('displays quality degradation', async () => { - mockApi(httpStatusCodes.OK, codeQualityResponseNewErrors); + it('displays failed loading text', async () => { + mockApi(httpStatusCodes.INTERNAL_SERVER_ERROR); createComponent(); await waitForPromises(); - - expect(wrapper.text()).toBe('Code Quality degraded on 2 points.'); + expect(wrapper.text()).toBe(i18n.error); }); - it('displays quality improvement', async () => { - mockApi(httpStatusCodes.OK, codeQualityResponseResolvedErrors); + it('displays correct single Report', async () => { + mockApi(httpStatusCodes.OK, codeQualityResponseNewErrors); createComponent(); await waitForPromises(); - expect(wrapper.text()).toBe('Code Quality improved on 2 points.'); + expect(wrapper.text()).toBe( + i18n.degradedCopy(i18n.singularReport(codeQualityResponseNewErrors.new_errors)), + ); }); it('displays quality improvement and degradation', async () => { mockApi(httpStatusCodes.OK, codeQualityResponseResolvedAndNewErrors); createComponent(); - await waitForPromises(); - expect(wrapper.text()).toBe('Code Quality improved on 1 point and degraded on 1 point.'); + // replacing strong tags because they will not be found in the rendered text + expect(wrapper.text()).toBe( + i18n + .improvementAndDegradationCopy( + i18n.pluralReport(codeQualityResponseResolvedAndNewErrors.resolved_errors), + i18n.pluralReport(codeQualityResponseResolvedAndNewErrors.new_errors), + ) + .replace(/%{strong_start}/g, '') + .replace(/%{strong_end}/g, ''), + ); }); it('displays no detected errors', async () => { @@ -107,7 +117,7 @@ describe('Code Quality extension', () => { await waitForPromises(); - expect(wrapper.text()).toBe('No changes to Code Quality.'); + expect(wrapper.text()).toBe(i18n.noChanges); }); }); @@ -138,8 +148,17 @@ describe('Code Quality extension', () => { "Minor - Parsing error: 'return' outside of function in index.js:12", ); expect(text.resolvedError).toContain( - "Minor - Parsing error: 'return' outside of function in index.js:12", + "Minor - Parsing error: 'return' outside of function Fixed in index.js:12", ); }); + + it('adds fixed indicator (badge) when error is resolved', () => { + expect(findAllExtensionListItems().at(1).findComponent(GlBadge).exists()).toBe(true); + expect(findAllExtensionListItems().at(1).findComponent(GlBadge).text()).toEqual(i18n.fixed); + }); + + it('should not add fixed indicator (badge) when error is new', () => { + expect(findAllExtensionListItems().at(0).findComponent(GlBadge).exists()).toBe(false); + }); }); }); |