3 files changed, 111 insertions, 111 deletions

diff --git a/spec/lib/backup/files_spec.rb b/spec/lib/backup/files_spec.rb
index 63f2298357f..232d6a2c849 100644
--- a/spec/lib/backup/files_spec.rb
+++ b/spec/lib/backup/files_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Backup::Files do
   let(:progress) { StringIO.new }
@@ -20,60 +20,60 @@ describe Backup::Files do
     allow_any_instance_of(described_class).to receive(:progress).and_return(progress)
   end
 
-  describe '#restore' do
-    subject { described_class.new('registry', '/var/gitlab-registry') }
+  describe "#restore" do
+    subject { described_class.new("registry", "/var/gitlab-registry") }
     let(:timestamp) { Time.utc(2017, 3, 22) }
 
     around do |example|
       Timecop.freeze(timestamp) { example.run }
     end
 
-    describe 'folders with permission' do
+    describe "folders with permission" do
       before do
         allow(subject).to receive(:run_pipeline!).and_return(true)
         allow(subject).to receive(:backup_existing_files).and_return(true)
         allow(Dir).to receive(:glob).with("/var/gitlab-registry/*", File::FNM_DOTMATCH).and_return(["/var/gitlab-registry/.", "/var/gitlab-registry/..", "/var/gitlab-registry/sample1"])
       end
 
-      it 'moves all necessary files' do
+      it "moves all necessary files" do
         allow(subject).to receive(:backup_existing_files).and_call_original
         expect(FileUtils).to receive(:mv).with(["/var/gitlab-registry/sample1"], File.join(Gitlab.config.backup.path, "tmp", "registry.#{Time.now.to_i}"))
         subject.restore
       end
 
-      it 'raises no errors' do
+      it "raises no errors" do
         expect { subject.restore }.not_to raise_error
       end
 
-      it 'calls tar command with unlink' do
-        expect(subject).to receive(:tar).and_return('blabla-tar')
+      it "calls tar command with unlink" do
+        expect(subject).to receive(:tar).and_return("blabla-tar")
 
-        expect(subject).to receive(:run_pipeline!).with([%w(gzip -cd), %w(blabla-tar --unlink-first --recursive-unlink -C /var/gitlab-registry -xf -)], any_args)
+        expect(subject).to receive(:run_pipeline!).with([%w[gzip -cd], %w[blabla-tar --unlink-first --recursive-unlink -C /var/gitlab-registry -xf -]], any_args)
         subject.restore
       end
     end
 
-    describe 'folders without permissions' do
+    describe "folders without permissions" do
       before do
         allow(FileUtils).to receive(:mv).and_raise(Errno::EACCES)
         allow(subject).to receive(:run_pipeline!).and_return(true)
       end
 
-      it 'shows error message' do
+      it "shows error message" do
         expect(subject).to receive(:access_denied_error).with("/var/gitlab-registry")
         subject.restore
       end
     end
 
-    describe 'folders that are a mountpoint' do
+    describe "folders that are a mountpoint" do
       before do
         allow(FileUtils).to receive(:mv).and_raise(Errno::EBUSY)
         allow(subject).to receive(:run_pipeline!).and_return(true)
       end
 
-      it 'shows error message' do
+      it "shows error message" do
         expect(subject).to receive(:resource_busy_error).with("/var/gitlab-registry")
-                             .and_call_original
+          .and_call_original
 
         expect { subject.restore }.to raise_error(/is a mountpoint/)
       end
diff --git a/spec/lib/backup/manager_spec.rb b/spec/lib/backup/manager_spec.rb
index ae1c881e1f6..95193bf719d 100644
--- a/spec/lib/backup/manager_spec.rb
+++ b/spec/lib/backup/manager_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Backup::Manager do
   include StubENV
@@ -19,19 +19,19 @@ describe Backup::Manager do
     $progress = @old_progress # rubocop:disable Style/GlobalVars
   end
 
-  describe '#remove_old' do
+  describe "#remove_old" do
     let(:files) do
       [
-        '1451606400_2016_01_01_1.2.3_gitlab_backup.tar',
-        '1451520000_2015_12_31_4.5.6_gitlab_backup.tar',
-        '1451520000_2015_12_31_4.5.6-pre_gitlab_backup.tar',
-        '1451520000_2015_12_31_4.5.6-rc1_gitlab_backup.tar',
-        '1451520000_2015_12_31_4.5.6-pre-ee_gitlab_backup.tar',
-        '1451510000_2015_12_30_gitlab_backup.tar',
-        '1450742400_2015_12_22_gitlab_backup.tar',
-        '1449878400_gitlab_backup.tar',
-        '1449014400_gitlab_backup.tar',
-        'manual_gitlab_backup.tar'
+        "1451606400_2016_01_01_1.2.3_gitlab_backup.tar",
+        "1451520000_2015_12_31_4.5.6_gitlab_backup.tar",
+        "1451520000_2015_12_31_4.5.6-pre_gitlab_backup.tar",
+        "1451520000_2015_12_31_4.5.6-rc1_gitlab_backup.tar",
+        "1451520000_2015_12_31_4.5.6-pre-ee_gitlab_backup.tar",
+        "1451510000_2015_12_30_gitlab_backup.tar",
+        "1450742400_2015_12_22_gitlab_backup.tar",
+        "1449878400_gitlab_backup.tar",
+        "1449014400_gitlab_backup.tar",
+        "manual_gitlab_backup.tar",
       ]
     end
 
@@ -42,28 +42,28 @@ describe Backup::Manager do
       allow(Time).to receive(:now).and_return(Time.utc(2016))
     end
 
-    context 'when keep_time is zero' do
+    context "when keep_time is zero" do
       before do
         allow(Gitlab.config.backup).to receive(:keep_time).and_return(0)
 
         subject.remove_old
       end
 
-      it 'removes no files' do
+      it "removes no files" do
         expect(FileUtils).not_to have_received(:rm)
       end
 
-      it 'prints a skipped message' do
-        expect(progress).to have_received(:puts).with('skipping')
+      it "prints a skipped message" do
+        expect(progress).to have_received(:puts).with("skipping")
       end
     end
 
-    context 'when no valid file is found' do
+    context "when no valid file is found" do
       let(:files) do
         [
-          '14516064000_2016_01_01_1.2.3_gitlab_backup.tar',
-          'foo_1451520000_2015_12_31_4.5.6_gitlab_backup.tar',
-          '1451520000_2015_12_31_4.5.6-foo_gitlab_backup.tar'
+          "14516064000_2016_01_01_1.2.3_gitlab_backup.tar",
+          "foo_1451520000_2015_12_31_4.5.6_gitlab_backup.tar",
+          "1451520000_2015_12_31_4.5.6-foo_gitlab_backup.tar",
         ]
       end
 
@@ -73,16 +73,16 @@ describe Backup::Manager do
         subject.remove_old
       end
 
-      it 'removes no files' do
+      it "removes no files" do
         expect(FileUtils).not_to have_received(:rm)
       end
 
-      it 'prints a done message' do
-        expect(progress).to have_received(:puts).with('done. (0 removed)')
+      it "prints a done message" do
+        expect(progress).to have_received(:puts).with("done. (0 removed)")
       end
     end
 
-    context 'when there are no files older than keep_time' do
+    context "when there are no files older than keep_time" do
       before do
         # Set to 30 days
         allow(Gitlab.config.backup).to receive(:keep_time).and_return(2592000)
@@ -90,16 +90,16 @@ describe Backup::Manager do
         subject.remove_old
       end
 
-      it 'removes no files' do
+      it "removes no files" do
         expect(FileUtils).not_to have_received(:rm)
       end
 
-      it 'prints a done message' do
-        expect(progress).to have_received(:puts).with('done. (0 removed)')
+      it "prints a done message" do
+        expect(progress).to have_received(:puts).with("done. (0 removed)")
       end
     end
 
-    context 'when keep_time is set to remove files' do
+    context "when keep_time is set to remove files" do
       before do
         # Set to 1 second
         allow(Gitlab.config.backup).to receive(:keep_time).and_return(1)
@@ -107,40 +107,40 @@ describe Backup::Manager do
         subject.remove_old
       end
 
-      it 'removes matching files with a human-readable versioned timestamp' do
+      it "removes matching files with a human-readable versioned timestamp" do
         expect(FileUtils).to have_received(:rm).with(files[1])
         expect(FileUtils).to have_received(:rm).with(files[2])
         expect(FileUtils).to have_received(:rm).with(files[3])
       end
 
-      it 'removes matching files with a human-readable versioned timestamp with tagged EE' do
+      it "removes matching files with a human-readable versioned timestamp with tagged EE" do
         expect(FileUtils).to have_received(:rm).with(files[4])
       end
 
-      it 'removes matching files with a human-readable non-versioned timestamp' do
+      it "removes matching files with a human-readable non-versioned timestamp" do
         expect(FileUtils).to have_received(:rm).with(files[5])
         expect(FileUtils).to have_received(:rm).with(files[6])
       end
 
-      it 'removes matching files without a human-readable timestamp' do
+      it "removes matching files without a human-readable timestamp" do
         expect(FileUtils).to have_received(:rm).with(files[7])
         expect(FileUtils).to have_received(:rm).with(files[8])
       end
 
-      it 'does not remove files that are not old enough' do
+      it "does not remove files that are not old enough" do
         expect(FileUtils).not_to have_received(:rm).with(files[0])
       end
 
-      it 'does not remove non-matching files' do
+      it "does not remove non-matching files" do
         expect(FileUtils).not_to have_received(:rm).with(files[9])
       end
 
-      it 'prints a done message' do
-        expect(progress).to have_received(:puts).with('done. (8 removed)')
+      it "prints a done message" do
+        expect(progress).to have_received(:puts).with("done. (8 removed)")
       end
     end
 
-    context 'when removing a file fails' do
+    context "when removing a file fails" do
       let(:file) { files[1] }
       let(:message) { "Permission denied @ unlink_internal - #{file}" }
 
@@ -151,7 +151,7 @@ describe Backup::Manager do
         subject.remove_old
       end
 
-      it 'removes the remaining expected files' do
+      it "removes the remaining expected files" do
         expect(FileUtils).to have_received(:rm).with(files[4])
         expect(FileUtils).to have_received(:rm).with(files[5])
         expect(FileUtils).to have_received(:rm).with(files[6])
@@ -159,98 +159,98 @@ describe Backup::Manager do
         expect(FileUtils).to have_received(:rm).with(files[8])
       end
 
-      it 'sets the correct removed count' do
-        expect(progress).to have_received(:puts).with('done. (7 removed)')
+      it "sets the correct removed count" do
+        expect(progress).to have_received(:puts).with("done. (7 removed)")
       end
 
-      it 'prints the error from file that could not be removed' do
+      it "prints the error from file that could not be removed" do
         expect(progress).to have_received(:puts).with(a_string_matching(message))
       end
     end
   end
 
-  describe '#unpack' do
-    context 'when there are no backup files in the directory' do
+  describe "#unpack" do
+    context "when there are no backup files in the directory" do
       before do
         allow(Dir).to receive(:glob).and_return([])
       end
 
-      it 'fails the operation and prints an error' do
+      it "fails the operation and prints an error" do
         expect { subject.unpack }.to raise_error SystemExit
         expect(progress).to have_received(:puts)
-          .with(a_string_matching('No backups found'))
+          .with(a_string_matching("No backups found"))
       end
     end
 
-    context 'when there are two backup files in the directory and BACKUP variable is not set' do
+    context "when there are two backup files in the directory and BACKUP variable is not set" do
       before do
         allow(Dir).to receive(:glob).and_return(
           [
-            '1451606400_2016_01_01_1.2.3_gitlab_backup.tar',
-            '1451520000_2015_12_31_gitlab_backup.tar'
+            "1451606400_2016_01_01_1.2.3_gitlab_backup.tar",
+            "1451520000_2015_12_31_gitlab_backup.tar",
           ]
         )
       end
 
-      it 'prints the list of available backups' do
+      it "prints the list of available backups" do
         expect { subject.unpack }.to raise_error SystemExit
         expect(progress).to have_received(:puts)
           .with(a_string_matching('1451606400_2016_01_01_1.2.3\n 1451520000_2015_12_31'))
       end
 
-      it 'fails the operation and prints an error' do
+      it "fails the operation and prints an error" do
         expect { subject.unpack }.to raise_error SystemExit
         expect(progress).to have_received(:puts)
-          .with(a_string_matching('Found more than one backup'))
+          .with(a_string_matching("Found more than one backup"))
       end
     end
 
-    context 'when BACKUP variable is set to a non-existing file' do
+    context "when BACKUP variable is set to a non-existing file" do
       before do
         allow(Dir).to receive(:glob).and_return(
           [
-            '1451606400_2016_01_01_gitlab_backup.tar'
+            "1451606400_2016_01_01_gitlab_backup.tar",
           ]
         )
         allow(File).to receive(:exist?).and_return(false)
 
-        stub_env('BACKUP', 'wrong')
+        stub_env("BACKUP", "wrong")
       end
 
-      it 'fails the operation and prints an error' do
+      it "fails the operation and prints an error" do
         expect { subject.unpack }.to raise_error SystemExit
-        expect(File).to have_received(:exist?).with('wrong_gitlab_backup.tar')
+        expect(File).to have_received(:exist?).with("wrong_gitlab_backup.tar")
         expect(progress).to have_received(:puts)
-          .with(a_string_matching('The backup file wrong_gitlab_backup.tar does not exist'))
+          .with(a_string_matching("The backup file wrong_gitlab_backup.tar does not exist"))
       end
     end
 
-    context 'when BACKUP variable is set to a correct file' do
+    context "when BACKUP variable is set to a correct file" do
       before do
         allow(Dir).to receive(:glob).and_return(
           [
-            '1451606400_2016_01_01_1.2.3_gitlab_backup.tar'
+            "1451606400_2016_01_01_1.2.3_gitlab_backup.tar",
           ]
         )
         allow(File).to receive(:exist?).and_return(true)
         allow(Kernel).to receive(:system).and_return(true)
         allow(YAML).to receive(:load_file).and_return(gitlab_version: Gitlab::VERSION)
 
-        stub_env('BACKUP', '1451606400_2016_01_01_1.2.3')
+        stub_env("BACKUP", "1451606400_2016_01_01_1.2.3")
       end
 
-      it 'unpacks the file' do
+      it "unpacks the file" do
         subject.unpack
 
         expect(Kernel).to have_received(:system)
           .with("tar", "-xf", "1451606400_2016_01_01_1.2.3_gitlab_backup.tar")
-        expect(progress).to have_received(:puts).with(a_string_matching('done'))
+        expect(progress).to have_received(:puts).with(a_string_matching("done"))
       end
     end
   end
 
-  describe '#upload' do
-    let(:backup_file) { Tempfile.new('backup', Gitlab.config.backup.path) }
+  describe "#upload" do
+    let(:backup_file) { Tempfile.new("backup", Gitlab.config.backup.path) }
     let(:backup_filename) { File.basename(backup_file.path) }
 
     before do
@@ -259,15 +259,15 @@ describe Backup::Manager do
       stub_backup_setting(
         upload: {
           connection: {
-            provider: 'AWS',
-            aws_access_key_id: 'id',
-            aws_secret_access_key: 'secret'
+            provider: "AWS",
+            aws_access_key_id: "id",
+            aws_secret_access_key: "secret",
           },
-          remote_directory: 'directory',
+          remote_directory: "directory",
           multipart_chunk_size: 104857600,
           encryption: nil,
           encryption_key: nil,
-          storage_class: nil
+          storage_class: nil,
         }
       )
 
@@ -278,8 +278,8 @@ describe Backup::Manager do
       connection.directories.create(key: Gitlab.config.backup.upload.remote_directory)
     end
 
-    context 'target path' do
-      it 'uses the tar filename by default' do
+    context "target path" do
+      it "uses the tar filename by default" do
         expect_any_instance_of(Fog::Collection).to receive(:create)
           .with(hash_including(key: backup_filename))
           .and_return(true)
@@ -289,8 +289,8 @@ describe Backup::Manager do
         end
       end
 
-      it 'adds the DIRECTORY environment variable if present' do
-        stub_env('DIRECTORY', 'daily')
+      it "adds the DIRECTORY environment variable if present" do
+        stub_env("DIRECTORY", "daily")
 
         expect_any_instance_of(Fog::Collection).to receive(:create)
           .with(hash_including(key: "daily/#{backup_filename}"))
diff --git a/spec/lib/backup/repository_spec.rb b/spec/lib/backup/repository_spec.rb
index 5ace5c5b1a2..ce577cfd1da 100644
--- a/spec/lib/backup/repository_spec.rb
+++ b/spec/lib/backup/repository_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Backup::Repository do
   let(:progress) { StringIO.new }
@@ -14,24 +14,24 @@ describe Backup::Repository do
     allow_any_instance_of(described_class).to receive(:progress).and_return(progress)
   end
 
-  describe '#dump' do
-    describe 'repo failure' do
+  describe "#dump" do
+    describe "repo failure" do
       before do
-        allow(Gitlab::Popen).to receive(:popen).and_return(['normal output', 0])
+        allow(Gitlab::Popen).to receive(:popen).and_return(["normal output", 0])
       end
 
-      it 'does not raise error' do
+      it "does not raise error" do
         expect { subject.dump }.not_to raise_error
       end
     end
   end
 
-  describe '#restore' do
+  describe "#restore" do
     let(:timestamp) { Time.utc(2017, 3, 22) }
     let(:temp_dirs) do
       Gitlab.config.repositories.storages.map do |name, storage|
         Gitlab::GitalyClient::StorageSettings.allow_disk_access do
-          File.join(storage.legacy_disk_path, '..', 'repositories.old.' + timestamp.to_i.to_s)
+          File.join(storage.legacy_disk_path, "..", "repositories.old." + timestamp.to_i.to_s)
         end
       end
     end
@@ -44,23 +44,23 @@ describe Backup::Repository do
       temp_dirs.each { |path| FileUtils.rm_rf(path) }
     end
 
-    describe 'command failure' do
+    describe "command failure" do
       before do
         allow_any_instance_of(Gitlab::Shell).to receive(:create_repository).and_return(false)
       end
 
-      context 'hashed storage' do
-        it 'shows the appropriate error' do
+      context "hashed storage" do
+        it "shows the appropriate error" do
           subject.restore
 
           expect(progress).to have_received(:puts).with("[Failed] restoring #{project.full_path} repository")
         end
       end
 
-      context 'legacy storage' do
+      context "legacy storage" do
         let!(:project) { create(:project, :legacy_storage) }
 
-        it 'shows the appropriate error' do
+        it "shows the appropriate error" do
           subject.restore
 
           expect(progress).to have_received(:puts).with("[Failed] restoring #{project.full_path} repository")
@@ -68,8 +68,8 @@ describe Backup::Repository do
       end
     end
 
-    context 'restoring object pools' do
-      it 'schedules restoring of the pool' do
+    context "restoring object pools" do
+      it "schedules restoring of the pool" do
         pool_repository = create(:pool_repository, :failed)
         pool_repository.delete_object_pool
 
@@ -82,7 +82,7 @@ describe Backup::Repository do
     end
   end
 
-  describe '#prepare_directories', :seed_helper do
+  describe "#prepare_directories", :seed_helper do
     before do
       allow(FileUtils).to receive(:mkdir_p).and_call_original
       allow(FileUtils).to receive(:mv).and_call_original
@@ -92,7 +92,7 @@ describe Backup::Repository do
       ensure_seeds
     end
 
-    it' removes all repositories' do
+    it" removes all repositories" do
       # Sanity check: there should be something for us to delete
       expect(list_repositories).to include(File.join(SEED_STORAGE_PATH, TEST_REPO_PATH))
 
@@ -102,30 +102,30 @@ describe Backup::Repository do
     end
 
     def list_repositories
-      Dir[File.join(SEED_STORAGE_PATH, '*.git')]
+      Dir[File.join(SEED_STORAGE_PATH, "*.git")]
     end
   end
 
-  describe '#empty_repo?' do
-    context 'for a wiki' do
+  describe "#empty_repo?" do
+    context "for a wiki" do
       let(:wiki) { create(:project_wiki) }
 
-      it 'invalidates the emptiness cache' do
+      it "invalidates the emptiness cache" do
         expect(wiki.repository).to receive(:expire_emptiness_caches).once
 
         subject.send(:empty_repo?, wiki)
       end
 
-      context 'wiki repo has content' do
+      context "wiki repo has content" do
         let!(:wiki_page) { create(:wiki_page, wiki: wiki) }
 
-        it 'returns true, regardless of bad cache value' do
+        it "returns true, regardless of bad cache value" do
           expect(subject.send(:empty_repo?, wiki)).to be(false)
         end
       end
 
-      context 'wiki repo does not have content' do
-        it 'returns true, regardless of bad cache value' do
+      context "wiki repo does not have content" do
+        it "returns true, regardless of bad cache value" do
           expect(subject.send(:empty_repo?, wiki)).to be_truthy
         end
       end