summaryrefslogtreecommitdiff
path: root/spec/requests/api/members_spec.rb
diff options
context:
space:
mode:
Diffstat (limited to 'spec/requests/api/members_spec.rb')
-rw-r--r--spec/requests/api/members_spec.rb250
1 files changed, 125 insertions, 125 deletions
diff --git a/spec/requests/api/members_spec.rb b/spec/requests/api/members_spec.rb
index 79edbb301f2..92206ac76cc 100644
--- a/spec/requests/api/members_spec.rb
+++ b/spec/requests/api/members_spec.rb
@@ -1,7 +1,7 @@
-require 'spec_helper'
+require "spec_helper"
describe API::Members do
- let(:maintainer) { create(:user, username: 'maintainer_user') }
+ let(:maintainer) { create(:user, username: "maintainer_user") }
let(:developer) { create(:user) }
let(:access_requester) { create(:user) }
let(:stranger) { create(:user) }
@@ -22,7 +22,7 @@ describe API::Members do
end
end
- shared_examples 'GET /:source_type/:id/members/(all)' do |source_type, all|
+ shared_examples "GET /:source_type/:id/members/(all)" do |source_type, all|
let(:members_url) do
"/#{source_type.pluralize}/#{source.id}/members".tap do |url|
url << "/all" if all
@@ -30,13 +30,13 @@ describe API::Members do
end
context "with :source_type == #{source_type.pluralize}" do
- it_behaves_like 'a 404 response when source is private' do
+ it_behaves_like "a 404 response when source is private" do
let(:route) { get api(members_url, stranger) }
end
%i[maintainer developer access_requester stranger].each do |type|
context "when authenticated as a #{type}" do
- it 'returns 200' do
+ it "returns 200" do
user = public_send(type)
get api(members_url, user)
@@ -45,28 +45,28 @@ describe API::Members do
expect(response).to include_pagination_headers
expect(json_response).to be_an Array
expect(json_response.size).to eq(2)
- expect(json_response.map { |u| u['id'] }).to match_array [maintainer.id, developer.id]
+ expect(json_response.map { |u| u["id"] }).to match_array [maintainer.id, developer.id]
end
end
end
- it 'avoids N+1 queries' do
+ it "avoids N+1 queries" do
# Establish baseline
get api(members_url, maintainer)
- control = ActiveRecord::QueryRecorder.new do
+ control = ActiveRecord::QueryRecorder.new {
get api(members_url, maintainer)
- end
+ }
project.add_developer(create(:user))
- expect do
+ expect {
get api(members_url, maintainer)
- end.not_to exceed_query_limit(control)
+ }.not_to exceed_query_limit(control)
end
- it 'does not return invitees' do
- create(:"#{source_type}_member", invite_token: '123', invite_email: 'test@abc.com', source: source, user: nil)
+ it "does not return invitees" do
+ create(:"#{source_type}_member", invite_token: "123", invite_email: "test@abc.com", source: source, user: nil)
get api(members_url, developer)
@@ -74,32 +74,32 @@ describe API::Members do
expect(response).to include_pagination_headers
expect(json_response).to be_an Array
expect(json_response.size).to eq(2)
- expect(json_response.map { |u| u['id'] }).to match_array [maintainer.id, developer.id]
+ expect(json_response.map { |u| u["id"] }).to match_array [maintainer.id, developer.id]
end
- it 'finds members with query string' do
- get api(members_url, developer), params: { query: maintainer.username }
+ it "finds members with query string" do
+ get api(members_url, developer), params: {query: maintainer.username}
expect(response).to have_gitlab_http_status(200)
expect(response).to include_pagination_headers
expect(json_response).to be_an Array
expect(json_response.count).to eq(1)
- expect(json_response.first['username']).to eq(maintainer.username)
+ expect(json_response.first["username"]).to eq(maintainer.username)
end
- it 'finds all members with no query specified' do
- get api(members_url, developer), params: { query: '' }
+ it "finds all members with no query specified" do
+ get api(members_url, developer), params: {query: ""}
expect(response).to have_gitlab_http_status(200)
expect(response).to include_pagination_headers
expect(json_response).to be_an Array
expect(json_response.count).to eq(2)
- expect(json_response.map { |u| u['id'] }).to match_array [maintainer.id, developer.id]
+ expect(json_response.map { |u| u["id"] }).to match_array [maintainer.id, developer.id]
end
end
end
- describe 'GET /:source_type/:id/members/all', :nested_groups do
+ describe "GET /:source_type/:id/members/all", :nested_groups do
let(:nested_user) { create(:user) }
let(:project_user) { create(:user) }
let(:linked_group_user) { create(:user) }
@@ -123,49 +123,49 @@ describe API::Members do
end
end
- it 'finds all project members including inherited members' do
+ it "finds all project members including inherited members" do
get api("/projects/#{project.id}/members/all", developer)
expect(response).to have_gitlab_http_status(200)
expect(response).to include_pagination_headers
expect(json_response).to be_an Array
- expect(json_response.map { |u| u['id'] }).to match_array [maintainer.id, developer.id, nested_user.id, project_user.id, linked_group_user.id]
+ expect(json_response.map { |u| u["id"] }).to match_array [maintainer.id, developer.id, nested_user.id, project_user.id, linked_group_user.id]
end
- it 'finds all group members including inherited members' do
+ it "finds all group members including inherited members" do
get api("/groups/#{nested_group.id}/members/all", developer)
expect(response).to have_gitlab_http_status(200)
expect(response).to include_pagination_headers
expect(json_response).to be_an Array
- expect(json_response.map { |u| u['id'] }).to match_array [maintainer.id, developer.id, nested_user.id]
+ expect(json_response.map { |u| u["id"] }).to match_array [maintainer.id, developer.id, nested_user.id]
end
end
- shared_examples 'GET /:source_type/:id/members/:user_id' do |source_type|
+ shared_examples "GET /:source_type/:id/members/:user_id" do |source_type|
context "with :source_type == #{source_type.pluralize}" do
- it_behaves_like 'a 404 response when source is private' do
+ it_behaves_like "a 404 response when source is private" do
let(:route) { get api("/#{source_type.pluralize}/#{source.id}/members/#{developer.id}", stranger) }
end
- context 'when authenticated as a non-member' do
+ context "when authenticated as a non-member" do
%i[access_requester stranger].each do |type|
context "as a #{type}" do
- it 'returns 200' do
+ it "returns 200" do
user = public_send(type)
get api("/#{source_type.pluralize}/#{source.id}/members/#{developer.id}", user)
expect(response).to have_gitlab_http_status(200)
# User attributes
- expect(json_response['id']).to eq(developer.id)
- expect(json_response['name']).to eq(developer.name)
- expect(json_response['username']).to eq(developer.username)
- expect(json_response['state']).to eq(developer.state)
- expect(json_response['avatar_url']).to eq(developer.avatar_url)
- expect(json_response['web_url']).to eq(Gitlab::Routing.url_helpers.user_url(developer))
+ expect(json_response["id"]).to eq(developer.id)
+ expect(json_response["name"]).to eq(developer.name)
+ expect(json_response["username"]).to eq(developer.username)
+ expect(json_response["state"]).to eq(developer.state)
+ expect(json_response["avatar_url"]).to eq(developer.avatar_url)
+ expect(json_response["web_url"]).to eq(Gitlab::Routing.url_helpers.user_url(developer))
# Member attributes
- expect(json_response['access_level']).to eq(Member::DEVELOPER)
+ expect(json_response["access_level"]).to eq(Member::DEVELOPER)
end
end
end
@@ -173,22 +173,22 @@ describe API::Members do
end
end
- shared_examples 'POST /:source_type/:id/members' do |source_type|
+ shared_examples "POST /:source_type/:id/members" do |source_type|
context "with :source_type == #{source_type.pluralize}" do
- it_behaves_like 'a 404 response when source is private' do
+ it_behaves_like "a 404 response when source is private" do
let(:route) do
post api("/#{source_type.pluralize}/#{source.id}/members", stranger),
- params: { user_id: access_requester.id, access_level: Member::MAINTAINER }
+ params: {user_id: access_requester.id, access_level: Member::MAINTAINER}
end
end
- context 'when authenticated as a non-member or member with insufficient rights' do
+ context "when authenticated as a non-member or member with insufficient rights" do
%i[access_requester stranger developer].each do |type|
context "as a #{type}" do
- it 'returns 403' do
+ it "returns 403" do
user = public_send(type)
post api("/#{source_type.pluralize}/#{source.id}/members", user),
- params: { user_id: access_requester.id, access_level: Member::MAINTAINER }
+ params: {user_id: access_requester.id, access_level: Member::MAINTAINER}
expect(response).to have_gitlab_http_status(403)
end
@@ -196,36 +196,36 @@ describe API::Members do
end
end
- context 'when authenticated as a maintainer/owner' do
- context 'and new member is already a requester' do
- it 'transforms the requester into a proper member' do
- expect do
+ context "when authenticated as a maintainer/owner" do
+ context "and new member is already a requester" do
+ it "transforms the requester into a proper member" do
+ expect {
post api("/#{source_type.pluralize}/#{source.id}/members", maintainer),
- params: { user_id: access_requester.id, access_level: Member::MAINTAINER }
+ params: {user_id: access_requester.id, access_level: Member::MAINTAINER}
expect(response).to have_gitlab_http_status(201)
- end.to change { source.members.count }.by(1)
+ }.to change { source.members.count }.by(1)
expect(source.requesters.count).to eq(0)
- expect(json_response['id']).to eq(access_requester.id)
- expect(json_response['access_level']).to eq(Member::MAINTAINER)
+ expect(json_response["id"]).to eq(access_requester.id)
+ expect(json_response["access_level"]).to eq(Member::MAINTAINER)
end
end
- it 'creates a new member' do
- expect do
+ it "creates a new member" do
+ expect {
post api("/#{source_type.pluralize}/#{source.id}/members", maintainer),
- params: { user_id: stranger.id, access_level: Member::DEVELOPER, expires_at: '2016-08-05' }
+ params: {user_id: stranger.id, access_level: Member::DEVELOPER, expires_at: "2016-08-05"}
expect(response).to have_gitlab_http_status(201)
- end.to change { source.members.count }.by(1)
- expect(json_response['id']).to eq(stranger.id)
- expect(json_response['access_level']).to eq(Member::DEVELOPER)
- expect(json_response['expires_at']).to eq('2016-08-05')
+ }.to change { source.members.count }.by(1)
+ expect(json_response["id"]).to eq(stranger.id)
+ expect(json_response["access_level"]).to eq(Member::DEVELOPER)
+ expect(json_response["expires_at"]).to eq("2016-08-05")
end
end
- context 'access levels' do
- it 'does not create the member if group level is higher', :nested_groups do
+ context "access levels" do
+ it "does not create the member if group level is higher", :nested_groups do
parent = create(:group)
group.update(parent: parent)
@@ -233,13 +233,13 @@ describe API::Members do
parent.add_developer(stranger)
post api("/#{source_type.pluralize}/#{source.id}/members", maintainer),
- params: { user_id: stranger.id, access_level: Member::REPORTER }
+ params: {user_id: stranger.id, access_level: Member::REPORTER}
expect(response).to have_gitlab_http_status(400)
- expect(json_response['message']['access_level']).to eq(["should be higher than Developer inherited membership from group #{parent.name}"])
+ expect(json_response["message"]["access_level"]).to eq(["should be higher than Developer inherited membership from group #{parent.name}"])
end
- it 'creates the member if group level is lower', :nested_groups do
+ it "creates the member if group level is lower", :nested_groups do
parent = create(:group)
group.update(parent: parent)
@@ -247,68 +247,68 @@ describe API::Members do
parent.add_developer(stranger)
post api("/#{source_type.pluralize}/#{source.id}/members", maintainer),
- params: { user_id: stranger.id, access_level: Member::MAINTAINER }
+ params: {user_id: stranger.id, access_level: Member::MAINTAINER}
expect(response).to have_gitlab_http_status(201)
- expect(json_response['id']).to eq(stranger.id)
- expect(json_response['access_level']).to eq(Member::MAINTAINER)
+ expect(json_response["id"]).to eq(stranger.id)
+ expect(json_response["access_level"]).to eq(Member::MAINTAINER)
end
end
it "returns 409 if member already exists" do
post api("/#{source_type.pluralize}/#{source.id}/members", maintainer),
- params: { user_id: maintainer.id, access_level: Member::MAINTAINER }
+ params: {user_id: maintainer.id, access_level: Member::MAINTAINER}
expect(response).to have_gitlab_http_status(409)
end
- it 'returns 404 when the user_id is not valid' do
+ it "returns 404 when the user_id is not valid" do
post api("/#{source_type.pluralize}/#{source.id}/members", maintainer),
- params: { user_id: 0, access_level: Member::MAINTAINER }
+ params: {user_id: 0, access_level: Member::MAINTAINER}
expect(response).to have_gitlab_http_status(404)
- expect(json_response['message']).to eq('404 User Not Found')
+ expect(json_response["message"]).to eq("404 User Not Found")
end
- it 'returns 400 when user_id is not given' do
+ it "returns 400 when user_id is not given" do
post api("/#{source_type.pluralize}/#{source.id}/members", maintainer),
- params: { access_level: Member::MAINTAINER }
+ params: {access_level: Member::MAINTAINER}
expect(response).to have_gitlab_http_status(400)
end
- it 'returns 400 when access_level is not given' do
+ it "returns 400 when access_level is not given" do
post api("/#{source_type.pluralize}/#{source.id}/members", maintainer),
- params: { user_id: stranger.id }
+ params: {user_id: stranger.id}
expect(response).to have_gitlab_http_status(400)
end
- it 'returns 400 when access_level is not valid' do
+ it "returns 400 when access_level is not valid" do
post api("/#{source_type.pluralize}/#{source.id}/members", maintainer),
- params: { user_id: stranger.id, access_level: 1234 }
+ params: {user_id: stranger.id, access_level: 1234}
expect(response).to have_gitlab_http_status(400)
end
end
end
- shared_examples 'PUT /:source_type/:id/members/:user_id' do |source_type|
+ shared_examples "PUT /:source_type/:id/members/:user_id" do |source_type|
context "with :source_type == #{source_type.pluralize}" do
- it_behaves_like 'a 404 response when source is private' do
+ it_behaves_like "a 404 response when source is private" do
let(:route) do
put api("/#{source_type.pluralize}/#{source.id}/members/#{developer.id}", stranger),
- params: { access_level: Member::MAINTAINER }
+ params: {access_level: Member::MAINTAINER}
end
end
- context 'when authenticated as a non-member or member with insufficient rights' do
+ context "when authenticated as a non-member or member with insufficient rights" do
%i[access_requester stranger developer].each do |type|
context "as a #{type}" do
- it 'returns 403' do
+ it "returns 403" do
user = public_send(type)
put api("/#{source_type.pluralize}/#{source.id}/members/#{developer.id}", user),
- params: { access_level: Member::MAINTAINER }
+ params: {access_level: Member::MAINTAINER}
expect(response).to have_gitlab_http_status(403)
end
@@ -316,50 +316,50 @@ describe API::Members do
end
end
- context 'when authenticated as a maintainer/owner' do
- it 'updates the member' do
+ context "when authenticated as a maintainer/owner" do
+ it "updates the member" do
put api("/#{source_type.pluralize}/#{source.id}/members/#{developer.id}", maintainer),
- params: { access_level: Member::MAINTAINER, expires_at: '2016-08-05' }
+ params: {access_level: Member::MAINTAINER, expires_at: "2016-08-05"}
expect(response).to have_gitlab_http_status(200)
- expect(json_response['id']).to eq(developer.id)
- expect(json_response['access_level']).to eq(Member::MAINTAINER)
- expect(json_response['expires_at']).to eq('2016-08-05')
+ expect(json_response["id"]).to eq(developer.id)
+ expect(json_response["access_level"]).to eq(Member::MAINTAINER)
+ expect(json_response["expires_at"]).to eq("2016-08-05")
end
end
- it 'returns 409 if member does not exist' do
+ it "returns 409 if member does not exist" do
put api("/#{source_type.pluralize}/#{source.id}/members/123", maintainer),
- params: { access_level: Member::MAINTAINER }
+ params: {access_level: Member::MAINTAINER}
expect(response).to have_gitlab_http_status(404)
end
- it 'returns 400 when access_level is not given' do
+ it "returns 400 when access_level is not given" do
put api("/#{source_type.pluralize}/#{source.id}/members/#{developer.id}", maintainer)
expect(response).to have_gitlab_http_status(400)
end
- it 'returns 400 when access level is not valid' do
+ it "returns 400 when access level is not valid" do
put api("/#{source_type.pluralize}/#{source.id}/members/#{developer.id}", maintainer),
- params: { access_level: 1234 }
+ params: {access_level: 1234}
expect(response).to have_gitlab_http_status(400)
end
end
end
- shared_examples 'DELETE /:source_type/:id/members/:user_id' do |source_type|
+ shared_examples "DELETE /:source_type/:id/members/:user_id" do |source_type|
context "with :source_type == #{source_type.pluralize}" do
- it_behaves_like 'a 404 response when source is private' do
+ it_behaves_like "a 404 response when source is private" do
let(:route) { delete api("/#{source_type.pluralize}/#{source.id}/members/#{developer.id}", stranger) }
end
- context 'when authenticated as a non-member or member with insufficient rights' do
+ context "when authenticated as a non-member or member with insufficient rights" do
%i[access_requester stranger].each do |type|
context "as a #{type}" do
- it 'returns 403' do
+ it "returns 403" do
user = public_send(type)
delete api("/#{source_type.pluralize}/#{source.id}/members/#{developer.id}", user)
@@ -369,41 +369,41 @@ describe API::Members do
end
end
- context 'when authenticated as a member and deleting themself' do
- it 'deletes the member' do
- expect do
+ context "when authenticated as a member and deleting themself" do
+ it "deletes the member" do
+ expect {
delete api("/#{source_type.pluralize}/#{source.id}/members/#{developer.id}", developer)
expect(response).to have_gitlab_http_status(204)
- end.to change { source.members.count }.by(-1)
+ }.to change { source.members.count }.by(-1)
end
end
- context 'when authenticated as a maintainer/owner' do
- context 'and member is a requester' do
- it 'returns 404' do
- expect do
+ context "when authenticated as a maintainer/owner" do
+ context "and member is a requester" do
+ it "returns 404" do
+ expect {
delete api("/#{source_type.pluralize}/#{source.id}/members/#{access_requester.id}", maintainer)
expect(response).to have_gitlab_http_status(404)
- end.not_to change { source.requesters.count }
+ }.not_to change { source.requesters.count }
end
end
- it 'deletes the member' do
- expect do
+ it "deletes the member" do
+ expect {
delete api("/#{source_type.pluralize}/#{source.id}/members/#{developer.id}", maintainer)
expect(response).to have_gitlab_http_status(204)
- end.to change { source.members.count }.by(-1)
+ }.to change { source.members.count }.by(-1)
end
- it_behaves_like '412 response' do
+ it_behaves_like "412 response" do
let(:request) { api("/#{source_type.pluralize}/#{source.id}/members/#{developer.id}", maintainer) }
end
end
- it 'returns 404 if member does not exist' do
+ it "returns 404 if member does not exist" do
delete api("/#{source_type.pluralize}/#{source.id}/members/123", maintainer)
expect(response).to have_gitlab_http_status(404)
@@ -412,55 +412,55 @@ describe API::Members do
end
[false, true].each do |all|
- it_behaves_like 'GET /:source_type/:id/members/(all)', 'project', all do
+ it_behaves_like "GET /:source_type/:id/members/(all)", "project", all do
let(:source) { project }
end
- it_behaves_like 'GET /:source_type/:id/members/(all)', 'group', all do
+ it_behaves_like "GET /:source_type/:id/members/(all)", "group", all do
let(:source) { group }
end
end
- it_behaves_like 'GET /:source_type/:id/members/:user_id', 'project' do
+ it_behaves_like "GET /:source_type/:id/members/:user_id", "project" do
let(:source) { project }
end
- it_behaves_like 'GET /:source_type/:id/members/:user_id', 'group' do
+ it_behaves_like "GET /:source_type/:id/members/:user_id", "group" do
let(:source) { group }
end
- it_behaves_like 'POST /:source_type/:id/members', 'project' do
+ it_behaves_like "POST /:source_type/:id/members", "project" do
let(:source) { project }
end
- it_behaves_like 'POST /:source_type/:id/members', 'group' do
+ it_behaves_like "POST /:source_type/:id/members", "group" do
let(:source) { group }
end
- it_behaves_like 'PUT /:source_type/:id/members/:user_id', 'project' do
+ it_behaves_like "PUT /:source_type/:id/members/:user_id", "project" do
let(:source) { project }
end
- it_behaves_like 'PUT /:source_type/:id/members/:user_id', 'group' do
+ it_behaves_like "PUT /:source_type/:id/members/:user_id", "group" do
let(:source) { group }
end
- it_behaves_like 'DELETE /:source_type/:id/members/:user_id', 'project' do
+ it_behaves_like "DELETE /:source_type/:id/members/:user_id", "project" do
let(:source) { project }
end
- it_behaves_like 'DELETE /:source_type/:id/members/:user_id', 'group' do
+ it_behaves_like "DELETE /:source_type/:id/members/:user_id", "group" do
let(:source) { group }
end
- context 'Adding owner to project' do
- it 'returns 403' do
- expect do
+ context "Adding owner to project" do
+ it "returns 403" do
+ expect {
post api("/projects/#{project.id}/members", maintainer),
- params: { user_id: stranger.id, access_level: Member::OWNER }
+ params: {user_id: stranger.id, access_level: Member::OWNER}
expect(response).to have_gitlab_http_status(400)
- end.to change { project.members.count }.by(0)
+ }.to change { project.members.count }.by(0)
end
end
end
View Lorry Controller Status