diff options
Diffstat (limited to 'spec/requests/api/notes_spec.rb')
-rw-r--r-- | spec/requests/api/notes_spec.rb | 46 |
1 files changed, 23 insertions, 23 deletions
diff --git a/spec/requests/api/notes_spec.rb b/spec/requests/api/notes_spec.rb index 424f0a82e43..f0e45867629 100644 --- a/spec/requests/api/notes_spec.rb +++ b/spec/requests/api/notes_spec.rb @@ -1,4 +1,4 @@ -require 'spec_helper' +require "spec_helper" describe API::Notes do let(:user) { create(:user) } @@ -13,13 +13,13 @@ describe API::Notes do let!(:issue) { create(:issue, project: project, author: user) } let!(:issue_note) { create(:note, noteable: issue, project: project, author: user) } - it_behaves_like "noteable API", 'projects', 'issues', 'iid' do + it_behaves_like "noteable API", "projects", "issues", "iid" do let(:parent) { project } let(:noteable) { issue } let(:note) { issue_note } end - context 'when user does not have access to create noteable' do + context "when user does not have access to create noteable" do let(:private_issue) { create(:issue, project: create(:project, :private)) } ## @@ -28,14 +28,14 @@ describe API::Notes do # before do post api("/projects/#{private_issue.project.id}/issues/#{private_issue.iid}/notes", user), - params: { body: 'Hi!' } + params: {body: "Hi!"} end - it 'responds with resource not found error' do + it "responds with resource not found error" do expect(response.status).to eq 404 end - it 'does not create new note' do + it "does not create new note" do expect(private_issue.notes.reload).to be_empty end end @@ -44,7 +44,7 @@ describe API::Notes do # For testing the cross-reference of a private issue in a public project let(:private_project) do create(:project, namespace: private_user.namespace) - .tap { |p| p.add_maintainer(private_user) } + .tap { |p| p.add_maintainer(private_user) } end let(:private_issue) { create(:issue, project: private_project) } @@ -53,9 +53,9 @@ describe API::Notes do let!(:cross_reference_note) do create :note, - noteable: ext_issue, project: ext_proj, - note: "mentioned in issue #{private_issue.to_reference(ext_proj)}", - system: true + noteable: ext_issue, project: ext_proj, + note: "mentioned in issue #{private_issue.to_reference(ext_proj)}", + system: true end describe "GET /projects/:id/noteable/:noteable_id/notes" do @@ -89,7 +89,7 @@ describe API::Notes do expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers expect(json_response).to be_an Array - expect(json_response.first['body']).to eq(cross_reference_note.note) + expect(json_response.first["body"]).to eq(cross_reference_note.note) end end end @@ -120,7 +120,7 @@ describe API::Notes do get api("/projects/#{ext_proj.id}/issues/#{ext_issue.iid}/notes/#{cross_reference_note.id}", private_user) expect(response).to have_gitlab_http_status(200) - expect(json_response['body']).to eq(cross_reference_note.note) + expect(json_response["body"]).to eq(cross_reference_note.note) end end end @@ -131,7 +131,7 @@ describe API::Notes do let!(:snippet) { create(:project_snippet, project: project, author: user) } let!(:snippet_note) { create(:note, noteable: snippet, project: project, author: user) } - it_behaves_like "noteable API", 'projects', 'snippets', 'id' do + it_behaves_like "noteable API", "projects", "snippets", "id" do let(:parent) { project } let(:noteable) { snippet } let(:note) { snippet_note } @@ -142,41 +142,41 @@ describe API::Notes do let!(:merge_request) { create(:merge_request, source_project: project, target_project: project, author: user) } let!(:merge_request_note) { create(:note, noteable: merge_request, project: project, author: user) } - it_behaves_like "noteable API", 'projects', 'merge_requests', 'iid' do + it_behaves_like "noteable API", "projects", "merge_requests", "iid" do let(:parent) { project } let(:noteable) { merge_request } let(:note) { merge_request_note } end - context 'when the merge request discussion is locked' do + context "when the merge request discussion is locked" do before do merge_request.update_attribute(:discussion_locked, true) end - context 'when a user is a team member' do - subject { post api("/projects/#{project.id}/merge_requests/#{merge_request.iid}/notes", user), params: { body: 'Hi!' } } + context "when a user is a team member" do + subject { post api("/projects/#{project.id}/merge_requests/#{merge_request.iid}/notes", user), params: {body: "Hi!"} } - it 'returns 200 status' do + it "returns 200 status" do subject expect(response).to have_gitlab_http_status(201) end - it 'creates a new note' do + it "creates a new note" do expect { subject }.to change { Note.count }.by(1) end end - context 'when a user is not a team member' do - subject { post api("/projects/#{project.id}/merge_requests/#{merge_request.iid}/notes", private_user), params: { body: 'Hi!' } } + context "when a user is not a team member" do + subject { post api("/projects/#{project.id}/merge_requests/#{merge_request.iid}/notes", private_user), params: {body: "Hi!"} } - it 'returns 403 status' do + it "returns 403 status" do subject expect(response).to have_gitlab_http_status(403) end - it 'does not create a new note' do + it "does not create a new note" do expect { subject }.not_to change { Note.count } end end |