summaryrefslogtreecommitdiff
path: root/spec/rubocop/cop/gemspec/avoid_executing_git_spec.rb
diff options
context:
space:
mode:
Diffstat (limited to 'spec/rubocop/cop/gemspec/avoid_executing_git_spec.rb')
-rw-r--r--spec/rubocop/cop/gemspec/avoid_executing_git_spec.rb30
1 files changed, 30 insertions, 0 deletions
diff --git a/spec/rubocop/cop/gemspec/avoid_executing_git_spec.rb b/spec/rubocop/cop/gemspec/avoid_executing_git_spec.rb
new file mode 100644
index 00000000000..f94a990a2f7
--- /dev/null
+++ b/spec/rubocop/cop/gemspec/avoid_executing_git_spec.rb
@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require 'fast_spec_helper'
+require_relative '../../../../rubocop/cop/gemspec/avoid_executing_git'
+
+RSpec.describe RuboCop::Cop::Gemspec::AvoidExecutingGit do
+ subject(:cop) { described_class.new }
+
+ it 'flags violation for executing git' do
+ expect_offense(<<~RUBY)
+ Gem::Specification.new do |gem|
+ gem.executable = `git ls-files -- bin/*`.split("\\n").map{ |f| File.basename(f) }
+ ^^^^^^^^^^^^^^^^^^^^^^^ Do not execute `git` in gemspec.
+ gem.files = `git ls-files`.split("\\n")
+ ^^^^^^^^^^^^^^ Do not execute `git` in gemspec.
+ gem.test_files = `git ls-files -- {test,spec,features}/*`.split("\\n")
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not execute `git` in gemspec.
+ end
+ RUBY
+ end
+
+ it 'does not flag violation for using a glob' do
+ expect_no_offenses(<<~RUBY)
+ Gem::Specification.new do |gem|
+ gem.files = Dir.glob("lib/**/*.*")
+ gem.test_files = Dir.glob("spec/**/**/*.*")
+ end
+ RUBY
+ end
+end