summaryrefslogtreecommitdiff
path: root/spec/rubocop/cop/migration/prevent_global_enable_lock_retries_with_disable_ddl_transaction_spec.rb
diff options
context:
space:
mode:
Diffstat (limited to 'spec/rubocop/cop/migration/prevent_global_enable_lock_retries_with_disable_ddl_transaction_spec.rb')
-rw-r--r--spec/rubocop/cop/migration/prevent_global_enable_lock_retries_with_disable_ddl_transaction_spec.rb58
1 files changed, 58 insertions, 0 deletions
diff --git a/spec/rubocop/cop/migration/prevent_global_enable_lock_retries_with_disable_ddl_transaction_spec.rb b/spec/rubocop/cop/migration/prevent_global_enable_lock_retries_with_disable_ddl_transaction_spec.rb
new file mode 100644
index 00000000000..aa63259288d
--- /dev/null
+++ b/spec/rubocop/cop/migration/prevent_global_enable_lock_retries_with_disable_ddl_transaction_spec.rb
@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+require 'fast_spec_helper'
+require_relative '../../../../rubocop/cop/migration/prevent_global_enable_lock_retries_with_disable_ddl_transaction'
+
+RSpec.describe RuboCop::Cop::Migration::PreventGlobalEnableLockRetriesWithDisableDdlTransaction do
+ subject(:cop) { described_class.new }
+
+ context 'when in migration' do
+ before do
+ allow(cop).to receive(:in_migration?).and_return(true)
+ end
+
+ it 'registers an offense when `enable_lock_retries` and `disable_ddl_transaction` is used together' do
+ code = <<~RUBY
+ class SomeMigration < ActiveRecord::Migration[6.0]
+ enable_lock_retries!
+ disable_ddl_transaction!
+ end
+ RUBY
+
+ expect_offense(<<~RUBY, node: code, msg: described_class::MSG)
+ class SomeMigration < ActiveRecord::Migration[6.0]
+ enable_lock_retries!
+ disable_ddl_transaction!
+ ^^^^^^^^^^^^^^^^^^^^^^^^ %{msg}
+ end
+ RUBY
+ end
+
+ it 'registers no offense when `enable_lock_retries!` is used' do
+ expect_no_offenses(<<~RUBY)
+ class SomeMigration < ActiveRecord::Migration[6.0]
+ enable_lock_retries!
+ end
+ RUBY
+ end
+
+ it 'registers no offense when `disable_ddl_transaction!` is used' do
+ expect_no_offenses(<<~RUBY)
+ class SomeMigration < ActiveRecord::Migration[6.0]
+ disable_ddl_transaction!
+ end
+ RUBY
+ end
+ end
+
+ context 'when outside of migration' do
+ it 'registers no offense' do
+ expect_no_offenses(<<~RUBY)
+ class SomeMigration
+ enable_lock_retries!
+ disable_ddl_transaction!
+ end
+ RUBY
+ end
+ end
+end