diff options
Diffstat (limited to 'spec/services/issues/update_service_spec.rb')
-rw-r--r-- | spec/services/issues/update_service_spec.rb | 20 |
1 files changed, 9 insertions, 11 deletions
diff --git a/spec/services/issues/update_service_spec.rb b/spec/services/issues/update_service_spec.rb index 11ed47b84d9..95394ba6597 100644 --- a/spec/services/issues/update_service_spec.rb +++ b/spec/services/issues/update_service_spec.rb @@ -385,7 +385,6 @@ RSpec.describe Issues::UpdateService, :mailer do [issue_1, issue_2, issue_3].map(&:save) opts[:move_between_ids] = [issue_1.id, issue_2.id] - opts[:board_group_id] = group.id described_class.new(project: issue_3.project, current_user: user, params: opts).execute(issue_3) expect(issue_2.relative_position).to be_between(issue_1.relative_position, issue_2.relative_position) @@ -1147,11 +1146,11 @@ RSpec.describe Issues::UpdateService, :mailer do let(:opts) { { escalation_status: { status: 'acknowledged' } } } let(:escalation_update_class) { ::IncidentManagement::IssuableEscalationStatuses::AfterUpdateService } - shared_examples 'updates the escalation status record' do |expected_status| + shared_examples 'updates the escalation status record' do |expected_status, expected_reason = nil| let(:service_double) { instance_double(escalation_update_class) } it 'has correct value' do - expect(escalation_update_class).to receive(:new).with(issue, user).and_return(service_double) + expect(escalation_update_class).to receive(:new).with(issue, user, status_change_reason: expected_reason).and_return(service_double) expect(service_double).to receive(:execute) update_issue(opts) @@ -1197,6 +1196,12 @@ RSpec.describe Issues::UpdateService, :mailer do end end + context 'with a status change reason provided' do + let(:opts) { { escalation_status: { status: 'acknowledged', status_change_reason: ' by changing the alert status' } } } + + it_behaves_like 'updates the escalation status record', :acknowledged, ' by changing the alert status' + end + context 'with unsupported status value' do let(:opts) { { escalation_status: { status: 'unsupported-status' } } } @@ -1303,19 +1308,12 @@ RSpec.describe Issues::UpdateService, :mailer do end context 'when moving an issue ' do - it 'raises an error for invalid move ids within a project' do + it 'raises an error for invalid move ids' do opts = { move_between_ids: [9000, non_existing_record_id] } expect { described_class.new(project: issue.project, current_user: user, params: opts).execute(issue) } .to raise_error(ActiveRecord::RecordNotFound) end - - it 'raises an error for invalid move ids within a group' do - opts = { move_between_ids: [9000, non_existing_record_id], board_group_id: create(:group).id } - - expect { described_class.new(project: issue.project, current_user: user, params: opts).execute(issue) } - .to raise_error(ActiveRecord::RecordNotFound) - end end include_examples 'issuable update service' do |