diff options
Diffstat (limited to 'spec/workers/container_expiration_policy_worker_spec.rb')
-rw-r--r-- | spec/workers/container_expiration_policy_worker_spec.rb | 160 |
1 files changed, 120 insertions, 40 deletions
diff --git a/spec/workers/container_expiration_policy_worker_spec.rb b/spec/workers/container_expiration_policy_worker_spec.rb index 6b185c30670..d9a4f6396f8 100644 --- a/spec/workers/container_expiration_policy_worker_spec.rb +++ b/spec/workers/container_expiration_policy_worker_spec.rb @@ -5,71 +5,151 @@ require 'spec_helper' RSpec.describe ContainerExpirationPolicyWorker do include ExclusiveLeaseHelpers - subject { described_class.new.perform } + let(:worker) { described_class.new } + let(:started_at) { nil } - RSpec.shared_examples 'not executing any policy' do - it 'does not run any policy' do - expect(ContainerExpirationPolicyService).not_to receive(:new) + describe '#perform' do + subject { worker.perform } - subject + RSpec.shared_examples 'not executing any policy' do + it 'does not run any policy' do + expect(ContainerExpirationPolicyService).not_to receive(:new) + + subject + end end - end - context 'With no container expiration policies' do - it_behaves_like 'not executing any policy' - end + context 'With no container expiration policies' do + it 'does not execute any policies' do + expect(ContainerRepository).not_to receive(:for_project_id) - context 'With container expiration policies' do - let_it_be(:container_expiration_policy, reload: true) { create(:container_expiration_policy, :runnable) } - let_it_be(:container_repository) { create(:container_repository, project: container_expiration_policy.project) } - let_it_be(:user) { container_expiration_policy.project.owner } + expect { subject }.not_to change { ContainerRepository.cleanup_scheduled.count } + end + end - context 'a valid policy' do - it 'runs the policy' do - service = instance_double(ContainerExpirationPolicyService, execute: true) + context 'with container expiration policies' do + let_it_be(:container_expiration_policy) { create(:container_expiration_policy, :runnable) } + let_it_be(:container_repository) { create(:container_repository, project: container_expiration_policy.project) } - expect(ContainerExpirationPolicyService) - .to receive(:new).with(container_expiration_policy.project, user).and_return(service) + context 'with a valid container expiration policy' do + it 'schedules the next run' do + expect { subject }.to change { container_expiration_policy.reload.next_run_at } + end - subject - end - end + it 'marks the container repository as scheduled for cleanup' do + expect { subject }.to change { container_repository.reload.cleanup_scheduled? }.from(false).to(true) + expect(ContainerRepository.cleanup_scheduled.count).to eq(1) + end - context 'a disabled policy' do - before do - container_expiration_policy.disable! + it 'calls the limited capacity worker' do + expect(ContainerExpirationPolicies::CleanupContainerRepositoryWorker).to receive(:perform_with_capacity) + + subject + end end - it_behaves_like 'not executing any policy' - end + context 'with a disabled container expiration policy' do + before do + container_expiration_policy.disable! + end - context 'a policy that is not due for a run' do - before do - container_expiration_policy.update_column(:next_run_at, 2.minutes.from_now) + it 'does not run the policy' do + expect(ContainerRepository).not_to receive(:for_project_id) + + expect { subject }.not_to change { ContainerRepository.cleanup_scheduled.count } + end end - it_behaves_like 'not executing any policy' + context 'with an invalid container expiration policy' do + let(:user) { container_expiration_policy.project.owner } + + before do + container_expiration_policy.update_column(:name_regex, '*production') + end + + it 'disables the policy and tracks an error' do + expect(ContainerRepository).not_to receive(:for_project_id) + expect(Gitlab::ErrorTracking).to receive(:log_exception).with(instance_of(described_class::InvalidPolicyError), container_expiration_policy_id: container_expiration_policy.id) + + expect { subject }.to change { container_expiration_policy.reload.enabled }.from(true).to(false) + expect(ContainerRepository.cleanup_scheduled).to be_empty + end + end end - context 'a policy linked to no container repository' do + context 'with exclusive lease taken' do before do - container_expiration_policy.container_repositories.delete_all + stub_exclusive_lease_taken(worker.lease_key, timeout: 5.hours) end - it_behaves_like 'not executing any policy' + it 'does not execute any policy' do + expect(ContainerExpirationPolicies::CleanupContainerRepositoryWorker).not_to receive(:perform_with_capacity) + expect(worker).not_to receive(:runnable_policies) + + expect { subject }.not_to change { ContainerRepository.cleanup_scheduled.count } + end end - context 'an invalid policy' do + context 'with throttling disabled' do before do - container_expiration_policy.update_column(:name_regex, '*production') + stub_feature_flags(container_registry_expiration_policies_throttling: false) end - it 'runs the policy and tracks an error' do - expect(ContainerExpirationPolicyService) - .to receive(:new).with(container_expiration_policy.project, user).and_call_original - expect(Gitlab::ErrorTracking).to receive(:log_exception).with(instance_of(ContainerExpirationPolicyService::InvalidPolicyError), container_expiration_policy_id: container_expiration_policy.id) + context 'with no container expiration policies' do + it_behaves_like 'not executing any policy' + end - expect { subject }.to change { container_expiration_policy.reload.enabled }.from(true).to(false) + context 'with container expiration policies' do + let_it_be(:container_expiration_policy, reload: true) { create(:container_expiration_policy, :runnable) } + let_it_be(:container_repository) { create(:container_repository, project: container_expiration_policy.project) } + let_it_be(:user) { container_expiration_policy.project.owner } + + context 'a valid policy' do + it 'runs the policy' do + expect(ContainerExpirationPolicyService) + .to receive(:new).with(container_expiration_policy.project, user).and_call_original + expect(CleanupContainerRepositoryWorker).to receive(:perform_async).once.and_call_original + + expect { subject }.not_to raise_error + end + end + + context 'a disabled policy' do + before do + container_expiration_policy.disable! + end + + it_behaves_like 'not executing any policy' + end + + context 'a policy that is not due for a run' do + before do + container_expiration_policy.update_column(:next_run_at, 2.minutes.from_now) + end + + it_behaves_like 'not executing any policy' + end + + context 'a policy linked to no container repository' do + before do + container_expiration_policy.container_repositories.delete_all + end + + it_behaves_like 'not executing any policy' + end + + context 'an invalid policy' do + before do + container_expiration_policy.update_column(:name_regex, '*production') + end + + it 'disables the policy and tracks an error' do + expect(ContainerExpirationPolicyService).not_to receive(:new).with(container_expiration_policy, user) + expect(Gitlab::ErrorTracking).to receive(:log_exception).with(instance_of(described_class::InvalidPolicyError), container_expiration_policy_id: container_expiration_policy.id) + + expect { subject }.to change { container_expiration_policy.reload.enabled }.from(true).to(false) + end + end end end end |