1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Dashboard::TodosController do
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project).tap { |project| project.add_developer(user) } }
let_it_be(:author) { create(:user) }
before do
sign_in(user)
end
describe 'GET #index' do
context 'project authorization' do
it 'renders 404 when user does not have read access on given project' do
unauthorized_project = create(:project, :private)
get :index, params: { project_id: unauthorized_project.id }
expect(response).to have_gitlab_http_status(:not_found)
end
it 'renders 404 when given project does not exists' do
get :index, params: { project_id: non_existing_record_id }
expect(response).to have_gitlab_http_status(:not_found)
end
it 'renders 200 when filtering for "any project" todos' do
get :index, params: { project_id: '' }
expect(response).to have_gitlab_http_status(:ok)
end
it 'renders 200 when user has access on given project' do
authorized_project = create(:project, :public)
get :index, params: { project_id: authorized_project.id }
expect(response).to have_gitlab_http_status(:ok)
end
end
context "with render_views" do
render_views
it 'avoids N+1 queries', :request_store do
merge_request = create(:merge_request, source_project: project)
create(:todo, project: project, author: author, user: user, target: merge_request)
create(:issue, project: project, assignees: [user])
group = create(:group)
group.add_owner(user)
get :index
control = ActiveRecord::QueryRecorder.new { get :index }
create(:issue, project: project, assignees: [user])
group_2 = create(:group)
group_2.add_owner(user)
project_2 = create(:project, namespace: user.namespace)
project_2.add_developer(user)
merge_request_2 = create(:merge_request, source_project: project_2)
create(:todo, project: project_2, author: author, user: user, target: merge_request_2)
expect { get :index }.not_to exceed_query_limit(control)
expect(response).to have_gitlab_http_status(:ok)
end
end
context 'group authorization' do
it 'renders 404 when user does not have read access on given group' do
unauthorized_group = create(:group, :private)
get :index, params: { group_id: unauthorized_group.id }
expect(response).to have_gitlab_http_status(:not_found)
end
end
it_behaves_like 'paginated collection' do
let_it_be(:issues) { create_list(:issue, 3, project: project, assignees: [user]) }
let(:collection) { user.todos }
before_all do
issues.each { |issue| TodoService.new.new_issue(issue, user) }
end
before do
allow(Kaminari.config).to receive(:default_per_page).and_return(2)
end
context 'when providing no filters' do
it 'does not perform a query to get the page count, but gets that from the user' do
allow(controller).to receive(:current_user).and_return(user)
expect(user).to receive(:todos_pending_count).and_call_original
get :index, params: { page: (last_page + 1).to_param, sort: :created_asc }
expect(response).to redirect_to(dashboard_todos_path(page: last_page, sort: :created_asc))
end
end
context 'when providing filters' do
it 'performs a query to get the correct page count' do
allow(controller).to receive(:current_user).and_return(user)
expect(user).not_to receive(:todos_pending_count)
get :index, params: { page: (last_page + 1).to_param, project_id: project.id }
expect(response).to redirect_to(dashboard_todos_path(page: last_page, project_id: project.id))
end
it 'returns directly addressed if filtering by mentioned action_id' do
allow(controller).to receive(:current_user).and_return(user)
mentioned_todos = [
create(:todo, :directly_addressed, project: project, user: user, target: issues.first),
create(:todo, :mentioned, project: project, user: user, target: issues.first)
]
get :index, params: { action_id: ::Todo::MENTIONED, project_id: project.id }
expect(assigns(:todos)).to match_array(mentioned_todos)
end
context 'when filtering by type Issue' do
it 'also includes work item todos' do
mentioned_issue_todos = [
create(:todo, :mentioned, project: project, user: user, target: issues.first),
create(
:todo,
:mentioned,
project: project,
user: user,
target_id: issues.last.id,
target_type: 'WorkItem'
)
]
get :index, params: { action_id: ::Todo::MENTIONED, type: 'Issue', project_id: project.id }
expect(assigns(:todos)).to match_array(mentioned_issue_todos)
end
end
end
end
context 'external authorization' do
subject { get :index }
it_behaves_like 'disabled when using an external authorization service'
end
end
describe 'PATCH #restore' do
let(:todo) { create(:todo, :done, user: user, project: project, author: author) }
it 'restores the todo to pending state' do
patch :restore, params: { id: todo.id }
expect(todo.reload).to be_pending
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq({ "count" => 1, "done_count" => 0 })
end
end
describe 'PATCH #bulk_restore' do
let(:todos) { create_list(:todo, 2, :done, user: user, project: project, author: author) }
it 'restores the todos to pending state' do
patch :bulk_restore, params: { ids: todos.map(&:id) }
todos.each do |todo|
expect(todo.reload).to be_pending
end
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq({ 'count' => 2, 'done_count' => 0 })
end
end
end
|
