1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Navigation menu item pinning', :js, feature_category: :navigation do
let_it_be(:user) { create(:user, use_new_navigation: true) }
before do
sign_in(user)
end
describe 'non-pinnable navigation menu' do
before do
visit explore_projects_path
end
it 'does not show the Pinned section' do
within '#super-sidebar' do
expect(page).not_to have_content 'Pinned'
end
end
it 'does not show the buttons to pin items' do
within '#super-sidebar' do
expect(page).not_to have_css 'button svg[data-testid="thumbtack-icon"]'
end
end
end
describe 'pinnable navigation menu' do
let_it_be(:project) { create(:project) }
before do
project.add_member(user, :owner)
visit project_path(project)
end
it 'shows the Pinned section' do
within '#super-sidebar' do
expect(page).to have_content 'Pinned'
end
end
it 'allows to pin items' do
within '#super-sidebar' do
click_on 'Manage'
add_pin('Activity')
add_pin('Members')
end
within '[data-testid="pinned-nav-items"]' do
expect(page).to have_link 'Activity'
expect(page).to have_link 'Members'
end
end
describe 'pinned items' do
before do
within '#super-sidebar' do
click_on 'Operate'
add_pin('Package Registry')
add_pin('Terraform modules')
wait_for_requests
end
end
it 'can be unpinned from within the pinned section' do
within '[data-testid="pinned-nav-items"]' do
remove_pin('Package Registry')
expect(page).not_to have_content 'Package Registry'
end
end
it 'can be unpinned from within its section' do
section = find("[data-testid=\"nav-item-link\"]", text: 'Operate')
within(section.sibling('ul')) do
remove_pin('Terraform modules')
end
within '[data-testid="pinned-nav-items"]' do
expect(page).not_to have_content 'Terraform modules'
end
end
it 'can be reordered' do
within '[data-testid="pinned-nav-items"]' do
pinned_items = page.find_all('a').map(&:text)
item1 = page.find('a', text: 'Package Registry')
item2 = page.find('a', text: 'Terraform modules')
expect(pinned_items).to eq [item1.text, item2.text]
drag_item(item2, to: item1)
pinned_items = page.find_all('a').map(&:text)
expect(pinned_items).to eq [item2.text, item1.text]
end
end
end
end
describe 'reordering pins with hidden pins from non-available features' do
let_it_be(:project_with_repo) { create(:project, :repository) }
let_it_be(:project_without_repo) { create(:project, :repository_disabled) }
before do
project_with_repo.add_member(user, :owner)
project_without_repo.add_member(user, :owner)
visit project_path(project_with_repo)
within '#super-sidebar' do
click_on 'Code'
add_pin('Commits')
click_on 'Manage'
add_pin('Activity')
add_pin('Members')
end
visit project_path(project_without_repo)
within '[data-testid="pinned-nav-items"]' do
activity_item = page.find('a', text: 'Activity')
members_item = page.find('a', text: 'Members')
drag_item(members_item, to: activity_item)
end
visit project_path(project_with_repo)
end
it 'keeps pins of non-available features' do
within '[data-testid="pinned-nav-items"]' do
pinned_items = page.find_all('a').map(&:text)
expect(pinned_items).to eq %w[Commits Members Activity]
end
end
end
private
def add_pin(menu_item_title)
menu_item = find("[data-testid=\"nav-item-link\"]", text: menu_item_title)
menu_item.hover
menu_item.find("[data-testid=\"thumbtack-icon\"]").click
wait_for_requests
end
def remove_pin(menu_item_title)
menu_item = find("[data-testid=\"nav-item-link\"]", text: menu_item_title)
menu_item.hover
menu_item.find("[data-testid=\"thumbtack-solid-icon\"]").click
wait_for_requests
end
def drag_item(item, to:)
item.hover
drag_handle = item.find('[data-testid="grip-icon"]')
drag_handle.drag_to(to)
wait_for_requests
end
end
|