1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe AbuseReportsFinder, '#execute' do
let_it_be(:user1) { create(:user) }
let_it_be(:user2) { create(:user) }
let_it_be(:reporter) { create(:user) }
let_it_be(:abuse_report_1) { create(:abuse_report, id: 20, category: 'spam', user: user1) }
let_it_be(:abuse_report_2) do
create(:abuse_report, :closed, id: 30, category: 'phishing', user: user2, reporter: reporter)
end
let(:params) { {} }
subject { described_class.new(params).execute }
context 'when params is empty' do
it 'returns all abuse reports' do
expect(subject).to match_array([abuse_report_1, abuse_report_2])
end
end
context 'when params[:user_id] is present' do
let(:params) { { user_id: user2 } }
it 'returns abuse reports for the specified user' do
expect(subject).to match_array([abuse_report_2])
end
end
shared_examples 'returns filtered reports' do |filter_field|
it "returns abuse reports filtered by #{filter_field}_id" do
expect(subject).to match_array(filtered_reports)
end
context "when no user has username = params[:#{filter_field}]" do
before do
allow(User).to receive_message_chain(:by_username, :pick)
.with(params[filter_field])
.with(:id)
.and_return(nil)
end
it 'returns all abuse reports' do
expect(subject).to match_array([abuse_report_1, abuse_report_2])
end
end
end
context 'when params[:user] is present' do
it_behaves_like 'returns filtered reports', :user do
let(:params) { { user: user1.username } }
let(:filtered_reports) { [abuse_report_1] }
end
end
context 'when params[:reporter] is present' do
it_behaves_like 'returns filtered reports', :reporter do
let(:params) { { reporter: reporter.username } }
let(:filtered_reports) { [abuse_report_2] }
end
end
context 'when params[:status] is present' do
context 'when value is "open"' do
let(:params) { { status: 'open' } }
it 'returns only open abuse reports' do
expect(subject).to match_array([abuse_report_1])
end
end
context 'when value is "closed"' do
let(:params) { { status: 'closed' } }
it 'returns only closed abuse reports' do
expect(subject).to match_array([abuse_report_2])
end
end
context 'when value is not a valid status' do
let(:params) { { status: 'partial' } }
it 'defaults to returning open abuse reports' do
expect(subject).to match_array([abuse_report_1])
end
end
context 'when abuse_reports_list feature flag is disabled' do
before do
stub_feature_flags(abuse_reports_list: false)
end
it 'does not filter by status' do
expect(subject).to match_array([abuse_report_1, abuse_report_2])
end
end
end
context 'when params[:category] is present' do
let(:params) { { category: 'phishing' } }
it 'returns abuse reports with the specified category' do
expect(subject).to match_array([abuse_report_2])
end
end
describe 'sorting' do
let(:params) { { sort: 'created_at_asc' } }
it 'returns reports sorted by the specified sort attribute' do
expect(subject).to eq [abuse_report_1, abuse_report_2]
end
context 'when sort is not specified' do
let(:params) { {} }
it "returns reports sorted by #{described_class::DEFAULT_SORT}" do
expect(subject).to eq [abuse_report_2, abuse_report_1]
end
end
context 'when sort is not supported' do
let(:params) { { sort: 'superiority' } }
it "returns reports sorted by #{described_class::DEFAULT_SORT}" do
expect(subject).to eq [abuse_report_2, abuse_report_1]
end
end
context 'when abuse_reports_list feature flag is disabled' do
let_it_be(:abuse_report_3) { create(:abuse_report, id: 10) }
before do
stub_feature_flags(abuse_reports_list: false)
end
it 'returns reports sorted by id in descending order' do
expect(subject).to eq [abuse_report_2, abuse_report_1, abuse_report_3]
end
end
end
end
|