1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe VisibilityLevelHelper, feature_category: :system_access do
include ProjectForksHelper
let(:project) { build(:project) }
let(:group) { build(:group) }
let(:personal_snippet) { build(:personal_snippet) }
let(:project_snippet) { build(:project_snippet) }
describe 'visibility_icon_description' do
context 'used with a Project' do
it 'delegates projects to #project_visibility_icon_description' do
expect(visibility_icon_description(project))
.to match /project/i
end
context 'used with a ProjectPresenter' do
it 'delegates projects to #project_visibility_icon_description' do
expect(visibility_icon_description(project.present))
.to match /project/i
end
end
context 'used with a Group' do
it 'delegates groups to #group_visibility_icon_description' do
expect(visibility_icon_description(group))
.to match /group/i
end
end
end
end
describe 'visibility_level_label' do
using RSpec::Parameterized::TableSyntax
where(:level_value, :level_name) do
Gitlab::VisibilityLevel::PRIVATE | 'Private'
Gitlab::VisibilityLevel::INTERNAL | 'Internal'
Gitlab::VisibilityLevel::PUBLIC | 'Public'
end
with_them do
it 'returns the name of the visibility level' do
expect(visibility_level_label(level_value)).to eq(level_name)
end
end
end
describe 'visibility_level_description' do
context 'used with a Project' do
let(:descriptions) do
[
visibility_level_description(Gitlab::VisibilityLevel::PRIVATE, project),
visibility_level_description(Gitlab::VisibilityLevel::INTERNAL, project),
visibility_level_description(Gitlab::VisibilityLevel::PUBLIC, project)
]
end
it 'returns different project related descriptions depending on visibility level' do
expect(descriptions.uniq.size).to eq(descriptions.size)
expect(descriptions).to all match /project/i
end
end
context 'used with a Group' do
let(:descriptions) do
[
visibility_level_description(Gitlab::VisibilityLevel::PRIVATE, group),
visibility_level_description(Gitlab::VisibilityLevel::INTERNAL, group),
visibility_level_description(Gitlab::VisibilityLevel::PUBLIC, group)
]
end
it 'returns different group related descriptions depending on visibility level' do
expect(descriptions.uniq.size).to eq(descriptions.size)
expect(descriptions).to all match /group/i
end
it 'returns default description for public group' do
expect(descriptions[2]).to eq('The group and any public projects can be viewed without any authentication.')
end
context 'when application setting `should_check_namespace_plan` is true', if: Gitlab.ee? do
let(:group) { create(:group) }
let(:public_option_description) { visibility_level_description(Gitlab::VisibilityLevel::PUBLIC, group) }
before do
allow(Gitlab::CurrentSettings.current_application_settings).to receive(:should_check_namespace_plan?) { true }
end
it 'returns updated description for public visibility option in group general settings' do
expect(public_option_description).to match /^The group, any public projects, and any of their members, issues, and merge requests can be viewed without authentication./
end
end
end
end
describe "disallowed_visibility_level?" do
describe "forks" do
let(:project) { create(:project, :internal) }
let(:forked_project) { fork_project(project) }
it "disallows levels" do
expect(disallowed_visibility_level?(forked_project, Gitlab::VisibilityLevel::PUBLIC)).to be_truthy
expect(disallowed_visibility_level?(forked_project, Gitlab::VisibilityLevel::INTERNAL)).to be_falsey
expect(disallowed_visibility_level?(forked_project, Gitlab::VisibilityLevel::PRIVATE)).to be_falsey
end
end
describe "non-forked project" do
let(:project) { create(:project, :internal) }
it "disallows levels" do
expect(disallowed_visibility_level?(project, Gitlab::VisibilityLevel::PUBLIC)).to be_falsey
expect(disallowed_visibility_level?(project, Gitlab::VisibilityLevel::INTERNAL)).to be_falsey
expect(disallowed_visibility_level?(project, Gitlab::VisibilityLevel::PRIVATE)).to be_falsey
end
end
describe "group" do
let(:group) { create(:group, :internal) }
it "disallows levels" do
expect(disallowed_visibility_level?(group, Gitlab::VisibilityLevel::PUBLIC)).to be_falsey
expect(disallowed_visibility_level?(group, Gitlab::VisibilityLevel::INTERNAL)).to be_falsey
expect(disallowed_visibility_level?(group, Gitlab::VisibilityLevel::PRIVATE)).to be_falsey
end
end
describe "sub-group" do
let(:group) { create(:group, :private) }
let(:subgroup) { create(:group, :private, parent: group) }
it "disallows levels" do
expect(disallowed_visibility_level?(subgroup, Gitlab::VisibilityLevel::PUBLIC)).to be_truthy
expect(disallowed_visibility_level?(subgroup, Gitlab::VisibilityLevel::INTERNAL)).to be_truthy
expect(disallowed_visibility_level?(subgroup, Gitlab::VisibilityLevel::PRIVATE)).to be_falsey
end
end
describe "snippet" do
let(:snippet) { create(:snippet, :internal) }
it "disallows levels" do
expect(disallowed_visibility_level?(snippet, Gitlab::VisibilityLevel::PUBLIC)).to be_falsey
expect(disallowed_visibility_level?(snippet, Gitlab::VisibilityLevel::INTERNAL)).to be_falsey
expect(disallowed_visibility_level?(snippet, Gitlab::VisibilityLevel::PRIVATE)).to be_falsey
end
end
end
describe "selected_visibility_level" do
let(:group) { create(:group, :public) }
let!(:project) { create(:project, :internal, group: group) }
let!(:forked_project) { fork_project(project) }
using RSpec::Parameterized::TableSyntax
public_vis = Gitlab::VisibilityLevel::PUBLIC
internal_vis = Gitlab::VisibilityLevel::INTERNAL
private_vis = Gitlab::VisibilityLevel::PRIVATE
# This is a subset of all the permutations
where(:requested_level, :max_allowed, :global_default_level, :restricted_levels, :expected) do
public_vis | public_vis | public_vis | [] | public_vis
public_vis | public_vis | public_vis | [public_vis] | internal_vis
internal_vis | public_vis | public_vis | [] | internal_vis
internal_vis | private_vis | private_vis | [] | private_vis
private_vis | public_vis | public_vis | [] | private_vis
public_vis | private_vis | internal_vis | [] | private_vis
public_vis | internal_vis | public_vis | [] | internal_vis
public_vis | private_vis | public_vis | [] | private_vis
public_vis | internal_vis | internal_vis | [] | internal_vis
public_vis | public_vis | internal_vis | [] | public_vis
end
before do
stub_application_setting(
restricted_visibility_levels: restricted_levels,
default_project_visibility: global_default_level
)
end
with_them do
it "provides correct visibility level for forked project" do
project.update!(visibility_level: max_allowed)
expect(selected_visibility_level(forked_project, requested_level)).to eq(expected)
end
it "provides correct visibility level for project in group" do
project.update!(visibility_level: max_allowed)
project.group.update!(visibility_level: max_allowed)
expect(selected_visibility_level(project, requested_level)).to eq(expected)
end
end
end
shared_examples_for 'available visibility level' do
using RSpec::Parameterized::TableSyntax
let(:user) { create(:user) }
subject { helper.available_visibility_levels(form_model) }
public_vis = Gitlab::VisibilityLevel::PUBLIC
internal_vis = Gitlab::VisibilityLevel::INTERNAL
private_vis = Gitlab::VisibilityLevel::PRIVATE
where(:restricted_visibility_levels, :expected) do
[] | [private_vis, internal_vis, public_vis]
[private_vis] | [internal_vis, public_vis]
[private_vis, internal_vis] | [public_vis]
[private_vis, public_vis] | [internal_vis]
[internal_vis] | [private_vis, public_vis]
[internal_vis, private_vis] | [public_vis]
[internal_vis, public_vis] | [private_vis]
[public_vis] | [private_vis, internal_vis]
[public_vis, private_vis] | [internal_vis]
[public_vis, internal_vis] | [private_vis]
end
before do
allow(helper).to receive(:current_user) { user }
end
with_them do
before do
stub_application_setting(restricted_visibility_levels: restricted_visibility_levels)
end
it { is_expected.to eq(expected) }
end
it 'excludes disallowed visibility levels' do
stub_application_setting(restricted_visibility_levels: [])
allow(helper).to receive(:disallowed_visibility_level?).with(form_model, private_vis) { true }
allow(helper).to receive(:disallowed_visibility_level?).with(form_model, internal_vis) { false }
allow(helper).to receive(:disallowed_visibility_level?).with(form_model, public_vis) { false }
expect(subject).to eq([internal_vis, public_vis])
end
end
describe '#available_visibility_levels' do
it_behaves_like 'available visibility level' do
let(:form_model) { project_snippet }
end
it_behaves_like 'available visibility level' do
let(:form_model) { personal_snippet }
end
it_behaves_like 'available visibility level' do
let(:form_model) { project }
end
it_behaves_like 'available visibility level' do
let(:form_model) { group }
end
end
describe '#snippets_selected_visibility_level' do
let(:available_levels) { [Gitlab::VisibilityLevel::PUBLIC, Gitlab::VisibilityLevel::INTERNAL] }
it 'returns the selected visibility level' do
expect(helper.snippets_selected_visibility_level(available_levels, Gitlab::VisibilityLevel::PUBLIC))
.to eq(Gitlab::VisibilityLevel::PUBLIC)
end
it "fallbacks using the lowest available visibility level when selected level isn't available" do
expect(helper.snippets_selected_visibility_level(available_levels, Gitlab::VisibilityLevel::PRIVATE))
.to eq(Gitlab::VisibilityLevel::INTERNAL)
end
end
describe 'multiple_visibility_levels_restricted?' do
using RSpec::Parameterized::TableSyntax
let(:user) { create(:user) }
subject { helper.multiple_visibility_levels_restricted? }
where(:restricted_visibility_levels, :expected) do
[Gitlab::VisibilityLevel::PUBLIC] | false
[Gitlab::VisibilityLevel::PUBLIC, Gitlab::VisibilityLevel::INTERNAL] | true
[Gitlab::VisibilityLevel::PUBLIC, Gitlab::VisibilityLevel::INTERNAL, Gitlab::VisibilityLevel::PRIVATE] | true
end
with_them do
before do
allow(helper).to receive(:current_user) { user }
allow(Gitlab::CurrentSettings.current_application_settings).to receive(:restricted_visibility_levels) { restricted_visibility_levels }
end
it { is_expected.to eq(expected) }
end
end
describe 'all_visibility_levels_restricted?' do
using RSpec::Parameterized::TableSyntax
let(:user) { create(:user) }
subject { helper.all_visibility_levels_restricted? }
where(:restricted_visibility_levels, :expected) do
[Gitlab::VisibilityLevel::PUBLIC] | false
[Gitlab::VisibilityLevel::PUBLIC, Gitlab::VisibilityLevel::INTERNAL] | false
Gitlab::VisibilityLevel.values | true
end
with_them do
before do
allow(helper).to receive(:current_user) { user }
allow(Gitlab::CurrentSettings.current_application_settings).to receive(:restricted_visibility_levels) { restricted_visibility_levels }
end
it { is_expected.to eq(expected) }
end
end
describe '#visibility_level_options' do
let(:user) { build(:user) }
before do
allow(helper).to receive(:current_user).and_return(user)
end
it 'returns the desired mapping' do
expected_options = [
{
level: 0,
label: 'Private',
description: 'The group and its projects can only be viewed by members.'
},
{
level: 10,
label: 'Internal',
description: 'The group and any internal projects can be viewed by any logged in user except external users.'
},
{
level: 20,
label: 'Public',
description: 'The group and any public projects can be viewed without any authentication.'
}
]
expect(helper.visibility_level_options(group)).to eq expected_options
end
end
end
|