1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::GithubImport::Importer::PullRequestMergedByImporter, :clean_gitlab_redis_cache do
let_it_be(:merge_request) { create(:merged_merge_request) }
let(:project) { merge_request.project }
let(:merged_at) { Time.new(2017, 1, 1, 12, 00).utc }
let(:client_double) { double(user: { id: 999, login: 'merger', email: 'merger@email.com' } ) }
let(:merger_user) { { id: 999, login: 'merger' } }
let(:pull_request) do
Gitlab::GithubImport::Representation::PullRequest.from_api_response(
{
number: merge_request.iid,
merged_at: merged_at,
merged_by: merger_user
}
)
end
subject { described_class.new(pull_request, project, client_double) }
shared_examples 'adds a note referencing the merger user' do
it 'adds a note referencing the merger user' do
expect { subject.execute }
.to change(Note, :count).by(1)
.and not_change(merge_request, :updated_at)
metrics = merge_request.metrics.reload
expect(metrics.merged_by).to be_nil
expect(metrics.merged_at).to eq(merged_at)
last_note = merge_request.notes.last
expect(last_note.created_at).to eq(merged_at)
expect(last_note.author).to eq(project.creator)
expect(last_note.note).to eq("*Merged by: merger at #{merged_at}*")
end
end
context 'when the merger user can be mapped' do
it 'assigns the merged by user when mapped' do
merge_user = create(:user, email: 'merger@email.com')
subject.execute
metrics = merge_request.metrics.reload
expect(metrics.merged_by).to eq(merge_user)
expect(metrics.merged_at).to eq(merged_at)
end
end
context 'when the merger user cannot be mapped to a gitlab user' do
it_behaves_like 'adds a note referencing the merger user'
context 'when original user cannot be found on github' do
before do
allow(client_double).to receive(:user).and_raise(Octokit::NotFound)
end
it_behaves_like 'adds a note referencing the merger user'
end
end
context 'when the merger user is not provided' do
let(:merger_user) { nil }
it 'adds a note referencing the merger user' do
expect { subject.execute }
.to change(Note, :count).by(1)
.and not_change(merge_request, :updated_at)
metrics = merge_request.metrics.reload
expect(metrics.merged_by).to be_nil
expect(metrics.merged_at).to eq(merged_at)
last_note = merge_request.notes.last
expect(last_note.created_at).to eq(merged_at)
expect(last_note.author).to eq(project.creator)
expect(last_note.note).to eq("*Merged by: ghost at #{merged_at}*")
end
end
end
|
