1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'ProjectCiCdSettingsUpdate', feature_category: :continuous_integration do
include GraphqlHelpers
before do
stub_feature_flags(frozen_outbound_job_token_scopes_override: false)
end
let_it_be(:project) do
create(:project,
keep_latest_artifact: true,
ci_outbound_job_token_scope_enabled: true,
ci_inbound_job_token_scope_enabled: true
).tap(&:save!)
end
let(:variables) do
{
full_path: project.full_path,
keep_latest_artifact: false,
job_token_scope_enabled: false,
inbound_job_token_scope_enabled: false,
opt_in_jwt: true
}
end
let(:mutation) { graphql_mutation(:project_ci_cd_settings_update, variables) }
context 'when unauthorized' do
let(:user) { create(:user) }
shared_examples 'unauthorized' do
it 'returns an error' do
post_graphql_mutation(mutation, current_user: user)
expect(graphql_errors).not_to be_empty
end
end
context 'when not a project member' do
it_behaves_like 'unauthorized'
end
context 'when a non-admin project member' do
before do
project.add_developer(user)
end
it_behaves_like 'unauthorized'
end
end
context 'when authorized' do
let_it_be(:user) { project.first_owner }
it 'updates ci cd settings' do
post_graphql_mutation(mutation, current_user: user)
project.reload
expect(response).to have_gitlab_http_status(:success)
expect(project.keep_latest_artifact).to eq(false)
end
describe 'ci_cd_settings_update deprecated mutation' do
let(:mutation) { graphql_mutation(:ci_cd_settings_update, variables) }
it 'returns error' do
post_graphql_mutation(mutation, current_user: user)
expect(graphql_errors).to(
include(
hash_including('message' => '`remove_cicd_settings_update` feature flag is enabled.')
)
)
end
context 'when remove_cicd_settings_update FF is disabled' do
before do
stub_feature_flags(remove_cicd_settings_update: false)
end
it 'updates ci cd settings' do
post_graphql_mutation(mutation, current_user: user)
project.reload
expect(response).to have_gitlab_http_status(:success)
expect(project.keep_latest_artifact).to eq(false)
end
end
end
it 'allows setting job_token_scope_enabled to false' do
post_graphql_mutation(mutation, current_user: user)
project.reload
expect(response).to have_gitlab_http_status(:success)
expect(project.ci_outbound_job_token_scope_enabled).to eq(false)
end
context 'when job_token_scope_enabled: true' do
let(:variables) do
{
full_path: project.full_path,
keep_latest_artifact: false,
job_token_scope_enabled: true,
inbound_job_token_scope_enabled: false,
opt_in_jwt: true
}
end
it 'prevents the update', :aggregate_failures do
project.update!(ci_outbound_job_token_scope_enabled: false)
post_graphql_mutation(mutation, current_user: user)
project.reload
expect(response).to have_gitlab_http_status(:success)
expect(graphql_errors).to(
include(
hash_including(
'message' => 'job_token_scope_enabled can only be set to false'
)
)
)
expect(project.ci_outbound_job_token_scope_enabled).to eq(false)
end
end
context 'when FF frozen_outbound_job_token_scopes is disabled' do
before do
stub_feature_flags(frozen_outbound_job_token_scopes: false)
end
it 'allows setting job_token_scope_enabled to true' do
project.update!(ci_outbound_job_token_scope_enabled: true)
post_graphql_mutation(mutation, current_user: user)
project.reload
expect(response).to have_gitlab_http_status(:success)
expect(project.ci_outbound_job_token_scope_enabled).to eq(false)
end
end
it 'does not update job_token_scope_enabled if not specified' do
variables.except!(:job_token_scope_enabled)
post_graphql_mutation(mutation, current_user: user)
project.reload
expect(response).to have_gitlab_http_status(:success)
expect(project.ci_outbound_job_token_scope_enabled).to eq(true)
end
describe 'inbound_job_token_scope_enabled' do
it 'updates inbound_job_token_scope_enabled' do
post_graphql_mutation(mutation, current_user: user)
project.reload
expect(response).to have_gitlab_http_status(:success)
expect(project.ci_inbound_job_token_scope_enabled).to eq(false)
end
it 'does not update inbound_job_token_scope_enabled if not specified' do
variables.except!(:inbound_job_token_scope_enabled)
post_graphql_mutation(mutation, current_user: user)
project.reload
expect(response).to have_gitlab_http_status(:success)
expect(project.ci_inbound_job_token_scope_enabled).to eq(true)
end
end
it 'updates ci_opt_in_jwt' do
post_graphql_mutation(mutation, current_user: user)
project.reload
expect(response).to have_gitlab_http_status(:success)
expect(project.ci_opt_in_jwt).to eq(true)
end
context 'when bad arguments are provided' do
let(:variables) { { full_path: '', keep_latest_artifact: false } }
it 'returns the errors' do
post_graphql_mutation(mutation, current_user: user)
expect(graphql_errors).not_to be_empty
end
end
end
end
|
