1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Project.cluster_agents', feature_category: :deployment_management do
include GraphqlHelpers
let_it_be(:project) { create(:project, :public) }
let_it_be(:current_user) { create(:user, maintainer_projects: [project]) }
let_it_be(:agents) { create_list(:cluster_agent, 3, project: project) }
let(:first) { var('Int') }
let(:cluster_agents_fields) { nil }
let(:project_fields) do
query_nodes(:cluster_agents, cluster_agents_fields, args: { first: first }, max_depth: 3)
end
let(:query) do
args = { full_path: project.full_path }
with_signature([first], graphql_query_for(:project, args, project_fields))
end
before do
allow(Gitlab::Kas::Client).to receive(:new).and_return(double(get_connected_agents: []))
end
it 'can retrieve cluster agents' do
post_graphql(query, current_user: current_user)
expect(graphql_data_at(:project, :cluster_agents, :nodes)).to match_array(
agents.map { |agent| a_graphql_entity_for(agent) }
)
end
context 'selecting page info' do
let(:project_fields) do
query_nodes(:cluster_agents, args: { first: first }, include_pagination_info: true)
end
it 'can paginate cluster agents' do
post_graphql(query, current_user: current_user, variables: first.with(2))
expect(graphql_data_at(:project, :cluster_agents, :page_info)).to include(
'hasNextPage' => be_truthy,
'hasPreviousPage' => be_falsey
)
expect(graphql_data_at(:project, :cluster_agents, :nodes)).to have_attributes(size: 2)
end
end
context 'selecting tokens' do
let_it_be(:token_1) { create(:cluster_agent_token, agent: agents.second) }
let_it_be(:token_2) { create(:cluster_agent_token, agent: agents.second, last_used_at: 3.days.ago) }
let_it_be(:token_3) { create(:cluster_agent_token, agent: agents.second, last_used_at: 2.days.ago) }
let(:cluster_agents_fields) { [:id, query_nodes(:tokens, of: 'ClusterAgentToken')] }
it 'can select tokens in last_used_at order' do
post_graphql(query, current_user: current_user)
tokens = graphql_data_at(:project, :cluster_agents, :nodes, :tokens, :nodes)
expect(tokens).to match(
[
a_graphql_entity_for(token_3),
a_graphql_entity_for(token_2),
a_graphql_entity_for(token_1)
])
end
it 'does not suffer from N+1 performance issues' do
post_graphql(query, current_user: current_user)
expect do
post_graphql(query, current_user: current_user)
end.to issue_same_number_of_queries_as { post_graphql(query, current_user: current_user, variables: [first.with(1)]) }
end
end
context 'selecting connections' do
let(:agent_meta) { double(version: '1', commit_id: 'abc', pod_namespace: 'namespace', pod_name: 'pod') }
let(:connected_agent) { double(agent_id: agents.first.id, connected_at: 123456, connection_id: 1, agent_meta: agent_meta) }
let(:metadata_fields) { query_graphql_field(:metadata, {}, [:version, :commit, :pod_namespace, :pod_name], 'AgentMetadata') }
let(:cluster_agents_fields) { [:id, query_nodes(:connections, [:connection_id, :connected_at, metadata_fields])] }
before do
allow(Gitlab::Kas::Client).to receive(:new).and_return(double(get_connected_agents: [connected_agent]))
end
it 'can retrieve connections and agent metadata' do
post_graphql(query, current_user: current_user)
connection = graphql_data_at(:project, :cluster_agents, :nodes, :connections, :nodes).first
expect(connection).to include({
'connectionId' => connected_agent.connection_id.to_s,
'connectedAt' => Time.at(connected_agent.connected_at),
'metadata' => {
'version' => agent_meta.version,
'commit' => agent_meta.commit_id,
'podNamespace' => agent_meta.pod_namespace,
'podName' => agent_meta.pod_name
}
})
end
end
context 'selecting activity events' do
let_it_be(:token) { create(:cluster_agent_token, agent: agents.first) }
let_it_be(:event) { create(:agent_activity_event, agent: agents.first, agent_token: token, user: current_user) }
let(:cluster_agents_fields) { [:id, query_nodes(:activity_events, of: 'ClusterAgentActivityEvent', max_depth: 2)] }
it 'retrieves activity event details' do
post_graphql(query, current_user: current_user)
response = graphql_data_at(:project, :cluster_agents, :nodes, :activity_events, :nodes).first
expect(response).to include({
'kind' => event.kind,
'level' => event.level,
'recordedAt' => event.recorded_at.iso8601,
'agentToken' => hash_including('name' => token.name),
'user' => hash_including('name' => current_user.name)
})
end
it 'preloads associations to prevent N+1 queries', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/350868' do
user = create(:user)
token = create(:cluster_agent_token, agent: agents.second)
create(:agent_activity_event, agent: agents.second, agent_token: token, user: user)
post_graphql(query, current_user: current_user)
expect do
post_graphql(query, current_user: current_user)
end.to issue_same_number_of_queries_as { post_graphql(query, current_user: current_user, variables: [first.with(1)]) }
end
end
end
|
