1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
|
# == Schema Information
#
# Table name: commits
#
# id :integer not null, primary key
# project_id :integer
# ref :string(255)
# sha :string(255)
# before_sha :string(255)
# push_data :text
# created_at :datetime
# updated_at :datetime
# tag :boolean default(FALSE)
# yaml_errors :text
# committed_at :datetime
#
require 'spec_helper'
describe Commit do
let(:project) { FactoryGirl.create :project }
let(:commit) { FactoryGirl.create :commit, project: project }
let(:commit_with_project) { FactoryGirl.create :commit, project: project }
let(:config_processor) { GitlabCiYamlProcessor.new(gitlab_ci_yaml) }
it { should belong_to(:project) }
it { should have_many(:builds) }
it { should validate_presence_of :before_sha }
it { should validate_presence_of :sha }
it { should validate_presence_of :ref }
it { should validate_presence_of :push_data }
it { should respond_to :git_author_name }
it { should respond_to :git_author_email }
it { should respond_to :short_sha }
describe '#last_build' do
subject { commit.last_build }
before do
@first = FactoryGirl.create :build, commit: commit, created_at: Date.yesterday
@second = FactoryGirl.create :build, commit: commit
end
it { should be_a(Build) }
it('returns with the most recently created build') { should eq(@second) }
end
describe '#retry' do
before do
@first = FactoryGirl.create :build, commit: commit, created_at: Date.yesterday
@second = FactoryGirl.create :build, commit: commit
end
it "creates new build" do
expect(commit.builds.count(:all)).to eq 2
commit.retry
expect(commit.builds.count(:all)).to eq 3
end
end
describe '#project_recipients' do
context 'always sending notification' do
it 'should return commit_pusher_email as only recipient when no additional recipients are given' do
project = FactoryGirl.create :project,
email_add_pusher: true,
email_recipients: ''
commit = FactoryGirl.create :commit, project: project
expected = 'commit_pusher_email'
commit.stub(:push_data) { { user_email: expected } }
commit.project_recipients.should == [expected]
end
it 'should return commit_pusher_email and additional recipients' do
project = FactoryGirl.create :project,
email_add_pusher: true,
email_recipients: 'rec1 rec2'
commit = FactoryGirl.create :commit, project: project
expected = 'commit_pusher_email'
commit.stub(:push_data) { { user_email: expected } }
commit.project_recipients.should == ['rec1', 'rec2', expected]
end
it 'should return recipients' do
project = FactoryGirl.create :project,
email_add_pusher: false,
email_recipients: 'rec1 rec2'
commit = FactoryGirl.create :commit, project: project
commit.project_recipients.should == ['rec1', 'rec2']
end
it 'should return unique recipients only' do
project = FactoryGirl.create :project,
email_add_pusher: true,
email_recipients: 'rec1 rec1 rec2'
commit = FactoryGirl.create :commit, project: project
expected = 'rec2'
commit.stub(:push_data) { { user_email: expected } }
commit.project_recipients.should == ['rec1', 'rec2']
end
end
end
describe '#valid_commit_sha' do
context 'commit.sha can not start with 00000000' do
before do
commit.sha = '0' * 40
commit.valid_commit_sha
end
it('commit errors should not be empty') { commit.errors.should_not be_empty }
end
end
describe '#compare?' do
subject { commit_with_project.compare? }
context 'if commit.before_sha are not nil' do
it { should be_truthy }
end
end
describe '#short_before_sha' do
subject { commit.short_before_sha }
it { should have(8).items }
it { commit.before_sha.should start_with(subject) }
end
describe '#short_sha' do
subject { commit.short_sha }
it { should have(8).items }
it { commit.sha.should start_with(subject) }
end
describe '#create_next_builds' do
before do
commit.stub(:config_processor).and_return(config_processor)
end
it "creates builds for next type" do
commit.create_builds.should be_truthy
commit.builds.reload
commit.builds.size.should == 2
commit.create_next_builds(nil).should be_truthy
commit.builds.reload
commit.builds.size.should == 4
commit.create_next_builds(nil).should be_truthy
commit.builds.reload
commit.builds.size.should == 5
commit.create_next_builds(nil).should be_falsey
end
end
describe '#create_builds' do
before do
commit.stub(:config_processor).and_return(config_processor)
end
it 'creates builds' do
commit.create_builds.should be_truthy
commit.builds.reload
commit.builds.size.should == 2
end
context 'for build triggers' do
let(:trigger) { FactoryGirl.create :trigger, project: project }
let(:trigger_request) { FactoryGirl.create :trigger_request, commit: commit, trigger: trigger }
it 'creates builds' do
commit.create_builds(trigger_request).should be_truthy
commit.builds.reload
commit.builds.size.should == 2
end
it 'rebuilds commit' do
commit.create_builds.should be_truthy
commit.builds.reload
commit.builds.size.should == 2
commit.create_builds(trigger_request).should be_truthy
commit.builds.reload
commit.builds.size.should == 4
end
it 'creates next builds' do
commit.create_builds(trigger_request).should be_truthy
commit.builds.reload
commit.builds.size.should == 2
commit.create_next_builds(trigger_request).should be_truthy
commit.builds.reload
commit.builds.size.should == 4
end
context 'for [ci skip]' do
before do
commit.push_data[:commits][0][:message] = 'skip this commit [ci skip]'
commit.save
end
it 'rebuilds commit' do
commit.status.should == 'skipped'
commit.create_builds(trigger_request).should be_truthy
commit.builds.reload
commit.builds.size.should == 2
commit.status.should == 'pending'
end
end
end
end
describe "#finished_at" do
let(:project) { FactoryGirl.create :project }
let(:commit) { FactoryGirl.create :commit, project: project }
it "returns finished_at of latest build" do
build = FactoryGirl.create :build, commit: commit, finished_at: Time.now - 60
build1 = FactoryGirl.create :build, commit: commit, finished_at: Time.now - 120
commit.finished_at.to_i.should == build.finished_at.to_i
end
it "returns nil if there is no finished build" do
build = FactoryGirl.create :not_started_build, commit: commit
commit.finished_at.should be_nil
end
end
describe "coverage" do
let(:project) { FactoryGirl.create :project, coverage_regex: "/.*/" }
let(:commit) { FactoryGirl.create :commit, project: project }
it "calculates average when there are two builds with coverage" do
FactoryGirl.create :build, name: "rspec", coverage: 30, commit: commit
FactoryGirl.create :build, name: "rubocop", coverage: 40, commit: commit
commit.coverage.should == "35.00"
end
it "calculates average when there are two builds with coverage and one with nil" do
FactoryGirl.create :build, name: "rspec", coverage: 30, commit: commit
FactoryGirl.create :build, name: "rubocop", coverage: 40, commit: commit
FactoryGirl.create :build, commit: commit
commit.coverage.should == "35.00"
end
it "calculates average when there are two builds with coverage and one is retried" do
FactoryGirl.create :build, name: "rspec", coverage: 30, commit: commit
FactoryGirl.create :build, name: "rubocop", coverage: 30, commit: commit
FactoryGirl.create :build, name: "rubocop", coverage: 40, commit: commit
commit.coverage.should == "35.00"
end
it "calculates average when there is one build without coverage" do
FactoryGirl.create :build, commit: commit
commit.coverage.should be_nil
end
end
end
|
