Improve logging for non-git commands499-log-non-git-commands

Several of our commands only touch the internal API, and go nowhere
near Gitaly. Improve logging for each of these in a single MR. In
general, we want to be able to tell what happened in the execution of
each command, and to track failures down to a specific line of code.

Changelog: added

1 files changed, 10 insertions, 1 deletions

diff --git a/internal/command/twofactorverify/twofactorverify.go b/internal/command/twofactorverify/twofactorverify.go
index b1c5508..fe17339 100644
--- a/internal/command/twofactorverify/twofactorverify.go
+++ b/internal/command/twofactorverify/twofactorverify.go
@@ -5,6 +5,8 @@ import (
 	"fmt"
 	"io"
 
+	"gitlab.com/gitlab-org/labkit/log"
+
 	"gitlab.com/gitlab-org/gitlab-shell/internal/command/commandargs"
 	"gitlab.com/gitlab-org/gitlab-shell/internal/command/readwriter"
 	"gitlab.com/gitlab-org/gitlab-shell/internal/config"
@@ -18,11 +20,18 @@ type Command struct {
 }
 
 func (c *Command) Execute(ctx context.Context) error {
-	err := c.verifyOTP(ctx, c.getOTP())
+	ctxlog := log.ContextLogger(ctx)
+	ctxlog.Info("twofactorverify: execute: waiting for user input")
+	otp := c.getOTP()
+
+	ctxlog.Info("twofactorverify: execute: verifying entered OTP")
+	err := c.verifyOTP(ctx, otp)
 	if err != nil {
+		ctxlog.WithError(err).Error("twofactorverify: execute: OTP verification failed")
 		return err
 	}
 
+	ctxlog.WithError(err).Info("twofactorverify: execute: OTP verified")
 	return nil
 }