diff options
Diffstat (limited to 'client/client_test.go')
-rw-r--r-- | client/client_test.go | 51 |
1 files changed, 48 insertions, 3 deletions
diff --git a/client/client_test.go b/client/client_test.go index aefff33..776a0aa 100644 --- a/client/client_test.go +++ b/client/client_test.go @@ -6,6 +6,8 @@ import ( "fmt" "io" "net/http" + "net/http/httptest" + "os" "path" "strings" "testing" @@ -18,9 +20,7 @@ import ( "gitlab.com/gitlab-org/gitlab-shell/v14/internal/testhelper" ) -var ( - secret = "sssh, it's a secret" -) +var secret = "sssh, it's a secret" func TestClients(t *testing.T) { testhelper.PrepareTestRootDir(t) @@ -70,6 +70,11 @@ func TestClients(t *testing.T) { }, secret: "\n" + secret + "\n", }, + { + desc: "Retry client", + server: testserver.StartRetryHttpServer, + secret: secret, + }, } for _, tc := range testCases { @@ -297,3 +302,43 @@ func buildRequests(t *testing.T, relativeURLRoot string) []testserver.TestReques return requests } + +func TestRetryableHTTPFeatureToggle(t *testing.T) { + t.Run("retryable http off", func(t *testing.T) { + os.Setenv("FF_GITLAB_SHELL_RETRYABLE_HTTP", "0") + reqAttempts := 0 + srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + reqAttempts++ + w.WriteHeader(500) + })) + defer srv.Close() + + httpClient, err := NewHTTPClientWithOpts(srv.URL, "/", "", "", 1, nil) + require.NoError(t, err) + client, err := NewGitlabNetClient("", "", "", httpClient) + require.NoError(t, err) + + _, err = client.Get(context.Background(), "/") + require.EqualError(t, err, "Internal API unreachable") + require.Equal(t, 1, reqAttempts) + }) + + t.Run("retryable http on", func(t *testing.T) { + os.Setenv("FF_GITLAB_SHELL_RETRYABLE_HTTP", "1") + reqAttempts := 0 + srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + reqAttempts++ + w.WriteHeader(500) + })) + defer srv.Close() + + httpClient, err := NewHTTPClientWithOpts(srv.URL, "/", "", "", 1, nil) + require.NoError(t, err) + client, err := NewGitlabNetClient("", "", "", httpClient) + require.NoError(t, err) + + _, err = client.Get(context.Background(), "/") + require.EqualError(t, err, "Internal API unreachable") + require.Equal(t, 3, reqAttempts) + }) +} |