summaryrefslogtreecommitdiff
path: root/client/gitlabnet.go
diff options
context:
space:
mode:
Diffstat (limited to 'client/gitlabnet.go')
-rw-r--r--client/gitlabnet.go47
1 files changed, 43 insertions, 4 deletions
diff --git a/client/gitlabnet.go b/client/gitlabnet.go
index 24c1d5f..38adf2a 100644
--- a/client/gitlabnet.go
+++ b/client/gitlabnet.go
@@ -7,10 +7,12 @@ import (
"fmt"
"io"
"net/http"
+ "os"
"strings"
"time"
"github.com/golang-jwt/jwt/v4"
+ "github.com/hashicorp/go-retryablehttp"
"gitlab.com/gitlab-org/labkit/log"
)
@@ -53,7 +55,6 @@ func NewGitlabNetClient(
secret string,
httpClient *HttpClient,
) (*GitlabNetClient, error) {
-
if httpClient == nil {
return nil, fmt.Errorf("Unsupported protocol")
}
@@ -107,6 +108,25 @@ func newRequest(ctx context.Context, method, host, path string, data interface{}
return request, nil
}
+func newRetryableRequest(ctx context.Context, method, host, path string, data interface{}) (*retryablehttp.Request, error) {
+ var jsonReader io.Reader
+ if data != nil {
+ jsonData, err := json.Marshal(data)
+ if err != nil {
+ return nil, err
+ }
+
+ jsonReader = bytes.NewReader(jsonData)
+ }
+
+ request, err := retryablehttp.NewRequestWithContext(ctx, method, appendPath(host, path), jsonReader)
+ if err != nil {
+ return nil, err
+ }
+
+ return request, nil
+}
+
func parseError(resp *http.Response) error {
if resp.StatusCode >= 200 && resp.StatusCode <= 399 {
return nil
@@ -136,9 +156,15 @@ func (c *GitlabNetClient) DoRequest(ctx context.Context, method, path string, da
return nil, err
}
+ retryableRequest, err := newRetryableRequest(ctx, method, c.httpClient.Host, path, data)
+ if err != nil {
+ return nil, err
+ }
+
user, password := c.user, c.password
if user != "" && password != "" {
request.SetBasicAuth(user, password)
+ retryableRequest.SetBasicAuth(user, password)
}
claims := jwt.RegisteredClaims{
@@ -152,18 +178,31 @@ func (c *GitlabNetClient) DoRequest(ctx context.Context, method, path string, da
return nil, err
}
request.Header.Set(apiSecretHeaderName, tokenString)
+ retryableRequest.Header.Set(apiSecretHeaderName, tokenString)
originalRemoteIP, ok := ctx.Value(OriginalRemoteIPContextKey{}).(string)
if ok {
request.Header.Add("X-Forwarded-For", originalRemoteIP)
+ retryableRequest.Header.Add("X-Forwarded-For", originalRemoteIP)
}
request.Header.Add("Content-Type", "application/json")
+ retryableRequest.Header.Add("Content-Type", "application/json")
request.Header.Add("User-Agent", c.userAgent)
+ retryableRequest.Header.Add("User-Agent", c.userAgent)
request.Close = true
+ retryableRequest.Close = true
start := time.Now()
- response, err := c.httpClient.Do(request)
+
+ var response *http.Response
+ var respErr error
+ if c.httpClient.HTTPClient != nil {
+ response, respErr = c.httpClient.HTTPClient.Do(request)
+ }
+ if os.Getenv("FF_GITLAB_SHELL_RETRYABLE_HTTP") == "1" && c.httpClient.RetryableHTTP != nil {
+ response, respErr = c.httpClient.RetryableHTTP.Do(retryableRequest)
+ }
fields := log.Fields{
"method": method,
"url": request.URL.String(),
@@ -171,8 +210,8 @@ func (c *GitlabNetClient) DoRequest(ctx context.Context, method, path string, da
}
logger := log.WithContextFields(ctx, fields)
- if err != nil {
- logger.WithError(err).Error("Internal API unreachable")
+ if respErr != nil {
+ logger.WithError(respErr).Error("Internal API unreachable")
return nil, &ApiError{"Internal API unreachable"}
}