1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
|
package sshd
import (
"context"
"crypto/dsa"
"crypto/rand"
"crypto/rsa"
"path"
"testing"
"github.com/stretchr/testify/require"
"golang.org/x/crypto/ssh"
"gitlab.com/gitlab-org/gitlab-shell/internal/config"
"gitlab.com/gitlab-org/gitlab-shell/internal/testhelper"
)
func TestNewServerConfigWithoutHosts(t *testing.T) {
_, err := newServerConfig(&config.Config{GitlabUrl: "http://localhost"})
require.Error(t, err)
require.Equal(t, "No host keys could be loaded, aborting", err.Error())
}
func TestFailedAuthorizedKeysClient(t *testing.T) {
_, err := newServerConfig(&config.Config{GitlabUrl: "ftp://localhost"})
require.Error(t, err)
require.Equal(t, "failed to initialize GitLab client: Error creating http client: unknown GitLab URL prefix", err.Error())
}
func TestFailedGetAuthKey(t *testing.T) {
testhelper.PrepareTestRootDir(t)
srvCfg := config.ServerConfig{
Listen: "127.0.0.1",
ConcurrentSessionsLimit: 1,
HostKeyFiles: []string{
path.Join(testhelper.TestRoot, "certs/valid/server.key"),
path.Join(testhelper.TestRoot, "certs/invalid-path.key"),
path.Join(testhelper.TestRoot, "certs/invalid/server.crt"),
},
}
cfg, err := newServerConfig(
&config.Config{GitlabUrl: "http://localhost", User: "user", Server: srvCfg},
)
require.NoError(t, err)
testCases := []struct {
desc string
user string
key ssh.PublicKey
expectedError string
}{
{
desc: "wrong user",
user: "wrong-user",
key: rsaPublicKey(t),
expectedError: "unknown user",
}, {
desc: "prohibited dsa key",
user: "user",
key: dsaPublicKey(t),
expectedError: "DSA is prohibited",
}, {
desc: "API error",
user: "user",
key: rsaPublicKey(t),
expectedError: "Internal API unreachable",
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
_, err = cfg.getAuthKey(context.Background(), tc.user, tc.key)
require.Error(t, err)
require.Equal(t, tc.expectedError, err.Error())
})
}
}
func TestDefaultAlgorithms(t *testing.T) {
srvCfg := &serverConfig{cfg: &config.Config{}}
sshServerConfig := srvCfg.get(context.Background())
require.Equal(t, supportedMACs, sshServerConfig.MACs)
require.Equal(t, supportedKeyExchanges, sshServerConfig.KeyExchanges)
require.Nil(t, sshServerConfig.Ciphers)
sshServerConfig.SetDefaults()
require.Equal(t, supportedMACs, sshServerConfig.MACs)
require.Equal(t, supportedKeyExchanges, sshServerConfig.KeyExchanges)
defaultCiphers := []string{
"aes128-gcm@openssh.com",
"chacha20-poly1305@openssh.com",
"aes256-gcm@openssh.com",
"aes128-ctr",
"aes192-ctr",
"aes256-ctr",
}
require.Equal(t, defaultCiphers, sshServerConfig.Ciphers)
}
func TestCustomAlgorithms(t *testing.T) {
customMACs := []string{ssh.MacAlgoHmacSHA2512ETM}
customKexAlgos := []string{ssh.KexAlgoCurve25519SHA256}
customCiphers := []string{"aes256-gcm@openssh.com"}
srvCfg := &serverConfig{
cfg: &config.Config{
Server: config.ServerConfig{
MACs: customMACs,
KexAlgorithms: customKexAlgos,
Ciphers: customCiphers,
},
},
}
sshServerConfig := srvCfg.get(context.Background())
require.Equal(t, customMACs, sshServerConfig.MACs)
require.Equal(t, customKexAlgos, sshServerConfig.KeyExchanges)
require.Equal(t, customCiphers, sshServerConfig.Ciphers)
sshServerConfig.SetDefaults()
require.Equal(t, customMACs, sshServerConfig.MACs)
require.Equal(t, customKexAlgos, sshServerConfig.KeyExchanges)
require.Equal(t, customCiphers, sshServerConfig.Ciphers)
}
func rsaPublicKey(t *testing.T) ssh.PublicKey {
privateKey, err := rsa.GenerateKey(rand.Reader, 2048)
require.NoError(t, err)
publicKey, err := ssh.NewPublicKey(&privateKey.PublicKey)
require.NoError(t, err)
return publicKey
}
func dsaPublicKey(t *testing.T) ssh.PublicKey {
privateKey := new(dsa.PrivateKey)
params := new(dsa.Parameters)
require.NoError(t, dsa.GenerateParameters(params, rand.Reader, dsa.L1024N160))
privateKey.PublicKey.Parameters = *params
require.NoError(t, dsa.GenerateKey(privateKey, rand.Reader))
publicKey, err := ssh.NewPublicKey(&privateKey.PublicKey)
require.NoError(t, err)
return publicKey
}
|
