summaryrefslogtreecommitdiff
path: root/gladeui/glade-project.c
diff options
context:
space:
mode:
authorDavid Shea <dshea@redhat.com>2014-07-23 17:34:02 -0400
committerJuan Pablo Ugarte <juanpablougarte@gmail.com>2014-07-25 14:24:50 -0300
commit378baef2c414173f92f14b79b79dcd7531871ead (patch)
treeed031ecd54e0bffc5f3d456afdbf2375cf9bd3d9 /gladeui/glade-project.c
parent2282219967db5ba3428c090211fa2aeda6f8f02c (diff)
downloadglade-378baef2c414173f92f14b79b79dcd7531871ead.tar.gz
Avoid reading freed data in glade_project_read_requires
Ensure that required_lib is NULL at the start of each iteration through the loop.
Diffstat (limited to 'gladeui/glade-project.c')
-rw-r--r--gladeui/glade-project.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/gladeui/glade-project.c b/gladeui/glade-project.c
index 3a0de592..79655806 100644
--- a/gladeui/glade-project.c
+++ b/gladeui/glade-project.c
@@ -1433,7 +1433,6 @@ glade_project_read_requires (GladeProject *project,
GString *string = g_string_new (NULL);
GladeXmlNode *node;
- gchar *required_lib = NULL;
gboolean loadable = TRUE;
guint16 major, minor;
gint position = 0;
@@ -1441,6 +1440,8 @@ glade_project_read_requires (GladeProject *project,
for (node = glade_xml_node_get_children_with_comments (root_node);
node; node = glade_xml_node_next_with_comments (node))
{
+ gchar *required_lib = NULL;
+
/* Skip non "requires" tags */
if (!(glade_xml_node_verify_silent (node, GLADE_XML_TAG_REQUIRES) ||
(required_lib =