diff options
| author | Kjell Ahlstedt <kjellahlstedt@gmail.com> | 2020-11-01 13:29:48 +0100 |
|---|---|---|
| committer | Kjell Ahlstedt <kjellahlstedt@gmail.com> | 2020-11-01 13:29:48 +0100 |
| commit | 3f9bbd905d10dec534023bb398a0c8bb103672de (patch) | |
| tree | 0a9a57bbe9ff331f56dc0e8a852c68d5a6ee5540 /glib | |
| parent | 9aaade399592d42312e78d54c3581c1fcd731b71 (diff) | |
| download | glibmm-3f9bbd905d10dec534023bb398a0c8bb103672de.tar.gz | |
Gio::File docs: Fix names of thrown exceptions
and remove unnecessary TODO comments in several files.
Diffstat (limited to 'glib')
| -rw-r--r-- | glib/src/convert.ccg | 3 | ||||
| -rw-r--r-- | glib/src/module.hg | 2 | ||||
| -rw-r--r-- | glib/src/optiongroup.hg | 3 |
3 files changed, 1 insertions, 7 deletions
diff --git a/glib/src/convert.ccg b/glib/src/convert.ccg index cd08eacd..bcdd7f55 100644 --- a/glib/src/convert.ccg +++ b/glib/src/convert.ccg @@ -86,7 +86,6 @@ IConv::convert(const std::string& str) if (gerror) ::Glib::Error::throw_exception(gerror); - // TODO: Avoid the copy by using a perfect-forwarding std::string constructor? return std::string(make_unique_ptr_gfree(buf).get(), bytes_written); } @@ -120,7 +119,6 @@ convert(const std::string& str, const std::string& to_codeset, const std::string if (gerror) ::Glib::Error::throw_exception(gerror); - // TODO: Avoid the copy by using a perfect-forwarding std::string constructor? return std::string(make_unique_ptr_gfree(buf).get(), bytes_written); } @@ -137,7 +135,6 @@ convert_with_fallback( if (gerror) ::Glib::Error::throw_exception(gerror); - // TODO: Avoid the copy by using a perfect-forwarding std::string constructor? return std::string(make_unique_ptr_gfree(buf).get(), bytes_written); } diff --git a/glib/src/module.hg b/glib/src/module.hg index ea926882..8ea00edb 100644 --- a/glib/src/module.hg +++ b/glib/src/module.hg @@ -133,8 +133,6 @@ public: * @param module_name The name of the module * @returns The system-specific filename of the module */ - // TODO: add an override which doesn't take a directory - // TODO: check what happens when directory is "" _WRAP_METHOD(static std::string build_path(const std::string& directory, const std::string& module_name), g_module_build_path) GModule* gobj() { return gobject_; } diff --git a/glib/src/optiongroup.hg b/glib/src/optiongroup.hg index aebb03bb..54a830f5 100644 --- a/glib/src/optiongroup.hg +++ b/glib/src/optiongroup.hg @@ -21,8 +21,7 @@ _DEFS(glibmm,glib) #include <sigc++/slot.h> #include <map> #include <vector> -#include <glib.h> //TODO: Try to hide this. - +#include <glib.h> #ifndef DOXYGEN_SHOULD_SKIP_THIS extern "C" { typedef struct _GOptionGroup GOptionGroup; } |