summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Escape markup in property valuesJames Westman2020-08-292-3/+3
| | | | | | | This fixes an issue where property values that contained markup characters weren't displayed. Fixes #8.
* introspection: Clear idle id when done with itRay Strode2020-05-201-0/+1
| | | | | | | | | commit 3c82a664155695bd4243c2a964b3ec22c544f3f6 added an idle handler to help process introspection requests asynchronously. It failed to clear the idle handler id when the idle finished, however. This commit fixes that.
* introspection: Load introspection data asynchronouslyRay Strode2020-05-141-5/+14
| | | | | | | | | | | Some projects, like systemd, have truely gigantic introspection trees. At the moment that makes d-feet lock up. To address that problem, this commit changes d-feet to process the incoming introspection data from an idle handler. https://gitlab.gnome.org/GNOME/d-feet/-/merge_requests/26
* DFeetApp: add --addressMarc-André Lureau2020-03-261-0/+6
| | | | | | | This will allow to open D-Feet directly to a given address from the CLI. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
* DFeetApp: add --versionMarc-André Lureau2020-03-261-1/+25
| | | | Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
* DFeetWindow: switch to the added bus watchMarc-André Lureau2020-03-261-0/+1
| | | | | | This will avoid having to switch manually after entering the address. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
* DFeetWindow: factor out connect_to(address)Marc-André Lureau2020-03-261-12/+18
| | | | | | | Reused in the following patch. Also returns whether attempt was successfull. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
* meson: install to pure locationMarc-André Lureau2020-03-261-0/+1
| | | | | | | | | | | Source should be installed by default to the pure location. This is actually a bug in meson: https://github.com/mesonbuild/meson/pull/6848 This also fixes some ninja install error due to discrepancy between install_sources() and get_install_dir() locations during post-install script. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
* build: use python path methodChris Mayo2020-03-231-1/+1
| | | | | The method was added to Meson in 0.50.0 which is the current minimum for d-feet.
* tests: run pycodestyle as a testWill Thompson2019-08-061-5/+8
| | | | | | Previously it was run at the point where `meson` was invoked, which won't catch the case where you introduce a style violation after running `meson`.
* tests: run with --verboseWill Thompson2019-08-061-0/+1
| | | | | | | | They are currently timing out in the Flatpak CI, but there's no indication as to why. Meson captures the output of tests and hides it if they pass, so it seems safe to always run them verbosely.
* dbus_utils: fix indentationWill Thompson2019-03-211-1/+1
| | | | | | | | pycodestyle says: ../../src/dfeet/dbus_utils.py:124:17: E117 over-indented and it is correct: the indentation is misleading.
* build: Fix d-feet executable modeIñigo Martínez2019-02-031-0/+0
| | | | | | | | | meson creates the `d-feet` file from `d-feet.in` input file using its same file mode bits. However, the input file does not have the executable mode enabled. The executable mode bit has been enabled so `d-feet` file is created with proper modes.
* build: Remove autotoolsIñigo Martínez2019-01-223-69/+0
| | | | | To avoid the burden of maintaining multiple build systems, this patch removes autotools support.
* build: Port to meson build systemIñigo Martínez2019-01-223-0/+58
| | | | | | meson is a build system focused on speed an ease of use, which helps speeding up the software development. This patch adds meson support along autotools.
* Add required introspection versionIñigo Martínez2019-01-221-0/+2
| | | | | | | D-Feet's test unit does not specify the required introspection version. This adds the required introspection version.
* build: Replace hard coded values for build time variablesIñigo Martínez2019-01-222-3/+5
| | | | | | | | | The test unit contains hard coded values for paths. However, these hard coded variables consider that the source code path and the build path are the same, something usual in autotools. These hard coded values has been replaced by build time variables that take the appropiate values considering different build paths.
* about: capitalize D-Feet app nameJeremy Bicha2018-12-051-1/+4
| | | | to match the .desktop file and the updated about menu item label
* menus: Follow GNOME 3.32 menu guidelinesJeremy Bicha2018-12-051-4/+0
| | | | https://gitlab.gnome.org/GNOME/Initiatives/wikis/App-Menu-Retirement
* Merge branch 'correctly-honour-theme-foreground-colour-2' into 'master'Will Thompson2018-10-221-18/+2
|\ | | | | | | | | Correctly honour theme foreground colour See merge request GNOME/d-feet!12
| * Correctly honour theme foreground colourWill Thompson2018-10-181-18/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Rather than try to explicitly look up the colour, don't specify a colour at all. Argument names are never nested within a <span> applying a different foreground colour. This does have one visible effect: with Adwaita (light), selecting the treeview row causes method argument names to switch from black to white, just like the method name. I think this is actually more readable (and the green used for the signature is illegible against the blue selected-row highlight.) As discussed in https://gitlab.gnome.org/GNOME/d-feet/merge_requests/4#note_319094 and !8.
* | dbus_utils: stringify "h" (UNIX FD)Will Thompson2018-10-181-0/+1
| | | | | | | | | | | | | | This was added to D-Bus almost a decade ago. Without this change it shows up as 'Error(h)' in method signatures. (This doesn't mean we support passing them as in-parameters.)
* | dbus_utils: simplify converting simple typesWill Thompson2018-10-181-33/+21
| |
* | dbus_utils: simplify looking ahead 1 characterWill Thompson2018-10-181-6/+1
|/ | | | | It's legal to slice past the end of the string; you get back an empty string in that case.
* settings: fix regexp syntax, add a testWill Thompson2018-09-192-1/+38
| | | | | | | | | Trying to compile this regexp fails with: re.error: unbalanced parenthesis at position 5 I introduced this bug in 45a1146e1122b376ddac312687e8e27d4e0a8076. Fix it, and add a small test case that would have caught it.
* Merge branch 'enable-gitlab-ci' into 'master'Thomas Bechtold2018-09-1910-24/+40
|\ | | | | | | | | Fix 'make check', detect 'pycodestyle' (the new name for 'pep8'), use Python 3 in Flatpak version, and set up CI See merge request GNOME/d-feet!7
| * settings: use r'' strings for regexpsWill Thompson2018-09-191-5/+6
| | | | | | | | | | | | | | ../../src/dfeet/settings.py:22:17: W605 invalid escape sequence '\.' ../../src/dfeet/settings.py:23:6: W605 invalid escape sequence '\s' ../../src/dfeet/settings.py:28:10: W605 invalid escape sequence '\s' ../../src/dfeet/settings.py:29:12: W605 invalid escape sequence '\('
| * Ignore W504 line break after binary operatorWill Thompson2018-09-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following code: self.connection = Gio.DBusConnection.new_for_address_sync( self.__bus_address, Gio.DBusConnectionFlags.AUTHENTICATION_CLIENT | Gio.DBusConnectionFlags.MESSAGE_BUS_CONNECTION, None, None) causes newer versions of pycodestyle to complain: ../../src/dfeet/bus_watch.py:139:17: W504 line break after binary operator However, if I move the the line break to be before the binary operator: self.connection = Gio.DBusConnection.new_for_address_sync( self.__bus_address, Gio.DBusConnectionFlags.AUTHENTICATION_CLIENT | Gio.DBusConnectionFlags.MESSAGE_BUS_CONNECTION, None, None) Older versions complain in the opposite way: ../../src/dfeet/bus_watch.py:140:17: W503 line break before binary operator The thread around https://mail.python.org/pipermail/python-ideas/2016-April/039774.html explains why the tool has changed its mind. I prefer the old style, so let's just ignore the new warning.
| * Fix a few unused variable/import warningsWill Thompson2018-09-194-4/+1
| | | | | | | | These were all reported by flake8.
| * Remove bare 'except:' clausesWill Thompson2018-09-195-9/+13
| | | | | | | | These are considered Bad Style, and pycodestyle reports them as such.
| * Detect 'pycodestyle', the new name for 'pep8'Will Thompson2018-09-191-3/+4
| | | | | | | | | | | | | | | | | | The 'pep8' tool has been renamed upstream to 'pycodestyle'. On Debian, the Python 3 version is packaged and installed as pycodestyle. On Fedora, it's packaged as python3-pycodestyle and installed as pycodestyle-3; the Python 2 version is installed as pycodestyle-2 with a symlink from pycodestyle. Make configure search a variety of such names, and use the path it finds.
| * Run tests with same Python version as applicationWill Thompson2018-09-192-2/+7
| | | | | | | | | | | | | | Since c28acbf326bb79543b285f371bdf068d8831d9a7 the application has used the Python version detected at configure time, but tests were still unconditionally run with the system version of Python 2. This made it impossible to run the tests on systems with only Python 3.
| * Fix coding style errors reported by make checkWill Thompson2018-09-181-1/+9
| | | | | | | | | | | | | | | | | | | | | | These were introduced in e6488e6c0fd0416c54ecff1dd682f0ae8aa4c6fb and e6488e6c0fd0416c54ecff1dd682f0ae8aa4c6fb: src/dfeet/introspection_helper.py:9:1: E302 expected 2 blank lines, found 1 src/dfeet/introspection_helper.py:14:100: E501 line too long (107 > 99 characters) src/dfeet/introspection_helper.py:17:1: E302 expected 2 blank lines, found 1 src/dfeet/introspection_helper.py:20:1: E302 expected 2 blank lines, found 1 src/dfeet/introspection_helper.py:23:1: E302 expected 2 blank lines, found 1
* | executedialog: include bus nameWill Thompson2018-09-181-0/+2
|/ | | | | | This dialog is not particularly short of space, and it's nice to have the full (bus name, object path, interface, method name) quad visible in one place.
* Fix format string with python3Guido Günther2018-07-221-1/+1
| | | | | | See: !4 Spotted-by: Johannes Sasongko
* Merge branch ↵Thomas Bechtold2018-05-271-0/+51
|\ | | | | | | | | | | | | | | | | '6-display-statistics-and-match-rules-from-the-new-stats-interface' into 'master' Display statistics and match rules from the Stats interface Closes #6 See merge request GNOME/d-feet!3
| * display statistics and match rules from the D-Bus Stats interface6-display-statistics-and-match-rules-from-the-new-stats-interfaceAlban Crequy2018-05-091-0/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This requires dbus 1.9.0 for the new GetAllMatchRules call on the Stats interface and for compiling the Stats interface by default. The Stats interface is enabled by default on the session bus. On the system bus, it is not enabled for non-root users by default but it can be enabled as shown in /usr/share/doc/dbus/examples/example-system-enable-stats.conf If the feature is not available in D-Bus, D-Feet ignores the error and continues as before. https://bugzilla.gnome.org/show_bug.cgi?id=735167
* | Honor theme's foreground colorGuido Günther2018-05-091-4/+12
|/ | | | This makes property names readable on dark themes like adwaita-dark.
* Remove unused DFeetWindow.package fieldfix-icon-nameWill Thompson2018-02-212-3/+2
|
* Set icon_name to org.gnome.dfeetWill Thompson2018-02-212-4/+5
| | | | | This was being set to "d-feet", but the icon is now called org.gnome.dfeet.
* Do not use hyphen for the reverse-DNS namesrenameMathieu Bridon2018-02-102-4/+4
| | | | | | | | | The convention for DBus and Flatpak is to not use hyphens in the last segment of a name. In fact, this is even illegal in object paths. This commit moves everything from org.gnome.d-feet to org.gnome.dfeet
* Use locale.textdomain otherwise gtkbuilder translations don't workSebastien Bacher2017-11-241-2/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=758889
* Make pep8 happyThomas Bechtold2017-11-241-1/+2
|
* ExecuteMethodDialog: set_transient_for()Will Thompson2017-11-242-2/+5
| | | | | | | | | | | | Without this, we see: Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged. You currently cannot actually interact with the toplevel application window while an ExecuteMethodDialog is visible; this change also makes this fact visible to the user. https://bugzilla.gnome.org/show_bug.cgi?id=734514
* ExecuteMethodDialog: Pretty-print multiple resultsSimon McVittie2017-11-241-1/+2
| | | | | | | | | | | | | | If a D-Bus method returns multiple results, d-feet previously only pretty-printed the first. Print them one per line, so a method with return signature 'isa{sv}' might end up showing: 123, "hello, world!", {} Signed-off-by: Simon McVittie <smcv@collabora.com> https://bugzilla.gnome.org/show_bug.cgi?id=784387
* Fix PEP8 305 style errorMichael Biebl2017-11-242-0/+2
| | | | | | | | | With pep8, or rather its successor pycodestyle 2.2.0, the test-suite fails with: ../../src/tests/tests.py:105:1: E305 expected 2 blank lines after class or function definition, found 1 https://bugzilla.gnome.org/show_bug.cgi?id=774735
* Show values that have a logical False representation.Benjamin Berg2017-08-141-1/+1
| | | | | | | Correctly test whether a value has been retrieved (not None) instead of testing whether the value is logically True to decide on showing it. https://bugzilla.gnome.org/show_bug.cgi?id=783006
* Make pep8 happyThomas Bechtold2017-06-281-0/+1
|
* Revert "Don't use Wnck to get app-icons under non-X11"Debarshi Ray2017-06-161-12/+11
| | | | | | | | | Since we are completely ignoring Wnck on non-X11, there is no need to guard against the default Wnck.Screen being None. This reverts commit c9d202ede2474f4a748be78fac78ba077e958399. https://bugzilla.gnome.org/show_bug.cgi?id=763615
* Assume Wnck is absent on non-X11Debarshi Ray2017-06-161-2/+7
| | | | | | | | | | | Wnck is an X11-only API. While Wnck.Screen.get_default() might have elegantly returned None in the absence of X11 earlier, we cannot rely on that behaviour. In fact, the same version of libwnck has started to crash inside Wnck.Screen.get_default(). Let's not touch Wnck when X11 is absent. https://bugzilla.gnome.org/show_bug.cgi?id=763615
View Lorry Controller Status