summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRay Strode <rstrode@redhat.com>2022-12-15 14:46:01 -0500
committerRay Strode <rstrode@redhat.com>2022-12-15 14:59:40 -0500
commit8c5b63069dfbf36ac662369d9ba3fb4ab0d2efb2 (patch)
treecd798e90d61500a3d7604e97f18c6f269083b8fc
parent10df58d8c42f7b47a9e7be54219958c8afdd0322 (diff)
downloadgnome-online-accounts-8c5b63069dfbf36ac662369d9ba3fb4ab0d2efb2.tar.gz
kerberos-identity: Fix buglet in update_identity
The update_identity function is supposed to transfer the identity form one object to another. In practice, this is currently always a noop because only objects with the same identities get copied to each other. Nevertheless, there is a bug in the function. It grabs the identity from the target object instead of from the source object. This commit fixes that.
-rw-r--r--src/goaidentity/goakerberosidentity.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/goaidentity/goakerberosidentity.c b/src/goaidentity/goakerberosidentity.c
index a20c043..bc60796 100644
--- a/src/goaidentity/goakerberosidentity.c
+++ b/src/goaidentity/goakerberosidentity.c
@@ -1507,7 +1507,7 @@ update_identifier (GoaKerberosIdentity *self, GoaKerberosIdentity *new_identity)
{
char *new_identifier;
- new_identifier = get_identifier (self, NULL);
+ new_identifier = get_identifier (new_identity, NULL);
if (g_strcmp0 (self->identifier, new_identifier) != 0 && new_identifier != NULL)
{
g_free (self->identifier);