diff options
| author | Debarshi Ray <debarshir@gnome.org> | 2022-10-13 22:14:07 +0200 |
|---|---|---|
| committer | Debarshi Ray <debarshir@gnome.org> | 2022-10-13 22:18:58 +0200 |
| commit | 4acfcc323e986526975ede981673dd173be4e267 (patch) | |
| tree | 309301d5e26ee0395bc7fdd75af5a30b5d1cffa8 /src | |
| parent | 526e01c134949ce25f00d13f260f7a41ed12a9c4 (diff) | |
| download | gnome-online-accounts-4acfcc323e986526975ede981673dd173be4e267.tar.gz | |
kerberos-identity: Fail initialization if an identifier can't be found
The inability to get an identifier already leads to an error.
Continuing beyond that point can lead to the verification_error trying
to clobber it.
https://gitlab.gnome.org/GNOME/gnome-online-accounts/-/merge_requests/107
Diffstat (limited to 'src')
| -rw-r--r-- | src/goaidentity/goakerberosidentity.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/goaidentity/goakerberosidentity.c b/src/goaidentity/goakerberosidentity.c index 57ab616..b72ce6a 100644 --- a/src/goaidentity/goakerberosidentity.c +++ b/src/goaidentity/goakerberosidentity.c @@ -985,9 +985,10 @@ goa_kerberos_identity_initable_init (GInitable *initable, if (self->identifier == NULL) { self->identifier = get_identifier (self, error); + if (self->identifier == NULL) + return FALSE; - if (self->identifier != NULL) - queue_notify (self, &self->identifier_idle_id, "identifier"); + queue_notify (self, &self->identifier_idle_id, "identifier"); } verification_error = NULL; |