diff options
| author | Debarshi Ray <debarshir@gnome.org> | 2022-10-13 19:02:59 +0200 |
|---|---|---|
| committer | Debarshi Ray <debarshir@gnome.org> | 2022-10-13 19:16:13 +0200 |
| commit | 77594888fa7a854676ec8a014a5575ffe0b90771 (patch) | |
| tree | 8bcc5455492484c0a3c663447ff69f582bd2db0a /src | |
| parent | 74e31cabb979d6c1d4c85807c8991a6c433a0d82 (diff) | |
| download | gnome-online-accounts-77594888fa7a854676ec8a014a5575ffe0b90771.tar.gz | |
kerberos-identity: Clarify the error when talking to the KDC failed
When krb5_get_renewed_creds fails to talk to the Kerberos Key
Distribution Centre (or KDC) because of network problems,
krb5_get_error_message translates the krb5_error_code as:
Resource temporarily unavailable
This ends up in the debug logs as:
GoaKerberosIdentityManager: could not renew identity: Could not get
new credentials to renew identity FOO@BAR.ORG: Resource temporarily
unavailable
GoaIdentityService: could not renew identity: Could not get new
credentials to renew identity FOO@BAR.ORG: Resource temporarily
unavailable
It's not immediately clear that the 'resource' that's 'temporarily
unavailable' is actually the KDC, which would make it easier to
understand that there is a network problem.
Therefore, mention KDC in the error string from krb5_get_renewed_creds
and make it match the documentation [1] of that function because it
makes the code self-documenting.
[1] https://web.mit.edu/kerberos/krb5-devel/doc/appdev/refs/api/krb5_get_renewed_creds.html
https://gitlab.gnome.org/GNOME/gnome-online-accounts/-/issues/160
Diffstat (limited to 'src')
| -rw-r--r-- | src/goaidentity/goakerberosidentity.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/goaidentity/goakerberosidentity.c b/src/goaidentity/goakerberosidentity.c index 3d2fe25..57ab616 100644 --- a/src/goaidentity/goakerberosidentity.c +++ b/src/goaidentity/goakerberosidentity.c @@ -1454,7 +1454,7 @@ goa_kerberos_identity_renew (GoaKerberosIdentity *self, GError **error) error, GOA_IDENTITY_ERROR_RENEWING, error_code, - _("Could not get new credentials to renew identity %s: "), + _("Could not get renewed credentials from the KDC for identity %s: "), name); goto free_principal; } |