diff options
| author | Florian Müllner <fmuellner@gnome.org> | 2021-10-28 19:55:23 +0200 |
|---|---|---|
| committer | Marge Bot <marge-bot@gnome.org> | 2021-10-30 21:50:47 +0000 |
| commit | 09ed1c533c2350b81e2c79f84998e8d3b4c1199a (patch) | |
| tree | 735dcb5e35e10c420eb62c784fb0a3bcc74f818a /subprojects | |
| parent | 79f448958b5ea16bc6a1f91117ed02a889712c90 (diff) | |
| download | gnome-shell-09ed1c533c2350b81e2c79f84998e8d3b4c1199a.tar.gz | |
extensions-tool/prefs: Log D-Bus errors
We currently ignore any error that may occur when calling the
OpenExtensionPrefs D-Bus method. Right now such an error is highly
unlikely, given that we already checked that we are running under
gnome-shell and the extension in question exists and has prefs.
We'll soon make sure that only one dialog is shown at any time,
which is an error that we can realistically expect, so handle that
properly.
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4564
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2013>
Diffstat (limited to 'subprojects')
| -rw-r--r-- | subprojects/extensions-tool/src/command-prefs.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/subprojects/extensions-tool/src/command-prefs.c b/subprojects/extensions-tool/src/command-prefs.c index 50e4b80ba..01c385e06 100644 --- a/subprojects/extensions-tool/src/command-prefs.c +++ b/subprojects/extensions-tool/src/command-prefs.c @@ -56,6 +56,14 @@ launch_extension_prefs (const char *uuid) NULL, &error); + if (error) + { + g_dbus_error_strip_remote_error (error); + g_printerr (_("Failed to open prefs for extension “%s”: %s\n"), + uuid, error->message); + return FALSE; + } + return TRUE; } |