kvm_nlist () returns -1 on error, but a positive return value does not

2000-02-13  Martin Baulig  <martin@home-of-linux.org>

	* *.c: kvm_nlist () returns -1 on error, but a positive return value
	does not necessarily mean failure. Fixes #3302 which was reported by
	Matthias Scheler some time ago.

10 files changed, 16 insertions, 10 deletions

diff --git a/sysdeps/freebsd/ChangeLog b/sysdeps/freebsd/ChangeLog
index c5acd918..5abcfc3d 100644
--- a/sysdeps/freebsd/ChangeLog
+++ b/sysdeps/freebsd/ChangeLog
@@ -1,3 +1,9 @@
+2000-02-13  Martin Baulig  <martin@home-of-linux.org>
+
+	* *.c: kvm_nlist () returns -1 on error, but a positive return value
+	does not necessarily mean failure. Fixes #3302 which was reported by
+	Matthias Scheler some time ago.
+
 2000-02-06  Martin Baulig  <martin@home-of-linux.org>
 
 	* Makefile.am: Removed the non-suid `libgtop-sysdeps.la'.
diff --git a/sysdeps/freebsd/cpu.c b/sysdeps/freebsd/cpu.c
index 4d75166d..74aaf9cb 100644
--- a/sysdeps/freebsd/cpu.c
+++ b/sysdeps/freebsd/cpu.c
@@ -53,7 +53,7 @@ static int mib [] = { CTL_KERN, KERN_CLOCKRATE };
 int
 glibtop_init_cpu_p (glibtop *server)
 {
-    if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) {
+    if (kvm_nlist (server->_priv->machine.kd, nlst) < 0) {
 	glibtop_warn_io_r (server, "kvm_nlist (cpu)");
 	return -1;
     }
diff --git a/sysdeps/freebsd/mem.c b/sysdeps/freebsd/mem.c
index 0794b71b..b80edcdc 100644
--- a/sysdeps/freebsd/mem.c
+++ b/sysdeps/freebsd/mem.c
@@ -94,7 +94,7 @@ glibtop_init_mem_p (glibtop *server)
 {
     register int pagesize;
 
-    if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) {
+    if (kvm_nlist (server->_priv->machine.kd, nlst) < 0) {
 	glibtop_warn_io_r (server, "kvm_nlist (mem)");
 	return -1;
     }
diff --git a/sysdeps/freebsd/msg_limits.c b/sysdeps/freebsd/msg_limits.c
index a3675f2d..2e7bd293 100644
--- a/sysdeps/freebsd/msg_limits.c
+++ b/sysdeps/freebsd/msg_limits.c
@@ -82,7 +82,7 @@ static struct nlist nlst [] = {
 int
 glibtop_init_msg_limits_p (glibtop *server)
 {
-    if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) {
+    if (kvm_nlist (server->_priv->machine.kd, nlst) < 0) {
 	glibtop_warn_io_r (server, "kvm_nlist (msg_limits)");
 	return -1;
     }
diff --git a/sysdeps/freebsd/netinfo.c b/sysdeps/freebsd/netinfo.c
index b2abe49e..6797e1d2 100644
--- a/sysdeps/freebsd/netinfo.c
+++ b/sysdeps/freebsd/netinfo.c
@@ -59,7 +59,7 @@ glibtop_init_netinfo_p (glibtop *server)
 {
     server->sysdeps.netinfo = _glibtop_sysdeps_netinfo;
 
-    if (kvm_nlist (server->_priv->machine.kd, nlst) != 0)
+    if (kvm_nlist (server->_priv->machine.kd, nlst) < 0)
 	glibtop_error_io_r (server, "kvm_nlist");
 
     return 0;
diff --git a/sysdeps/freebsd/netload.c b/sysdeps/freebsd/netload.c
index 35a22cab..5f9a0304 100644
--- a/sysdeps/freebsd/netload.c
+++ b/sysdeps/freebsd/netload.c
@@ -65,7 +65,7 @@ glibtop_init_netload_p (glibtop *server)
 {
     server->sysdeps.netload = _glibtop_sysdeps_netload;
 
-    if (kvm_nlist (server->_priv->machine.kd, nlst) != 0)
+    if (kvm_nlist (server->_priv->machine.kd, nlst) < 0)
 	glibtop_error_io_r (server, "kvm_nlist");
 
     return 0;
diff --git a/sysdeps/freebsd/ppp.c b/sysdeps/freebsd/ppp.c
index 5e1bff09..b255388e 100644
--- a/sysdeps/freebsd/ppp.c
+++ b/sysdeps/freebsd/ppp.c
@@ -84,7 +84,7 @@ glibtop_init_ppp_p (glibtop *server)
 #endif
 #endif /* HAVE_I4B */
 
-    if (kvm_nlist (server->_priv->machine.kd, nlst) != 0)
+    if (kvm_nlist (server->_priv->machine.kd, nlst) < 0)
 	glibtop_error_io_r (server, "kvm_nlist");
 
     return 0;
diff --git a/sysdeps/freebsd/sem_limits.c b/sysdeps/freebsd/sem_limits.c
index 08b726e4..c0c91471 100644
--- a/sysdeps/freebsd/sem_limits.c
+++ b/sysdeps/freebsd/sem_limits.c
@@ -85,7 +85,7 @@ static struct nlist nlst [] = {
 int
 glibtop_init_sem_limits_p (glibtop *server)
 {
-    if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) {
+    if (kvm_nlist (server->_priv->machine.kd, nlst) < 0) {
 	glibtop_warn_io_r (server, "kvm_nlist (sem_limits)");
 	return -1;
     }
diff --git a/sysdeps/freebsd/shm_limits.c b/sysdeps/freebsd/shm_limits.c
index cf889391..fd4d5583 100644
--- a/sysdeps/freebsd/shm_limits.c
+++ b/sysdeps/freebsd/shm_limits.c
@@ -83,7 +83,7 @@ static struct nlist nlst [] = {
 int
 glibtop_init_shm_limits_p (glibtop *server)
 {
-    if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) {
+    if (kvm_nlist (server->_priv->machine.kd, nlst) < 0) {
 	glibtop_warn_io_r (server, "kvm_nlist (shm_limits)");
 	return -1;
     }
diff --git a/sysdeps/freebsd/swap.c b/sysdeps/freebsd/swap.c
index 8e0a51d2..0ab96eae 100644
--- a/sysdeps/freebsd/swap.c
+++ b/sysdeps/freebsd/swap.c
@@ -99,7 +99,7 @@ glibtop_init_swap_p (glibtop *server)
 {
 #if defined(__FreeBSD__) || defined(__bsdi__)
 #if __FreeBSD__ < 4 || defined(__bsdi__)
-    if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) {
+    if (kvm_nlist (server->_priv->machine.kd, nlst) < 0) {
 	glibtop_warn_io_r (server, "kvm_nlist (swap)");
 	return -1;
     }
@@ -114,7 +114,7 @@ glibtop_init_swap_p (glibtop *server)
 #endif
 
 #if !(defined(__NetBSD__) && (__NetBSD_Version__ >= 104000000))
-    if (kvm_nlist (server->_priv->machine.kd, nlst2) != 0) {
+    if (kvm_nlist (server->_priv->machine.kd, nlst2) < 0) {
 	glibtop_warn_io_r (server, "kvm_nlist (cnt)");
 	return -1;
     }