| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
We use the locations of the schemas directory in two places, so we might
as well share the same variables everywhere.
|
|
|
|
|
| |
Use project_source_root() and project_build_root() instead of the
deprecated source_root() and build_root(), respectively.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The metar list provided by NOAA contains duplicate ICAO codes.
Those duplicates may change over time, so it does not make sense
to use an array of known duplicates. Presently a duplicate is rejected
when it is known, and inserted if it is not, leading to a difference
in the number of insertions and the number of keys, so that the test
fails. If any duplicate is rejected, the number of insertions is
always equal to the number of keys (unless something goes wrong
in g_hash_table_insert). And this is the default behavior for known
duplicates anyway.
Closes: https://gitlab.gnome.org/GNOME/libgweather/-/issues/168
|
|
|
|
|
| |
GWeatherTimezone can be replaced by GTimeZone, which has been available
since GLib 2.26.
|
|
|
|
|
| |
Otherwise they are going to break if we run the tests before the schemas
have been built, or if the enums change.
|
|
|
|
| |
Instead of accessing the internals of GWeatherLocation.
|
| |
|
| |
|
|
|
|
| |
We only need it inside the test utilities.
|
|
|
|
|
| |
This allows us to remove the libsoup include from the shared test
utilities header.
|
|
|
|
|
| |
We use the environment to specify the location of the locations database
file, instead of hard coding it into the binary.
|
| |
|
|
|
|
| |
This way we don't have to copy stuff around.
|
|
|
|
|
|
|
|
|
| |
The duplicate tests modify the environment, and impose ordering on the
general test suite.
Instead of modifying the environment inside the tests—which comes with
its own set of threading issues—we can split the tests into a separate
binary, and set up the environment when executing the test.
|
|
|
|
|
|
| |
We set up a separate directory for the GSettings schemas, to avoid
polluting the system one, but we should also take care of removing it at
the end, so we don't create a bunch of random directories in TMPDIR.
|
|
|
|
|
|
|
| |
The g_test_message() function ensures that the output does not break any
TAP harness. Replacing the random g_print/g_debug/g_message with
g_test_message() has the additional benefit of not requiring a custom
log handler.
|
|
|
|
|
|
| |
We want to make it easier to use GWeatherLocation inside data structures
like GListModel implementations. It's also easier to use from language
bindings, as now objects will have a clear life time.
|
|
|
|
| |
Ensure that the changes are consistent.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
While it would be very nice to keep our artisanal, locally sourced,
hand-crafted coding style, our time is better spent trying to fix issues
and implement features, instead of doing coding style reviews. In order
to have our CI pipeline in charge of keeping and checking the coding
style of this project, we need to have a consistent baseline.
This consistency pass also gets rid of all the tabs, so we have that
going for us.
|
| |
|
|
|
|
|
| |
The code has long since gone, we can finally remove the enumeration
member from GWeatherProvider.
|
|
|
|
|
|
|
|
| |
It's deprecated, and replaced by GWeather.Location.next_child.
The tricky bit is to take into account that next_child() will consume
the passed location, which means we need to add a reference if we're
keeping the GWeatherLocation around.
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're now at 4.0. The version bump requires some additional changes:
- the project version is 3.90, while we are in a development cycle
- the main gettext domain has been changed to libgweather-4.0
- the gettext domain for the locations has been changed to
libgweather-4.0-locations
- the settings schemas have been changed to org.gnome.GWeather4
- the soname of the shared library has been changed to match the
versioning scheme used by GLib and GTK
|
|
We should write tests and tools that look like tests in the same way
we'd write code that depends on the library, instead of assuming that
everything works out because it sits in the same directory.
|