| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
| |
Else the user could close the connection window and the dialog still referring
to it would make the editor crash.
Top level window fixed up by dcbw:
The widget may not be in a window at page init time, but is when the widget
is realized. Get the toplevel parent at realize time.
|
| |
|
|
|
|
|
|
|
|
| |
"response" signal is sufficient. It is issued for dialog closing too (Cancel,
Esc, Alt-F4, ...).
Trying to destroy dialog as a response to "close" signal caused:
GLib-GObject-CRITICAL **: g_object_ref: assertion `G_IS_OBJECT (object)' failed
|
| |
|
|\
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=708245
|
| |
| |
| |
| |
| |
| | |
Compatible slaves:
- InfiniBand
- ethernet, Wi-Fi, VLAN
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
and allow importing the config from a file.
libteam configuration is a string that can be quite long, and simple GEntry is
not much appropriate for it. This commit uses GTextView instead, so that
structured multiline JSON config can be typed. In addition to that, the import
button allows selecting a file whose content will be imported as the config
text.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The previous algorithm for choosing the team_num is not deterministic.
It does neither choose one of
(a) MAX(existing team_nums) + 1
(b) MIN(unused team_nums)
What it actually chooses depends on the order how the existing
connections are returned. For example:
[0 2] => 1
[2 0] => 3
Change it to use (a).
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
| | |
|
| | |
|
|/
|
|
| |
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The user cannot input a %scope-id in this field because this parameter
would be ignored anyway. NetworkManager automatically scopes link-local
addresses to the connecting device.
https://bugzilla.redhat.com/show_bug.cgi?id=962449
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do not allow to input unexpected (ascii) characters as DNS servers,
both for IPv4 and IPv6.
This especially disallows to add a %scope-id suffix for IPv6 link-local
addresses (because '%' is not allowed). The reason to disallow this is
that link-local addresses are always scoped to the connecting device
anyway, so this parameter would get ignored anyway.
This is related to bug
https://bugzilla.redhat.com/show_bug.cgi?id=962449
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some GtkEntry only allow certain characters. This code was duplicated
over several places. Refactor them and add a function
utils_filter_editable_on_insert_text to implement the filtering.
This also fixes some minor hitches:
- at some places, the is<type> functions from ctype.h were used. These
functions behave differently depending on the locale, but we ~really~
want to check for ASCII characters (in the UTF-8) string.
- at several places, the allocated memory for `result` did not include
the terminating zero caracter. This was not a real bug, because
gtk_editable_insert_text was called with the `count` parameter and
nowhere the terminating zero was actually needed.
- adjust the signature of the *_filter_cb functions to the insert-text
signal.
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
|
|
|
|
|
|
| |
The return value of gtk_editable_get_chars is owned by the caller, so
calling g_strdup leaks memory.
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Due to a typo, the created setting contained wrong fields for
IP4 and IP6.
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous algorithm for choosing bond_num/bridge_num is not deterministic.
It does neither choose one of
(a) MAX(existing nums) + 1
(b) MIN(unused nums)
What it actually chooses depends on the order how the existing
connections are returned. For example:
[0 2] => 1
[2 0] => 3
This commit changes the algorithm to use (a).
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
|
|
|
|
|
|
| |
The values were removed from the allowed 'pairwise' property values by
5f61594585b22cdb72ee5279de5a8d9e86b125cf commit.
Anyway, both 'pairwise' and 'group' property (ciphers) are only valid for WPA.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
inner_auth_combo_changed_cb():
model = gtk_combo_box_get_model (GTK_COMBO_BOX (combo));
gtk_combo_box_get_active_iter (GTK_COMBO_BOX (combo), &iter);
gtk_tree_model_get (model, &iter, I_METHOD_COLUMN, &eap, -1);
g_assert (eap);
gtk_combo_box_get_model() failed and thus g_assert (eap) failed as well.
On some circumstances type_id resets to 0 in eap_method_get_g_type(). It makes
g_boxed_type_register_static() be called again, which results in failing
assertion 'g_type_form_name (name) == 0' and thus eap_method_get_g_type()
returns 0 instead of proper GType. Later using 0 make gtk_list_store_new()
fail to get proper GListStore:
inner_auth_combo_init:
auth_model = gtk_list_store_new (2, G_TYPE_STRING, eap_method_get_type ())
Even if this patch is right, the problem is not solved, because instead of
the crash a deadlock may occur. It might be the same issue as described in
https://bugzilla.gnome.org/show_bug.cgi?id=674885.
https://bugzilla.redhat.com/show_bug.cgi?id=979123
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
eap_method_init/wireless_security_init
When 'eap_method_init' or 'wireless_security_init' fails to read the
UI xml file, it calls 'eap_method_unref' or 'wireless_security_unref',
respectively. The unref methods call the destroy handler, but they
should not do it in this case, because the objects were not fully
constructed.
Fix this, be setting the destroy handler only at the end of
the init methods.
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
During destroy of the security dialogs EAPMethodSimple and
EAPMethodLEAP, the handlers are unsubscribed from the widget.
Remove the unsubscription of 'wireless_security_changed_cb', because
this function is actually never subscribed to the widget.
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
For a VLAN with "parent" set to an ifname, the editor was mistakenly
showing the parent as being whatever entry for that device came
alphabetically first in the popup menu (which I had never noticed
before because I didn't have any ethernet connection names that came
alphabetically before the MAC address of my ethernet card).
Also, fix the parent menu to always list ifname-based parents before
connection-uuid-based parents, and change the description of the
connection-based ones a bit.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the code would update GSettings whenever a security
input field changed and the provided security information had
to be re-validated. This meant the value would be saved even
if the user canceled editing of the connection. Fix this.
Unfortunately, since only the upper-level code knows when the
editing has been canceled, the upper-level code has to handle
reading the initial values, and saving the new ones. But that's
easy to do.
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The commit 3cae06120a4dd9bebd5f2e57e181ea95e87c8ac4 fixed the issue of
loading the username/password when editing a connection with EAP-PEAP or
EAP-TTLS (using EAPMethodSimple) or EAP-LEAP (using EAPMethodLEAP).
There was a small issue when you edited such a connection: when opening
the configuration dialog, the 'Apply' button was disabled until you switched
to the security tab.
The problem was, that in order to enable the 'Apply' button, 'validate' of
the security dialog will be called. 'validate' looks at the content of the UI
fields whether username and password are set. Due to a bug, they were
unset until 'widget_realize' was called, i.e. not before you switched to the
security tab the first time.
Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1000564
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
The security is identified by presence of 802-11-wireless-security setting.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
These functions were removed, which breakes gnome-control-center.
Restore the function definitions to fix it but let them return
dummy values.
As nma_wifi_dialog_nag_user most of the time returned NULL anyway
(to indicate "no nagging"), this dummy behaviour should not cause
any issues.
https://bugzilla.gnome.org/show_bug.cgi?id=706964
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the wifi security dialog, when you set the "always ask" checkbox, the
password will be cleared. Remember the previous password and restore it when
you uncheck the box again.
This has the effect, that you can toggle this checkbox and don't have to
reenter the password.
This only works, as long as you don't change the "Security",
"Authentication" or "Inner authentication" type. This is
intentionally not to expose the password by accident.
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
When you opened an existing wifi in nm-connection-editor, the username
and password field were unset for WPA & WPA2 Enterprise.
(This regression was introduced by commit c9476e9c07839e71aed49e820e364ad0b9f47039)
https://bugzilla.redhat.com/show_bug.cgi?id=1000564
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
| |
|
| |
|
| |
|