diff options
author | Bastien Nocera <hadess@hadess.net> | 2022-06-20 16:10:55 +0200 |
---|---|---|
committer | Bastien Nocera <hadess@hadess.net> | 2022-06-20 16:15:43 +0200 |
commit | e4dc32648883e0459518d59a10d8d174afa5dae4 (patch) | |
tree | 6ec1c4cf3c7cbf952925d974a4535ad4f10bbcb3 /NEWS | |
parent | 28313b1d75676d6653c4ebff566d0425fe1053b4 (diff) | |
download | totem-pl-parser-e4dc32648883e0459518d59a10d8d174afa5dae4.tar.gz |
plparser: Fix return value from cancelled calls
As per the API documentation, and the code when it still used
g_simple_async_result_*, totem_pl_parser_parse_finish() should return a
TotemPlParserResult of TOTEM_PL_PARSER_RESULT_CANCELLED when parsing is
cancelled.
But the port to GTask changed that, as all the errors caught during
parsing would return -1 as the error code, which isn't a valid
TotemPlParserResult value.
As the only way for totem_pl_parser_parse_finish() to have a GError set
is for the call to be cancelled, catch that and correct the return
value.
Fixes: 45664037 ("plparse: Port from GSimpleAsyncResult to GTask")
Closes: #38
Diffstat (limited to 'NEWS')
0 files changed, 0 insertions, 0 deletions