diff options
-rwxr-xr-x | .ci/check-abi | 121 | ||||
-rw-r--r-- | .gitlab-ci.yml | 7 |
2 files changed, 4 insertions, 124 deletions
diff --git a/.ci/check-abi b/.ci/check-abi deleted file mode 100755 index 8d3e0e9..0000000 --- a/.ci/check-abi +++ /dev/null @@ -1,121 +0,0 @@ -#!/usr/bin/python3 - - -import argparse -import contextlib -import os -import shutil -import subprocess -import sys - - -def format_title(title): - box = { - 'tl': '╔', 'tr': '╗', 'bl': '╚', 'br': '╝', 'h': '═', 'v': '║', - } - hline = box['h'] * (len(title) + 2) - - return '\n'.join([ - f"{box['tl']}{hline}{box['tr']}", - f"{box['v']} {title} {box['v']}", - f"{box['bl']}{hline}{box['br']}", - ]) - - -def rm_rf(path): - try: - shutil.rmtree(path) - except FileNotFoundError: - pass - - -def sanitize_path(name): - return name.replace('/', '-') - - -def get_current_revision(): - revision = subprocess.check_output(['git', 'rev-parse', '--abbrev-ref', 'HEAD'], - encoding='utf-8').strip() - - if revision == 'HEAD': - # This is a detached HEAD, get the commit hash - revision = subprocess.check_output(['git', 'rev-parse', 'HEAD']).strip().decode('utf-8') - - return revision - - -@contextlib.contextmanager -def checkout_git_revision(revision): - current_revision = get_current_revision() - subprocess.check_call(['git', 'checkout', '-q', revision]) - - try: - yield - finally: - subprocess.check_call(['git', 'checkout', '-q', current_revision]) - - -def build_install(revision): - build_dir = '_build' - dest_dir = os.path.abspath(sanitize_path(revision)) - print(format_title(f'# Building and installing {revision} in {dest_dir}'), - end='\n\n', flush=True) - - with checkout_git_revision(revision): - rm_rf(build_dir) - rm_rf(revision) - - subprocess.check_call(['meson', build_dir, - '--prefix=/usr', '--libdir=lib', - '-Db_coverage=false', '-Dgtkdoc=false', '-Dtests=false']) - subprocess.check_call(['ninja', '-v', '-C', build_dir]) - subprocess.check_call(['ninja', '-v', '-C', build_dir, 'install'], - env={'DESTDIR': dest_dir}) - - return dest_dir - - -def compare(old_tree, new_tree): - print(format_title(f'# Comparing the two ABIs'), end='\n\n', flush=True) - - old_headers = os.path.join(old_tree, 'usr', 'include') - old_lib = os.path.join(old_tree, 'usr', 'lib', 'libtotem-plparser.so') - - new_headers = os.path.join(new_tree, 'usr', 'include') - new_lib = os.path.join(new_tree, 'usr', 'lib', 'libtotem-plparser.so') - - subprocess.check_call([ - 'abidiff', '--headers-dir1', old_headers, '--headers-dir2', new_headers, - '--drop-private-types', '--fail-no-debug-info', '--no-added-syms', old_lib, new_lib]) - - old_lib = os.path.join(old_tree, 'usr', 'lib', 'libtotem-plparser-mini.so') - new_lib = os.path.join(new_tree, 'usr', 'lib', 'libtotem-plparser-mini.so') - - subprocess.check_call([ - 'abidiff', '--headers-dir1', old_headers, '--headers-dir2', new_headers, - '--drop-private-types', '--fail-no-debug-info', '--no-added-syms', old_lib, new_lib]) - - -if __name__ == '__main__': - parser = argparse.ArgumentParser() - - parser.add_argument('old', help='the previous revision, considered the reference') - parser.add_argument('new', help='the new revision, to compare to the reference') - - args = parser.parse_args() - - if args.old == args.new: - print("Let's not waste time comparing something to itself") - sys.exit(0) - - old_tree = build_install(args.old) - new_tree = build_install(args.new) - - try: - compare(old_tree, new_tree) - - except Exception as e: - print ('ABI comparison failed: '+ str(e)) - sys.exit(1) - - print(f'Hurray! {args.old} and {args.new} are ABI-compatible!') diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 336ad49..d9d14e5 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,7 +1,7 @@ variables: DEPENDENCIES: redhat-rpm-config meson git gettext gtk-doc meson glib2-devel libxml2-devel gobject-introspection-devel libgcrypt-devel libarchive-devel uchardet-devel DEPS_QUVI: libquvi-devel - DEPS_ABI_CHECK: libabigail libsoup-devel gmime-devel + DEPS_ABI_CHECK: libsoup-devel gmime-devel TEST_DEPS: gvfs dbus-daemon shared-mime-info LAST_ABI_BREAK: "9ccc3c78a5a41b86bdd2c9fb63ad4963e65e4f63" @@ -21,6 +21,7 @@ build-fedora: - meson _build - GIO_USE_VOLUME_MONITOR=unix dbus-run-session ninja -C _build test - ninja -C _build install - # ABI check + # ABI check, the deps are needed to build the old version of totem-pl-parser + - curl https://gitlab.freedesktop.org/hadess/check-abi/-/raw/main/contrib/check-abi-fedora.sh | bash - dnf install -y $DEPS_ABI_CHECK - - ./.ci/check-abi ${LAST_ABI_BREAK} $(git rev-parse HEAD) + - check-abi ${LAST_ABI_BREAK} $(git rev-parse HEAD) |