diff options
| author | Hunor Csomortáni <csomh@redhat.com> | 2022-12-02 16:05:22 +0100 |
|---|---|---|
| committer | Carlos Garnacho <carlosg@gnome.org> | 2022-12-07 12:29:23 +0100 |
| commit | d37b4a637eb364a42b7eceaaf208e76a791ccf43 (patch) | |
| tree | 2f1284b9db082c2ccec46ec21c352564038bc241 /src | |
| parent | 655deba98917d2ff4498eda261861112d6c1d672 (diff) | |
| download | tracker-d37b4a637eb364a42b7eceaaf208e76a791ccf43.tar.gz | |
check-style: Use run() instead of Popen()
The Python docs recommends using run() for all use-cases it can handle:
https://docs.python.org/3/library/subprocess.html#using-the-subprocess-module
run() waits for the subprocess started to complete, so it's not
necessary to use wait() and communicate() anymore. This simplifies the
script.
Previously running "check-style.py -r" after each commit in an
interactive rebase failed, b/c the script did not wait for the amend
command to complete. Using run() instead of Popen() solves this issue.
Diffstat (limited to 'src')
0 files changed, 0 insertions, 0 deletions