diff options
author | Carlos Garnacho <carlosg@gnome.org> | 2022-05-07 15:49:27 +0200 |
---|---|---|
committer | Carlos Garnacho <carlosg@gnome.org> | 2022-05-09 12:24:53 +0200 |
commit | 30b661988fbdf0739e44cc8b880fe0985af961a6 (patch) | |
tree | 8013233c28f206fa0c9f081235853bce10a8555c /tests | |
parent | 5cb6aa618be102d5598bdbbb3a923328495d9cbc (diff) | |
download | tracker-30b661988fbdf0739e44cc8b880fe0985af961a6.tar.gz |
libtracker-sparql: Rewrite TrackerRemoteConnection
This very cathartic change rewrites the remote TrackerSparqlConnection
implementation from Vala to C, besides the additional boilerplate code
is pretty much 1:1 otherwise.
Indirectly fixes build errors when using tracker as a submodule (like
in tracker-miners CI) on some semi-recent Vala versions (e.g. the one
in F34), seen as:
subprojects/tracker/src/libtracker-sparql/libtracker-sparql-private.a.p/remote/tracker-remote.c:58:8: error: redefinition of 'struct _TrackerRemoteConnection'
58 | struct _TrackerRemoteConnection {
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from subprojects/tracker/src/libtracker-sparql/libtracker-sparql-private.a.p/remote/tracker-remote.c:34:
subprojects/tracker/src/libtracker-sparql/tracker-sparql-private.h:88:8: note: originally defined here
88 | struct _TrackerRemoteConnection {
| ^~~~~~~~~~~~~~~~~~~~~~~~
Where both tracker-remote.c and tracker-sparql-private.h here are
files generated by Vala, and the latter should have no struct
definitions.
But this also reduces on symbols that Vala unintendedly makes
public behind our back (through VALA_EXTERN).
Closes: https://gitlab.gnome.org/GNOME/tracker-miners/-/issues/220
Diffstat (limited to 'tests')
0 files changed, 0 insertions, 0 deletions