Merge branch 'make_ontology_parsing_warnings_clearer' into 'master'

Track current line and column numbers and handle missing prefix error

See merge request GNOME/tracker!447

9 files changed, 206 insertions, 0 deletions

diff --git a/tests/functional-tests/test-data/test-movie.ttl b/tests/functional-tests/test-data/test-movie.ttl
index e7a3a3303..8c787a6fc 100644
--- a/tests/functional-tests/test-data/test-movie.ttl
+++ b/tests/functional-tests/test-data/test-movie.ttl
@@ -1,6 +1,7 @@
 @prefix nmm: <http://tracker.api.gnome.org/ontology/v3/nmm#> .
 @prefix nfo: <http://tracker.api.gnome.org/ontology/v3/nfo#> .
 @prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
+@prefix nie: <http://tracker.api.gnome.org/ontology/v3/nie#> .
 
 _:3 a nfo:FileHash ;
   nfo:hashValue "123456789ABC" ;
diff --git a/tests/libtracker-data/meson.build b/tests/libtracker-data/meson.build
index 3ba1ddf5e..c39b69838 100644
--- a/tests/libtracker-data/meson.build
+++ b/tests/libtracker-data/meson.build
@@ -5,6 +5,7 @@ data_test_c_args = test_c_args + [
 libtracker_data_tests = [
     'crc32',
     'ontology-change',
+    'ontology-error',
     'sparql-blank',
     'insert-or-replace',
     'service',
diff --git a/tests/libtracker-data/ontology-error/unknown-prefix-001.ontology b/tests/libtracker-data/ontology-error/unknown-prefix-001.ontology
new file mode 100644
index 000000000..fdcd415a7
--- /dev/null
+++ b/tests/libtracker-data/ontology-error/unknown-prefix-001.ontology
@@ -0,0 +1,17 @@
+@prefix example: <http://example/> .
+@prefix nrl: <http://tracker.api.gnome.org/ontology/v3/nrl#> .
+@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
+@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
+@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+@prefix nrl: <http://tracker.api.gnome.org/ontology/v3/nrl#> .
+
+example: a nrl:Namespace ;
+	nrl:prefix "example" .
+
+example:A a Rdfs:Class ; # should be rdfs:Class
+	rdfs:subClassOf rdfs:Resource .
+
+example:int a rdf:Property ;
+	nrl:maxCardinality 1 ;
+	rdfs:domain example:A ;
+	rdfs:range xsd:integer .
diff --git a/tests/libtracker-data/ontology-error/unknown-prefix-001.out b/tests/libtracker-data/ontology-error/unknown-prefix-001.out
new file mode 100644
index 000000000..a11d1da6b
--- /dev/null
+++ b/tests/libtracker-data/ontology-error/unknown-prefix-001.out
@@ -0,0 +1 @@
+Unknown prefix Rdfs:Class at line 11, column 13
\ No newline at end of file
diff --git a/tests/libtracker-data/ontology-error/unknown-prefix-002.ontology b/tests/libtracker-data/ontology-error/unknown-prefix-002.ontology
new file mode 100644
index 000000000..e9c6b8782
--- /dev/null
+++ b/tests/libtracker-data/ontology-error/unknown-prefix-002.ontology
@@ -0,0 +1,22 @@
+@prefix example: <http://example/> .
+@prefix nrl: <http://tracker.api.gnome.org/ontology/v3/nrl#> .
+@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
+@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
+@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+@prefix nrl: <http://tracker.api.gnome.org/ontology/v3/nrl#> .
+
+example: a nrl:Namespace ;
+	nrl:prefix "example" .
+
+example:A a rdfs:Class ;
+	rdfs:subClassOf
+	rdfs:Resource .
+
+example:int a rdf:Property ;
+
+# First column is considered as column 1
+nrls:maxCardinality # should be nrl:maxCardinality
+
+	1 ;
+	rdfs:domain example:A ;
+	rdfs:range xsd:integer .
diff --git a/tests/libtracker-data/ontology-error/unknown-prefix-002.out b/tests/libtracker-data/ontology-error/unknown-prefix-002.out
new file mode 100644
index 000000000..fd42b2ecc
--- /dev/null
+++ b/tests/libtracker-data/ontology-error/unknown-prefix-002.out
@@ -0,0 +1 @@
+Unknown prefix nrls:maxCardinality at line 18, column 1
\ No newline at end of file
diff --git a/tests/libtracker-data/ontology-error/unknown-prefix-003.ontology b/tests/libtracker-data/ontology-error/unknown-prefix-003.ontology
new file mode 100644
index 000000000..012ca1dbf
--- /dev/null
+++ b/tests/libtracker-data/ontology-error/unknown-prefix-003.ontology
@@ -0,0 +1,20 @@
+@prefix example: <http://example/> .
+@prefix nrl: <http://tracker.api.gnome.org/ontology/v3/nrl#> .
+@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
+@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
+@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+@prefix nrl: <http://tracker.api.gnome.org/ontology/v3/nrl#> .
+
+
+# Mix of spaces and tabs, it should count the tab as one character the same as the space
+		  Example:  #should be example:
+	a nrl:Namespace ;
+	nrl:prefix "example" .
+
+example:A a Rdfs:Class ; # should be rdfs:Class
+	rdfs:subClassOf rdfs:Resource .
+
+example:int a rdf:Property ;
+	nrl:maxCardinality 1 ;
+	rdfs:domain example:A ;
+	rdfs:range xsd:integer .
diff --git a/tests/libtracker-data/ontology-error/unknown-prefix-003.out b/tests/libtracker-data/ontology-error/unknown-prefix-003.out
new file mode 100644
index 000000000..3283fdcf8
--- /dev/null
+++ b/tests/libtracker-data/ontology-error/unknown-prefix-003.out
@@ -0,0 +1 @@
+Unknown prefix Example: at line 10, column 5
\ No newline at end of file
diff --git a/tests/libtracker-data/tracker-ontology-error-test.c b/tests/libtracker-data/tracker-ontology-error-test.c
new file mode 100644
index 000000000..0a147ed90
--- /dev/null
+++ b/tests/libtracker-data/tracker-ontology-error-test.c
@@ -0,0 +1,142 @@
+/*
+ * Copyright (C) 2021, Abanoub Ghadban <abanoub.gdb@gmail.com>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA  02110-1301, USA.
+ */
+
+#include "config.h"
+
+#include <string.h>
+#include <locale.h>
+
+#include <glib/gstdio.h>
+#include <gio/gio.h>
+
+#include <libtracker-common/tracker-common.h>
+
+#include <libtracker-data/tracker-data.h>
+
+typedef struct _TestInfo TestInfo;
+
+struct _TestInfo {
+	const gchar *test_name;
+};
+
+const TestInfo tests[] = {
+	{ "ontology-error/unknown-prefix-001" },
+	{ "ontology-error/unknown-prefix-002" },
+	{ "ontology-error/unknown-prefix-003" },
+	{ NULL }
+};
+
+static void
+ontology_error_helper (GFile *ontology_location, char *error_path)
+{
+	TrackerDataManager *manager;
+	gchar *error_msg = NULL;
+	GError* error = NULL;
+	GError* ontology_error = NULL;
+
+	manager = tracker_data_manager_new (TRACKER_DB_MANAGER_IN_MEMORY,
+	                                    NULL, ontology_location,
+	                                    100, 100);
+	g_initable_init (G_INITABLE (manager), NULL, &ontology_error);
+	g_assert_true (ontology_error != NULL);
+
+	g_file_get_contents (error_path, &error_msg, NULL, &error);
+	g_assert_no_error (error);
+	g_assert_cmpstr (ontology_error->message, ==, error_msg);
+
+	g_error_free (ontology_error);
+	g_free (error_msg);
+	g_object_unref (manager);
+}
+
+static void
+test_ontology_error (void)
+{
+	gchar *test_ontology_path;
+	gchar *test_ontology_dir;
+	gchar *prefix, *build_prefix;
+	guint i;
+	GError *error = NULL;
+	GFile *test_ontology_file;
+	GFile *test_schemas;
+
+	prefix = g_build_path (G_DIR_SEPARATOR_S, TOP_SRCDIR, "tests", "libtracker-data", NULL);
+	build_prefix = g_build_path (G_DIR_SEPARATOR_S, TOP_BUILDDIR, "tests", "libtracker-data", NULL);
+
+	// Create a temporary directory inside the build directory to store in it the ontology that will be tested
+	test_ontology_dir = g_build_path (G_DIR_SEPARATOR_S, build_prefix, "ontology-error", "ontologies", NULL);
+	g_mkdir_with_parents (test_ontology_dir, 0777);
+	test_schemas = g_file_new_for_path (test_ontology_dir);
+
+	test_ontology_path = g_build_path (G_DIR_SEPARATOR_S, test_ontology_dir, "test.ontology", NULL);
+	test_ontology_file = g_file_new_for_path (test_ontology_path);
+	g_file_delete (test_ontology_file, NULL, NULL);
+	g_free (test_ontology_dir);
+
+	for (i = 0; tests[i].test_name; i++) {
+		GFile *source_ontology_file;
+		gchar *source_ontology_filename = g_strconcat (tests[i].test_name, ".ontology", NULL);
+		gchar *source_ontology_path = g_build_path (G_DIR_SEPARATOR_S, prefix, source_ontology_filename, NULL);
+		gchar *error_filename = g_strconcat (tests[i].test_name, ".out", NULL);
+		gchar *error_path = g_build_path (G_DIR_SEPARATOR_S, prefix, error_filename, NULL);
+		gchar *from, *to;
+
+		source_ontology_file = g_file_new_for_path (source_ontology_path);
+
+		from = g_file_get_path (source_ontology_file);
+		to = g_file_get_path (test_ontology_file);
+		g_debug ("copy %s to %s", from, to);
+		g_free (from);
+		g_free (to);
+
+		// Copy the ontology to the temporary ontologies directory
+		g_file_copy (source_ontology_file, test_ontology_file, G_FILE_COPY_OVERWRITE, NULL, NULL, NULL, &error);
+
+		g_assert_no_error (error);
+		g_assert_cmpint (g_chmod (test_ontology_path, 0666), ==, 0);
+
+		ontology_error_helper (test_schemas, error_path);
+
+		g_free (source_ontology_filename);
+		g_free (source_ontology_path);
+		g_free (error_filename);
+		g_free (error_path);
+		g_object_unref (source_ontology_file);
+	}
+
+	g_file_delete (test_ontology_file, NULL, NULL);
+	g_object_unref (test_ontology_file);
+	g_object_unref (test_schemas);
+	g_free (build_prefix);
+	g_free (prefix);
+	g_free (test_ontology_path);
+}
+
+int
+main (int argc, char **argv)
+{
+	gint result;
+
+	g_test_init (&argc, &argv, NULL);
+
+	g_test_add_func ("/libtracker-data/ontology-error", test_ontology_error);
+	result = g_test_run ();
+
+	return result;
+}