summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBruno Haible <bruno@clisp.org>2019-06-30 14:48:50 +0200
committerBruno Haible <bruno@clisp.org>2019-06-30 14:48:50 +0200
commit1d56a7919af2bbf9245e9c55cd9458d88887dae6 (patch)
treee76651a21dc4c7d6c36f08c487c67aca0801c17a
parenta734086a9b2783d74f01f8f5ac10d7b601c07120 (diff)
downloadgnulib-1d56a7919af2bbf9245e9c55cd9458d88887dae6.tar.gz
poll: Add comment.
* lib/poll.c: Add comment about WSAPoll.
-rw-r--r--ChangeLog5
-rw-r--r--lib/poll.c7
2 files changed, 12 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 6fe1531a04..cd60fe7fe3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
2019-06-30 Bruno Haible <bruno@clisp.org>
+ poll: Add comment.
+ * lib/poll.c: Add comment about WSAPoll.
+
+2019-06-30 Bruno Haible <bruno@clisp.org>
+
poll-h: Fix compilation error on mingw with _WIN32_WINNT >= 0x0600.
Reported by Hannes Müller <h.c.f.mueller@gmx.de>.
* lib/poll.in.h: Include <winsock2.h>.
diff --git a/lib/poll.c b/lib/poll.c
index f6de24c793..5d9150c13a 100644
--- a/lib/poll.c
+++ b/lib/poll.c
@@ -76,6 +76,13 @@
#ifdef WINDOWS_NATIVE
+/* Do *not* use the function WSAPoll
+ <https://docs.microsoft.com/en-us/windows/desktop/api/winsock2/nf-winsock2-wsapoll>
+ because there is a bug named “Windows 8 Bugs 309411 - WSAPoll does not
+ report failed connections” that Microsoft won't fix.
+ See Daniel Stenberg: "WASPoll is broken"
+ <https://daniel.haxx.se/blog/2012/10/10/wsapoll-is-broken/>. */
+
/* Here we need the recv() function from Windows, that takes a SOCKET as
first argument, not any possible gnulib override. */
# undef recv