summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJim Meyering <meyering@redhat.com>2010-09-04 12:45:22 +0200
committerJim Meyering <meyering@redhat.com>2010-09-04 13:41:35 +0200
commit3a8a76d5b33b734ebd2b6436c00b6770e1112e19 (patch)
treeb9c378f742cd7577dca25050ee9168172e9578fc
parentc7ddffce1ea4383928922b3bfb4f1c022f3158ce (diff)
downloadgnulib-3a8a76d5b33b734ebd2b6436c00b6770e1112e19.tar.gz
tests: prohibit augmenting PATH via TESTS_ENVIRONMENT
* Makefile (sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT): New rule.
-rw-r--r--ChangeLog5
-rw-r--r--Makefile12
2 files changed, 16 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index 1755e4d5d3..fbc77f1323 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2010-09-04 Jim Meyering <meyering@redhat.com>
+
+ tests: prohibit augmenting PATH via TESTS_ENVIRONMENT
+ * Makefile (sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT): New rule.
+
2010-09-04 Bruno Haible <bruno@clisp.org>
strdup: Fix compilation error in C++ mode.
diff --git a/Makefile b/Makefile
index 0596ba6a57..345e3028a3 100644
--- a/Makefile
+++ b/Makefile
@@ -13,7 +13,9 @@ info html dvi pdf:
cd doc && $(MAKE) $@ && $(MAKE) mostlyclean
# Perform some platform independent checks on the gnulib code.
-check: sc_prefer_ac_check_funcs_once
+check: \
+ sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT \
+ sc_prefer_ac_check_funcs_once
sc_prefer_ac_check_funcs_once:
if test -d .git; then \
@@ -22,6 +24,14 @@ sc_prefer_ac_check_funcs_once:
in modules/ 1>&2; exit 1; } || : \
else :; fi
+sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT:
+ if test -d .git; then \
+ url=http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/22874; \
+ git grep '^[ ]*TESTS_ENVIRONMENT += PATH=' modules \
+ && { printf '%s\n' 'Do not augment PATH via TESTS_ENVIRONMENT;' \
+ " see <$$url>" 1>&2; exit 1; } || : \
+ else :; fi
+
# Regenerate some files that are stored in the repository.
regen: MODULES.html