diff options
| author | Paul Eggert <eggert@cs.ucla.edu> | 2012-08-27 23:11:45 -0700 |
|---|---|---|
| committer | Paul Eggert <eggert@cs.ucla.edu> | 2012-09-22 01:58:22 -0700 |
| commit | a267084c257281d28b35319f6b56b75f2777a493 (patch) | |
| tree | 58dd2d0d14ff3541b5e5a533146496364bee67ef | |
| parent | 216e340ed6ef2c0882911d351aa7c3703b347613 (diff) | |
| download | gnulib-a267084c257281d28b35319f6b56b75f2777a493.tar.gz | |
utimens-tests: avoid unnecessary 'inline'
* modules/fdutimensat-tests (configure.ac):
* modules/futimens-tests (configure.ac):
* modules/utimens-tests (configure.ac):
* modules/utimensat-tests (configure.ac):
Remove AC_C_INLINE.
* tests/test-utimens-common.h (ctime_compare):
No longer inline. Simplicity and portability trump efficiency here.
| -rw-r--r-- | ChangeLog | 9 | ||||
| -rw-r--r-- | modules/fdutimensat-tests | 1 | ||||
| -rw-r--r-- | modules/futimens-tests | 1 | ||||
| -rw-r--r-- | modules/utimens-tests | 1 | ||||
| -rw-r--r-- | modules/utimensat-tests | 1 | ||||
| -rw-r--r-- | tests/test-utimens-common.h | 2 |
6 files changed, 10 insertions, 5 deletions
@@ -1,5 +1,14 @@ 2012-09-22 Paul Eggert <eggert@cs.ucla.edu> + utimens-tests: avoid unnecessary 'inline' + * modules/fdutimensat-tests (configure.ac): + * modules/futimens-tests (configure.ac): + * modules/utimens-tests (configure.ac): + * modules/utimensat-tests (configure.ac): + Remove AC_C_INLINE. + * tests/test-utimens-common.h (ctime_compare): + No longer inline. Simplicity and portability trump efficiency here. + misc: don't limit commentary to inline functions * lib/binary-io.h, lib/malloca.h, lib/safe-alloc.c: * lib/xalloc-oversized.h, lib/xsize.h: diff --git a/modules/fdutimensat-tests b/modules/fdutimensat-tests index c4dc5af604..9e3e77979a 100644 --- a/modules/fdutimensat-tests +++ b/modules/fdutimensat-tests @@ -17,7 +17,6 @@ usleep utimecmp configure.ac: -AC_REQUIRE([AC_C_INLINE]) Makefile.am: TESTS += test-fdutimensat diff --git a/modules/futimens-tests b/modules/futimens-tests index 1b72de5130..ff9801961e 100644 --- a/modules/futimens-tests +++ b/modules/futimens-tests @@ -15,7 +15,6 @@ usleep utimecmp configure.ac: -AC_REQUIRE([AC_C_INLINE]) Makefile.am: TESTS += test-futimens diff --git a/modules/utimens-tests b/modules/utimens-tests index 802d8e51d1..4d5d1f576a 100644 --- a/modules/utimens-tests +++ b/modules/utimens-tests @@ -16,7 +16,6 @@ usleep utimecmp configure.ac: -AC_REQUIRE([AC_C_INLINE]) Makefile.am: TESTS += test-utimens diff --git a/modules/utimensat-tests b/modules/utimensat-tests index ec426bbcd6..6acfe89ad6 100644 --- a/modules/utimensat-tests +++ b/modules/utimensat-tests @@ -14,7 +14,6 @@ usleep utimecmp configure.ac: -AC_REQUIRE([AC_C_INLINE]) Makefile.am: TESTS += test-utimensat diff --git a/tests/test-utimens-common.h b/tests/test-utimens-common.h index d1fb0f4121..6fe8465b71 100644 --- a/tests/test-utimens-common.h +++ b/tests/test-utimens-common.h @@ -59,7 +59,7 @@ enum { /* Compare two st_ctime values. Return -1, 0 or 1, respectively when A's st_ctime is smaller than, equal to or greater than B's. */ -static inline int +static int ctime_compare (struct stat const *a, struct stat const *b) { if (a->st_ctime < b->st_ctime) |