system-quote: Fix memory overrun bug on native Windows.

* lib/system-quote.c (system_quote): Allocate enough space for the
result.

2 files changed, 7 insertions, 1 deletions

diff --git a/ChangeLog b/ChangeLog
index e9c911de8f..a49d18a10e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2023-04-24  Bruno Haible  <bruno@clisp.org>
 
+	system-quote: Fix memory overrun bug on native Windows.
+	* lib/system-quote.c (system_quote): Allocate enough space for the
+	result.
+
+2023-04-24  Bruno Haible  <bruno@clisp.org>
+
 	unicodeio tests: Avoid test failures on native Windows.
 	* tests/test-unicodeio.c: Include localcharset.h.
 	(main): Handle C locales whose encoding is CP1252 or similar.
diff --git a/lib/system-quote.c b/lib/system-quote.c
index c08d2dcd53..54e891d98e 100644
--- a/lib/system-quote.c
+++ b/lib/system-quote.c
@@ -257,7 +257,7 @@ system_quote (enum system_command_interpreter interpreter,
     case SCI_SYSTEM:
     case SCI_WINDOWS_CMD:
       {
-        size_t length = system_quote_length (interpreter, string);
+        size_t length = system_quote_length (interpreter, string) + 1;
         char *quoted = XNMALLOC (length, char);
         system_quote_copy (quoted, interpreter, string);
         return quoted;