diff options
| author | Paul Eggert <eggert@cs.ucla.edu> | 2020-05-31 23:29:21 -0700 |
|---|---|---|
| committer | Paul Eggert <eggert@cs.ucla.edu> | 2020-05-31 23:30:39 -0700 |
| commit | e3c038e4c08d68cc3ca03cf0c3dc09c3182e216a (patch) | |
| tree | bc3b8caf3e94dfc25d83fc0b9215ae9785b628e8 /ChangeLog | |
| parent | 8f8da7c809b6908d074ac64c91d0cedfd4236f2e (diff) | |
| download | gnulib-e3c038e4c08d68cc3ca03cf0c3dc09c3182e216a.tar.gz | |
getrandom-tests: do not assume GRND_RANDOM yields short read
* tests/test-getrandom.c (main): Omit assertion that
getrandom (b, sizeof b, GRND_RANDOM | GRND_NONBLOCK) < sizeof b
when b’s size is 100000. This assertion fails with Linux kernel
5.6.13, as that kernel ignores the GRND_RANDOM flag.
The separate blocking pool is going away in the Linux kernel, and
they’ve added a flag GRND_INSECURE instead; see:
https://lore.kernel.org/linux-api/705c5a091b63cc5da70c99304bb97e0109be0a26.1577088521.git.luto@kernel.org/
The assertion was iffy anyway; what’s to prevent a kernel from
lazily filling a large buffer with random bytes?
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 11 |
1 files changed, 11 insertions, 0 deletions
@@ -1,5 +1,16 @@ 2020-05-31 Paul Eggert <eggert@cs.ucla.edu> + getrandom-tests: do not assume GRND_RANDOM yields short read + * tests/test-getrandom.c (main): Omit assertion that + getrandom (b, sizeof b, GRND_RANDOM | GRND_NONBLOCK) < sizeof b + when b’s size is 100000. This assertion fails with Linux kernel + 5.6.13, as that kernel ignores the GRND_RANDOM flag. + The separate blocking pool is going away in the Linux kernel, and + they’ve added a flag GRND_INSECURE instead; see: + https://lore.kernel.org/linux-api/705c5a091b63cc5da70c99304bb97e0109be0a26.1577088521.git.luto@kernel.org/ + The assertion was iffy anyway; what’s to prevent a kernel from + lazily filling a large buffer with random bytes? + read-file-test: pacify --enable-gcc-warnings * tests/test-read-file.c (test_read_file): Now static. |