diff options
author | Paul Eggert <eggert@cs.ucla.edu> | 2017-11-11 22:33:38 -0800 |
---|---|---|
committer | Paul Eggert <eggert@cs.ucla.edu> | 2017-11-11 22:34:01 -0800 |
commit | dd1890b79725d4a044039b476e6ad4592d2c9399 (patch) | |
tree | d59f823517dd232603a640391352681b04702344 /doc/posix-functions | |
parent | 6df7d4f6713faf89b5122ade350c6ae1acdee84d (diff) | |
download | gnulib-dd1890b79725d4a044039b476e6ad4592d2c9399.tar.gz |
faccessat: port to macOS (Bug#29231)
macOS faccessat has the same bug that lstat does: if the file
name ends in '/' it ignores the trailing slash.
Problem reported for Emacs by Vincent Zhang.
* doc/posix-functions/faccessat.texi (faccessat): Document this.
* lib/faccessat.c (_GL_INCLUDING_UNISTD_H): Define and undef
around the initial includes. Include errno.h, string.h, sys/stat.h.
(orig_faccessat) [HAVE_FACCESSAT]: New function.
Include "unistd.h" after defining it.
(rpl_faccessat) [HAVE_FACCESSAT]: New implementation.
* lib/unistd.in.h (faccessat) [REPLACE_FACCESSAT]:
Handle in the usual way.
* m4/faccessat.m4 (gl_FUNC_FACCESSAT): Replace faccessat if
lstat dereferences symlinks, since faccessat is likely to
have the same problem.
* m4/unistd_h.m4 (gl_UNISTD_H_DEFAULTS): Default REPLACE_ACCESSAT.
* modules/faccessat (Depends-on): Add fstatat.
Depend if REPLACE_FACCESSAT is 1, too.
(configure.ac): Link if REPLACE_FACCESSAT is 1.
* modules/faccessat-tests (Depends-on): Add symlink.
* modules/unistd (unistd.h): Substitute REPLACE_FACCESSAT.
* tests/test-faccessat.c (main): Test for the bug.
Diffstat (limited to 'doc/posix-functions')
-rw-r--r-- | doc/posix-functions/faccessat.texi | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/doc/posix-functions/faccessat.texi b/doc/posix-functions/faccessat.texi index 48ba17225f..19c2b1d653 100644 --- a/doc/posix-functions/faccessat.texi +++ b/doc/posix-functions/faccessat.texi @@ -13,6 +13,10 @@ This function is missing on some platforms: glibc 2.3.6, macOS 10.12, FreeBSD 7.4, NetBSD 6.1.5, OpenBSD 4.9, Minix 3.1.8, AIX 5.1, HP-UX 11, IRIX 6.5, OSF/1 5.1, Solaris 10, Cygwin 1.5.x, mingw, MSVC 14, Interix 3.5, BeOS. +@item +On some platforms, @code{faccessat (dfd, "file/", amode, flag)} +succeeds instead of failing when @file{file} is not a directory. +macOS 10.13. @end itemize Portability problems not fixed by Gnulib: |