diff options
| author | Darren Kenny <darren.kenny@oracle.com> | 2021-06-18 19:32:00 +0200 |
|---|---|---|
| committer | Bruno Haible <bruno@clisp.org> | 2021-06-18 19:33:35 +0200 |
| commit | fbcf84e542d5abad1f3fbdf4759874cf414946d5 (patch) | |
| tree | c4bfc4cb906d41dcfa2b5042bb3978f0c53418f7 /lib/argp-help.c | |
| parent | b50a7e59debf84b2ccacd5863a919bde6cb78075 (diff) | |
| download | gnulib-fbcf84e542d5abad1f3fbdf4759874cf414946d5.tar.gz | |
argp: Avoid possible NULL access in argp_help.
Reported by Coverity. The invocation chain is:
argp_help -> _help -> fill_in_uparams -> validate_uparams.
* lib/argp-help.c (validate_uparams): Don't crash if state == NULL.
Diffstat (limited to 'lib/argp-help.c')
| -rw-r--r-- | lib/argp-help.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/argp-help.c b/lib/argp-help.c index 4c89697bdd..80cdb44937 100644 --- a/lib/argp-help.c +++ b/lib/argp-help.c @@ -147,7 +147,8 @@ validate_uparams (const struct argp_state *state, struct uparams *upptr) if (*(int *)((char *)upptr + up->uparams_offs) >= upptr->rmargin) { __argp_failure (state, 0, 0, - dgettext (state->root_argp->argp_domain, + dgettext (state == NULL ? NULL + : state->root_argp->argp_domain, "\ ARGP_HELP_FMT: %s value is less than or equal to %s"), "rmargin", up->name); |