diff options
author | Bruno Haible <bruno@clisp.org> | 2021-01-05 05:22:54 +0100 |
---|---|---|
committer | Bruno Haible <bruno@clisp.org> | 2021-01-05 05:22:54 +0100 |
commit | 34b407ca1531ce91287d6bc14d5570909474abbf (patch) | |
tree | dd059f5594e9ca3a76f821ac5ae1d9e476ced125 /lib/link.c | |
parent | f120c3d08c0d8c2d0a743bf08dd876949f0edb75 (diff) | |
download | gnulib-34b407ca1531ce91287d6bc14d5570909474abbf.tar.gz |
link: Improve trailing slash handling on native Windows.
* lib/link.c (link): If stat() fails, provide a better errno.
Diffstat (limited to 'lib/link.c')
-rw-r--r-- | lib/link.c | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/lib/link.c b/lib/link.c index 87dae40796..21c7f7aed0 100644 --- a/lib/link.c +++ b/lib/link.c @@ -85,16 +85,24 @@ link (const char *file1, const char *file2) errno = EPERM; return -1; } - /* Reject trailing slashes on non-directories; mingw does not + /* Reject trailing slashes on non-directories; native Windows does not support hard-linking directories. */ if ((len1 && (file1[len1 - 1] == '/' || file1[len1 - 1] == '\\')) || (len2 && (file2[len2 - 1] == '/' || file2[len2 - 1] == '\\'))) { + /* If stat() fails, then link() should fail for the same reason. */ struct stat st; - if (stat (file1, &st) == 0 && S_ISDIR (st.st_mode)) - errno = EPERM; - else + if (stat (file1, &st)) + { + if (errno == EOVERFLOW) + /* It's surely a file, not a directory (see stat-w32.c). */ + errno = ENOTDIR; + return -1; + } + if (!S_ISDIR (st.st_mode)) errno = ENOTDIR; + else + errno = EPERM; return -1; } /* CreateHardLink("b/.","a",NULL) creates file "b", so we must check |