diff options
| author | Eric Blake <eblake@redhat.com> | 2011-06-20 16:55:24 -0600 |
|---|---|---|
| committer | Eric Blake <eblake@redhat.com> | 2011-06-22 14:55:57 -0600 |
| commit | dffc41f946b434d75be1289dbbc0509e9e843280 (patch) | |
| tree | 0b31890efafc53273906aba7a1e573f2b67c75c4 /lib/stat.c | |
| parent | df1c2344f29dbca57d9e560aaa89aa2c20cdda7f (diff) | |
| download | gnulib-dffc41f946b434d75be1289dbbc0509e9e843280.tar.gz | |
stat: be robust to PATH_MAX definition
Make this stack-allocation of PATH_MAX bytes more robust.
* lib/stat.c (rpl_stat): Require reasonable PATH_MAX.
* modules/stat (Depends-on): Add verify.
Signed-off-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'lib/stat.c')
| -rw-r--r-- | lib/stat.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/lib/stat.c b/lib/stat.c index cbc9100fd4..f07370dd06 100644 --- a/lib/stat.c +++ b/lib/stat.c @@ -38,6 +38,7 @@ orig_stat (const char *filename, struct stat *buf) #include <stdbool.h> #include <string.h> #include "dosname.h" +#include "verify.h" /* Store information about NAME into ST. Work around bugs with trailing slashes. Mingw has other bugs (such as st_ino always @@ -63,6 +64,12 @@ rpl_stat (char const *name, struct stat *st) } #endif /* REPLACE_FUNC_STAT_FILE */ #if REPLACE_FUNC_STAT_DIR + /* The only known systems where REPLACE_FUNC_STAT_DIR is needed also + have a constant PATH_MAX. */ +# ifndef PATH_MAX +# error "Please port this replacement to your platform" +# endif + if (result == -1 && errno == ENOENT) { /* Due to mingw's oddities, there are some directories (like @@ -77,6 +84,7 @@ rpl_stat (char const *name, struct stat *st) char fixed_name[PATH_MAX + 1] = {0}; size_t len = strlen (name); bool check_dir = false; + verify (PATH_MAX <= 4096); if (PATH_MAX <= len) errno = ENAMETOOLONG; else if (len) |