diff options
| author | Bruno Haible <bruno@clisp.org> | 2019-03-09 20:32:25 +0100 |
|---|---|---|
| committer | Bruno Haible <bruno@clisp.org> | 2019-03-09 20:32:25 +0100 |
| commit | 42254c0a96d69a5e107971343596cc0fd3e92149 (patch) | |
| tree | 882ea4952e10a66d013450333ff42e2d6a526cf7 /lib/xmemdup0.c | |
| parent | fa418ebbdf307d0efc1e61677045f48de5a93398 (diff) | |
| download | gnulib-42254c0a96d69a5e107971343596cc0fd3e92149.tar.gz | |
Fix undefined behaviour.
* lib/bitrotate.h (rotl16, rotr16, rotl8, rotr8): Case x to
'unsigned int', to avoid shift operations on 'int'.
* lib/xmemdup0.c (xmemdup0): Don't invoke memcpy with a zero size.
* tests/test-count-leading-zeros.c (main): Use a random number that has
as many bits as TYPE, not only 2*15 or 2*31 bits.
* tests/test-count-trailing-zeros.c (main): Likewise.
* tests/test-count-one-bits.c (main): Likewise.
* tests/test-memmem.c: Don't include "null-ptr.h".
(main): Use zerosize_ptr() instead of null_ptr().
* modules/memmem-tests (Files): Remove tests/null-ptr.h.
Diffstat (limited to 'lib/xmemdup0.c')
| -rw-r--r-- | lib/xmemdup0.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/xmemdup0.c b/lib/xmemdup0.c index 4f491be1b8..57c1b595e7 100644 --- a/lib/xmemdup0.c +++ b/lib/xmemdup0.c @@ -38,7 +38,8 @@ char * xmemdup0 (void const *p, size_t s) { char *result = xcharalloc (s + 1); - memcpy (result, p, s); + if (s > 0) + memcpy (result, p, s); result[s] = 0; return result; } |