diff options
| author | Bruno Haible <bruno@clisp.org> | 2019-01-25 03:54:09 +0100 |
|---|---|---|
| committer | Bruno Haible <bruno@clisp.org> | 2019-01-25 03:54:09 +0100 |
| commit | 9462eb64fbf6646e9109b003a6768538d2b7dad4 (patch) | |
| tree | 38804c4c852604cdd0b4c8aac8347747d30b5053 /m4 | |
| parent | 26653040b88fde1a98e6a7bbefc8f0bb0ff797fc (diff) | |
| download | gnulib-9462eb64fbf6646e9109b003a6768538d2b7dad4.tar.gz | |
memchr: Work around bug on Android <= 5.0.
* m4/memchr.m4 (gl_FUNC_MEMCHR): Add test against the Android bug.
* doc/posix-functions/memchr.texi: Mention the Android bug.
Diffstat (limited to 'm4')
| -rw-r--r-- | m4/memchr.m4 | 23 |
1 files changed, 18 insertions, 5 deletions
diff --git a/m4/memchr.m4 b/m4/memchr.m4 index db227e7de1..0be394db4f 100644 --- a/m4/memchr.m4 +++ b/m4/memchr.m4 @@ -1,4 +1,4 @@ -# memchr.m4 serial 13 +# memchr.m4 serial 14 dnl Copyright (C) 2002-2004, 2009-2019 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -29,6 +29,8 @@ AC_DEFUN_ONCE([gl_FUNC_MEMCHR], # memchr should not dereference overestimated length after a match # https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521737 # https://sourceware.org/bugzilla/show_bug.cgi?id=10162 + # memchr should cast the second argument to 'unsigned char'. + # This bug exists in Android 4.3. # Assume that memchr works on platforms that lack mprotect. AC_CACHE_CHECK([whether memchr works], [gl_cv_func_memchr_works], [AC_RUN_IFELSE([AC_LANG_PROGRAM([[ @@ -74,15 +76,26 @@ AC_DEFUN_ONCE([gl_FUNC_MEMCHR], if (memchr (fence - 1, 0, 3) != fence - 1) result |= 4; } + /* Test against bug on Android 4.3. */ + { + char input[3]; + input[0] = 'a'; + input[1] = 'b'; + input[2] = 'c'; + if (memchr (input, 0x789abc00 | 'b', 3) != input + 1) + result |= 8; + } return result; ]])], [gl_cv_func_memchr_works=yes], [gl_cv_func_memchr_works=no], [case "$host_os" in - # Guess yes on native Windows. - mingw*) gl_cv_func_memchr_works="guessing yes" ;; - # Be pessimistic for now. - *) gl_cv_func_memchr_works="guessing no" ;; + # Guess no on Android. + linux*-android*) gl_cv_func_memchr_works="guessing no" ;; + # Guess yes on native Windows. + mingw*) gl_cv_func_memchr_works="guessing yes" ;; + # Be pessimistic for now. + *) gl_cv_func_memchr_works="guessing no" ;; esac ]) ]) |